894283 - [Clock] Remove in-app alarm enabled icon

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Clock, defect, P1)

Description

[sync-1]

SW171
 AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.152
 Firefox os  v1.1
 Mozilla build ID:20130702230206
 
 Created an attachment (id=462149)
 PR pic
 
 DEFECT DESCRIPTION:
 The alarm icon still exists even that there is no alarm
 
 REPRODUCING PROCEDURES:
 1.Launch Clock app -> set an alarm in a minute, save it -> then edit this alarm -> on the editing screen,alarm that is set just now comes, press Snooze   -> back to editing screen, press 'Done' to save it -> then turn off this alarm -> now, there is no alarm, but the alarm icon still exists -> KO
 
 EXPECTED BEHAVIOUR:
 The alarm icon shouldn't exist when there is no alarm.
 
 ASSOCIATE SPECIFICATION:
 TEST PLAN REFERENCE:
 TOOLS AND PLATFORMS USED:
 USER IMPACT:
 Mid
 REPRODUCING RATE:
 5/5
 For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: PR pic

Comment 3

[sync-1]

Clone from brother

Comment 4

[sync-1]

Attachment: PR pic

Comment 5

[sync-1]

Clone from brother

Comment 6

[sync-1]

Attachment: Log

Comment 7

[Rick Waldron [:rwaldron]]

(making the STR easier to read)

1.Launch Clock app
2. Tap Alarm + icon
3. Create an alarm for 1 minute from now.
4. Tap "Done" to save.
5. Tap the newly created Alarm in the Alarm List to open Edit view
6. Wait for the Alarm to go off
7. Tap "Snooze"
8. Tap "Done" to save/exit
9. Uncheck the Alarm in the Alarm List

The icon will still be present.

Comment 8

[Rick Waldron [:rwaldron]]

Attachment: devicescreenshot.png

I recommend this be removed altogether, since it's duplicating a system icon

Comment 9

[[e-mail], [e-mail]]

(In reply to sync-1 from comment #0)
>  REPRODUCING PROCEDURES:
>  1.Launch Clock app -> set an alarm in a minute, save it -> then edit this
> alarm -> on the editing screen,alarm that is set just now comes, press
> Snooze   -> back to editing screen, press 'Done' to save it -> then turn off
> this alarm -> now, there is no alarm, but the alarm icon still exists -> KO
The snoozed alarm should be removed(unset). Because the alarm be edited already after a user snoozed it.

Comment 10

[Eric Pang [:epang] UX]

(In reply to Rick Waldron from comment #8)
> Created attachment 790975 [details]
> devicescreenshot.png
> 
> I recommend this be removed altogether, since it's duplicating a system icon

I agree with Rick and Ian on this.  Thanks!

Comment 11

[Rick Waldron [:rwaldron]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/11581

- Per accepted proposal: https://bugzilla.mozilla.org/show_bug.cgi?id=894283#c10
- Removes #clock-hour24-state.alarm-set-indicator::after CSS rule
- Removes ClockView.showHideAlarmSetIndicator

Comment 12

[[e-mail], [e-mail]]

Comment on attachment 791456 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/11581

r=me, thanks for Rick's help. Let's remove the redundant status icon.

Comment 13

[Rick Waldron [:rwaldron]]

gaia@master https://github.com/mozilla-b2g/gaia/commit/57f7398e257890e85c6084c65a1732112cdf0b3d

Comment 14

[田旻]

Dears,

This pr can still reproduce on (Mozilla build ID:20130916041201).

Comment 15

[[e-mail], [e-mail]]

(In reply to 田旻 from comment #14)
> Dears,
> 
> This pr can still reproduce on (Mozilla build ID:20130916041201).
Hi 田旻,

It's imposible to reproduce the issue, if the build version is including of the patch. The indicator icon image has been removed in the patch.