894317 - [ro] b2g localization for Romanian

Status: RESOLVED FIXED

(Mozilla Localizations :: ro / Romanian, defect)

Description

[Axel Hecht [:Pike]]

We'd like to get localization files up for b2g. We'll want them from beta repos down to aurora or central.

I'll help with patches, as we can re-use much of the existing work.

If you're OK, I'll be happy to land those patches, too.

Comment 1

[Axel Hecht [:Pike]]

Attachment: copy files from mobile

I'm copying the files from mobile. As we're not shipping Romanian to release audience and thus don't have a lot of dogfood testing on those files, you might want to take an extra look at the localization in those files, too.

Comment 2

[Raul Nicolae Malea]

Files from here> http://hg.mozilla.org/releases/l10n/mozilla-aurora/ro/file/80eda7f5999b/mobile ?

The patch is correct in my opinion, but it is possible that existing translations to fit on the screen, so be reviewed.

Comment 3

[Axel Hecht [:Pike]]

The strings don't seem to have been touched in about a year. Thus it'd be good to give them an eye.

I don't think they'll need an extra careful review for screen space, as it's mostly about the neterror pages, which show up in the full-screen frame of the browser in Firefox OS. Not so much about buttons or lines here.

Comment 4

[Raul Nicolae Malea]

This bug is fixed?

Comment 5

[Axel Hecht [:Pike]]

No, I'm waiting for your feedback on the strings.

Comment 6

[Raul Nicolae Malea]

These files are correct translated: 
mobile/android/mobile-l10n.js
 mobile/android/chrome/aboutCertError.dtd
mobile/overrides/appstrings.properties
 mobile/overrides/netError.dtd
 mobile/android/defines.inc


Your patch is ok.

Still do not know if all the texts will fit on mobile pfone displays with Firefox OS. I suggest we commit and if will cause problems we open other bugs.

Comment 7

[Francesco Lodolo [:flod]]

(In reply to Raul Malea from comment #6)
> Still do not know if all the texts will fit on mobile pfone displays with
> Firefox OS. I suggest we commit and if will cause problems we open other
> bugs.

I don't predict particular problems: AFAIK these strings will be displayed in web pages, like the one you get on Firefox when a DNS fails, so no space problems.

Comment 8

[Raul Nicolae Malea]

(In reply to Francesco Lodolo [:flod] from comment #7)
> (In reply to Raul Malea from comment #6)
> > Still do not know if all the texts will fit on mobile pfone displays with
> > Firefox OS. I suggest we commit and if will cause problems we open other
> > bugs.
> 
> I don't predict particular problems: AFAIK these strings will be displayed
> in web pages, like the one you get on Firefox when a DNS fails, so no space
> problems.

Ok. Axel, you commit this patch?

Comment 9

[Raul Nicolae Malea]

Comment on attachment 776296 [details] [diff] [review]
copy files from mobile

Patch is ok.

Comment 10

[Axel Hecht [:Pike]]

Thanks.

Landed on beta, and merged to aurora, http://hg.mozilla.org/releases/l10n/mozilla-beta/ro/rev/4a894a16b516.

Comment 11

[Raul Nicolae Malea]

Thanks Axel! Also is my first reviewed patch included in official release :) (bug 894317, copy localization files for b2g, r=raul.malea ). Drink a beer! :D