894381 - FindBar buttons should be enabled when moving tab between windows

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Alice0775 White]

Build Identifier:
http://hg.mozilla.org/mozilla-central/rev/5976b9c673f8
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130715 Firefox/25.0 ID:20130715211256

Steps To Reproduce:
1. Open any page
   ex. https://developer.mozilla.org/en-US/docs/Code_snippets
2. Open FindBar and type "mozilla"
3. Detach the tab
4. Click Up/Down arrow in the FindBar

Actual Results:
Nothing happens

Expected results:
Find prev/next should be performed

Comment 1

[Adam]

Attachment: In swapBrowsersAndCloseOther, poke the findbar after giving it a value, to enable buttons

Thanks Alice!

Bug 890595 fixed this for other cases, but when we move a tab to a different window, we open the findbar without running findbar.startFind().  This does it via findbar.onFindCommand() after we set the _findField.value.

Also adds a test.

Comment 2

[Adam]

Attachment: Prepared for checkin

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=d3d165876c5d

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/31d77791181f

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/31d77791181f

Comment 5

[Petruta Horea [:phorea]]

While testing for the pre-beta sign-off of the Find Bar Redesign feature, I tried to verify this bug with the latest Aurora (build ID: 20130903004001) and the prev/next is performed in the de-attached window.

The search however, is not always accurate, sometimes choosing prev/next in the de-attached window will select the first result in the page, and not the precedent/subsequent outcome of the result found before detaching the tab.

Is this the expected behavior or should I file a new bug for this? Thank you