Closed Bug 894411 Opened 8 years ago Closed 7 years ago

Make customizableui tests not take "long" on debug builds

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: Gijs, Assigned: Gijs)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:M-])

Attachments

(1 file)

Running Chris' script from bug 819963 comment 10 against a recent 10.7 debug log shows:

$ python test_times.py /c/Users/gkruitbosch/Downloads/lion-10.7.txt.gz | grep customizableui
0.037 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_877178_unregisterArea.js
0.042 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_877006_missing_view.js
0.042 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_877447_skip_missing_ids.js
0.042 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_892955_isWidgetRemovable_for_removed_widgets.js
0.042 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_892956_destroyWidget_defaultPlacements.js
0.047 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_890262_destroyWidget_after_add_to_panel.js
0.074 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_887438_currentset_shim.js
0.124 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_873501_handle_specials.js
13.306 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_878452_drag_to_panel.js
14.367 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_885530_showInPrivateBrowsing.js
94.286 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_880382_drag_wide_widgets_in_panel.js

On OS X, we spend about 2 minutes on three tests:

browser_878452_drag_to_panel.js
browser_885530_showInPrivateBrowsing.js
browser_880382_drag_wide_widgets_in_panel.js

I suspect at least the last one can be significantly improved by not jumping in/out of customization mode for all the individual subtests. Similar tricks might help cut the other two tests down to size, too. That could be used to get us out of the immediate danger zone for now - but really, bug 819963 should just be fixed.
Not sure how to prio this.
Whiteboard: [Australis:M?]
I think we shouldn't spend time on this now. Increase the threshold and/or split the tests, and we can come back and optimize test run later.
Whiteboard: [Australis:M?] → [Australis:M-]
Whiteboard: [Australis:M-] → [Australis:M-][Australis:P?]
Whiteboard: [Australis:M-][Australis:P?] → [Australis:M-]
Bug 916735 might end up being good enough to fix this.
Depends on: 916735
This takes the tests from ~25s to ~12s on my fast MBP. I'd expect bigger wins for debug builds. Everything still passes.
Attachment #809472 - Flags: review?(bmcbride)
Assignee: nobody → gijskruitbosch+bugs
Status: NEW → ASSIGNED
Attachment #809472 - Flags: review?(bmcbride) → review+
https://hg.mozilla.org/projects/ux/rev/64c97c4c41f7
Whiteboard: [Australis:M-] → [Australis:M-][fixed-in-ux]
https://hg.mozilla.org/mozilla-central/rev/64c97c4c41f7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M-][fixed-in-ux] → [Australis:M-]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.