894411 - Make customizableui tests not take "long" on debug builds

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[:Gijs (he/him)]

Running Chris' script from bug 819963 comment 10 against a recent 10.7 debug log shows:

$ python test_times.py /c/Users/gkruitbosch/Downloads/lion-10.7.txt.gz | grep customizableui
0.037 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_877178_unregisterArea.js
0.042 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_877006_missing_view.js
0.042 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_877447_skip_missing_ids.js
0.042 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_892955_isWidgetRemovable_for_removed_widgets.js
0.042 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_892956_destroyWidget_defaultPlacements.js
0.047 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_890262_destroyWidget_after_add_to_panel.js
0.074 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_887438_currentset_shim.js
0.124 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_873501_handle_specials.js
13.306 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_878452_drag_to_panel.js
14.367 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_885530_showInPrivateBrowsing.js
94.286 chrome://mochitests/content/browser/browser/components/customizableui/test/browser_880382_drag_wide_widgets_in_panel.js

On OS X, we spend about 2 minutes on three tests:

browser_878452_drag_to_panel.js
browser_885530_showInPrivateBrowsing.js
browser_880382_drag_wide_widgets_in_panel.js

I suspect at least the last one can be significantly improved by not jumping in/out of customization mode for all the individual subtests. Similar tricks might help cut the other two tests down to size, too. That could be used to get us out of the immediate danger zone for now - but really, bug 819963 should just be fixed.

Comment 1

[:Gijs (he/him)]

Not sure how to prio this.

Comment 2

[Justin Dolske [:Dolske]]

I think we shouldn't spend time on this now. Increase the threshold and/or split the tests, and we can come back and optimize test run later.

Comment 3

[Blair McBride [:Unfocused] (UNAVAILABLE)]

Bug 916735 might end up being good enough to fix this.

Comment 4

[:Gijs (he/him)]

Attachment: make CustomizableUI tests run faster,

This takes the tests from ~25s to ~12s on my fast MBP. I'd expect bigger wins for debug builds. Everything still passes.

Comment 5

[:Gijs (he/him)]

https://hg.mozilla.org/projects/ux/rev/64c97c4c41f7

Comment 6

[:Gijs (he/him)]

https://hg.mozilla.org/mozilla-central/rev/64c97c4c41f7