If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Fix minidump_stackwalk to output entire stacks, not just top 1024 frames

RESOLVED FIXED

Status

Socorro
General
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Two years ago the Breakpad code was changed to default to only walking the first 1024 frames of a stack:
http://code.google.com/p/google-breakpad/source/detail?r=672

This is pretty unfortunate for stack overflow crashes, as you don't get to see the call site where everything started. We have very nice stack truncation behavior in Socorro--it keeps the top N frames and bottom M frames (where N and M are configurable), which means you get a pretty usable stack out of stack overflows.

Once we move to a custom minidump_stackwalk binary (bug 573100) it should be easy enough to revert this behavior. Combined with fixing bug 894458, we should be able to output much more useful truncated stacks in these situations.
This turns out to be trivial:
http://hg.mozilla.org/users/tmielczarek_mozilla.com/minidump-stackwalk/rev/5443a115800d
Assignee: nobody → ted
https://github.com/mozilla/socorro/pull/1602

Comment 3

4 years ago
Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/8863b001f2660804e8dcb83ed10b67d3dfa8312b
bug 894483 - remove 1024 frame limit from stacks
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.