894509 - l10n failure in testTabbedBrowser/testNewTab.js

Status: RESOLVED FIXED

(Mozilla QA Graveyard :: Mozmill Tests, defect)

Description

[u279076]

I tried running the Beta automation against more locales this week which resulted in a few failures which seem to be text-case issues...

Firefox 23.0b6#1 pt-PT
> Correct tab title - 'Novo Separador' should equal 'Novo separador'
> http://mozmill-ondemand.blargon7.com/#/functional/report/5aa1ca5e7015e3740d269dc9478565e4

Firefox 23.0b6#1 zu
> Correct tab title - 'I-thebhu entsha' should equal 'Isigqebhe Esisha'
> http://mozmill-ondemand.blargon7.com/#/functional/report/5aa1ca5e7015e3740d269dc947853c77

Firefox 23.0b6#1 sr
> Correct tab title - 'New Tab' should equal 'Нови језичак'
> http://mozmill-ondemand.blargon7.com/#/functional/report/5aa1ca5e7015e3740d269dc947857557

Firefox 23.0b6#1 es-MX
> Correct tab title - 'Pestaña nueva' should equal 'Nueva pestaña' 
> http://mozmill-ondemand.blargon7.com/#/functional/report/5aa1ca5e7015e3740d269dc94785daea

Comment 1

[Andrei Eftimie]

This test is skipped in Aurora and Nightly as per bug 879752

Comment 2

[Andrei Eftimie]

We might check the wrong label in this test.
Still needs some digging, but it looks like we should check the newtab.pageTitle instead of tabs.emptyTabTitle

http://mxr.mozilla.org/l10n-central/source/pt-PT/browser/chrome/browser/newTab.dtd#6

Comment 3

[Andrei Eftimie]

My hunch was correct.
We missed this because for [most?] locales (or at least for the ones we usually test agains) the strings are identical.

See German for example:
http://mxr.mozilla.org/l10n-central/source/de/browser/chrome/browser/tabbrowser.properties#18
http://mxr.mozilla.org/l10n-central/source/de/browser/chrome/browser/newTab.dtd#6

But for the ones that failed mentioned in this bug they are not:
http://mxr.mozilla.org/l10n-central/source/pt-PT/browser/chrome/browser/tabbrowser.properties#16
http://mxr.mozilla.org/l10n-central/source/pt-PT/browser/chrome/browser/newTab.dtd#6

And when we open a new tab, the "newtab.pageTitle" is actually used:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/newtab/newTab.xul#18

Comment 4

[Andrei Eftimie]

Attachment: patch v1

Proper fix, we check the correct label for the title now.
Applies on all branches.

Bear in mind that the test is still skipped on Nightly and Aurora as noted in comment 1

Testruns on the problematic locales:
Nightly: http://mozmill-crowd.blargon7.com/#/functional/report/5aa1ca5e7015e3740d269dc9479f3261
Aurora: http://mozmill-crowd.blargon7.com/#/functional/report/5aa1ca5e7015e3740d269dc947ac603d
Beta: http://mozmill-crowd.blargon7.com/#/functional/report/5aa1ca5e7015e3740d269dc947adc8fe
Release: http://mozmill-crowd.blargon7.com/#/functional/report/5aa1ca5e7015e3740d269dc947af946d
ESR17: http://mozmill-crowd.blargon7.com/#/functional/report/5aa1ca5e7015e3740d269dc947b18e5d

Comment 5

[u279076]

Firefox 23.0 (23.0, es-MX, 20130718163513) on Windows NT 5.1.2600 Service Pack 3 (x86):
http://mozmill-release.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d611ead25

Comment 6

[u279076]

Firefox 23.0 (23.0, sr, 20130718163513) on Windows NT 6.1.7601 Service Pack 1 (x86):
http://mozmill-release.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d611e7d5b

Firefox 23.0 (23.0, es-MX, 20130718163513) on Windows NT 6.2.9200 (x86):
http://mozmill-release.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d611e9b04

Firefox 23.0 (23.0, pt-PT, 20130718163513) on Windows NT 6.1.7601 Service Pack 1 (x86_64):
http://mozmill-release.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d611e861d

Firefox 23.0 (23.0, pt-PT, 20130718163513) on Linux Ubuntu 12.10 (x86_64):
http://mozmill-release.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d611e43ba

Firefox 23.0 (23.0, zu, 20130718163513) on Linux Ubuntu 12.10 (x86):
http://mozmill-release.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d611e179b

Firefox 23.0 (23.0, zh-CN, 20130718163513) on Linux Ubuntu 12.04 (x86_64):
http://mozmill-release.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d611e340a

Firefox 23.0 (23.0, zu, 20130718163513) on Linux Ubuntu 12.04 (x86_64):
http://mozmill-release.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d611e4351

Comment 7

[Andreea Matei [:AndreeaMatei]]

Comment on attachment 777121 [details] [diff] [review]
patch v1

Review of attachment 777121 [details] [diff] [review]:
-----------------------------------------------------------------

Landed on default, I'll backport soon to the other branches as well:
http://hg.mozilla.org/qa/mozmill-tests/rev/afa27ffc8d8a (default)

Comment 8

[Andreea Matei [:AndreeaMatei]]

http://hg.mozilla.org/qa/mozmill-tests/rev/f2d4f3a7a221 (aurora)
http://hg.mozilla.org/qa/mozmill-tests/rev/d84c75623701 (beta)
http://hg.mozilla.org/qa/mozmill-tests/rev/666019db216d (release)
http://hg.mozilla.org/qa/mozmill-tests/rev/242b4f683c14 (esr17)

Thanks!