894567 - getScreenDepth does disk I/O on java UI thread

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Kartikaya Gupta (email:[e-mail])]

07-16 15:47:31.910 D/StrictMode(31694): StrictMode policy violation; ~duration=4 ms: android.os.StrictMode$StrictModeDiskReadViolation: policy=31 violation=2
07-16 15:47:31.910 D/StrictMode(31694):     at android.os.StrictMode$AndroidBlockGuardPolicy.onReadFromDisk(StrictMode.java:1134)
07-16 15:47:31.910 D/StrictMode(31694):     at libcore.io.BlockGuardOs.open(BlockGuardOs.java:106)
07-16 15:47:31.910 D/StrictMode(31694):     at libcore.io.IoBridge.open(IoBridge.java:393)
07-16 15:47:31.910 D/StrictMode(31694):     at java.io.FileInputStream.<init>(FileInputStream.java:78)
07-16 15:47:31.910 D/StrictMode(31694):     at java.io.FileInputStream.<init>(FileInputStream.java:105)
07-16 15:47:31.910 D/StrictMode(31694):     at java.io.FileReader.<init>(FileReader.java:66)
07-16 15:47:31.910 D/StrictMode(31694):     at org.mozilla.gecko.GeckoAppShell.isHighMemoryDevice(GeckoAppShell.java:1345)
07-16 15:47:31.910 D/StrictMode(31694):     at org.mozilla.gecko.GeckoAppShell.getScreenDepth(GeckoAppShell.java:1380)
07-16 15:47:31.910 D/StrictMode(31694):     at org.mozilla.gecko.gfx.GLController.chooseConfig(GLController.java:218)
07-16 15:47:31.910 D/StrictMode(31694):     at org.mozilla.gecko.gfx.GLController.initEGL(GLController.java:210)
07-16 15:47:31.910 D/StrictMode(31694):     at org.mozilla.gecko.gfx.GLController.access$400(GLController.java:31)
07-16 15:47:31.910 D/StrictMode(31694):     at org.mozilla.gecko.gfx.GLController$1.run(GLController.java:151)
07-16 15:47:31.910 D/StrictMode(31694):     at android.os.Handler.handleCallback(Handler.java:730)
07-16 15:47:31.910 D/StrictMode(31694):     at android.os.Handler.dispatchMessage(Handler.java:92)
07-16 15:47:31.910 D/StrictMode(31694):     at android.os.Looper.loop(Looper.java:137)
07-16 15:47:31.910 D/StrictMode(31694):     at android.app.ActivityThread.main(ActivityThread.java:5368)
07-16 15:47:31.910 D/StrictMode(31694):     at java.lang.reflect.Method.invokeNative(Native Method)
07-16 15:47:31.910 D/StrictMode(31694):     at java.lang.reflect.Method.invoke(Method.java:525)
07-16 15:47:31.910 D/StrictMode(31694):     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1046)
07-16 15:47:31.910 D/StrictMode(31694):     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:862)
07-16 15:47:31.910 D/StrictMode(31694):     at dalvik.system.NativeStart.main(Native Method)
07-16 15:47:31.910 D/StrictMode(31694): StrictMode policy violation; ~duration=2 ms: android.os.StrictMode$StrictModeDiskReadViolation: policy=31 violation=2
07-16 15:47:31.910 D/StrictMode(31694):     at android.os.StrictMode$AndroidBlockGuardPolicy.onReadFromDisk(StrictMode.java:1134)
07-16 15:47:31.910 D/StrictMode(31694):     at libcore.io.BlockGuardOs.read(BlockGuardOs.java:148)
07-16 15:47:31.910 D/StrictMode(31694):     at libcore.io.IoBridge.read(IoBridge.java:425)
07-16 15:47:31.910 D/StrictMode(31694):     at java.io.FileInputStream.read(FileInputStream.java:179)
07-16 15:47:31.910 D/StrictMode(31694):     at java.io.InputStreamReader.read(InputStreamReader.java:244)
07-16 15:47:31.910 D/StrictMode(31694):     at java.io.BufferedReader.fillBuf(BufferedReader.java:130)
07-16 15:47:31.910 D/StrictMode(31694):     at java.io.BufferedReader.readLine(BufferedReader.java:354)
07-16 15:47:31.910 D/StrictMode(31694):     at org.mozilla.gecko.GeckoAppShell.isHighMemoryDevice(GeckoAppShell.java:1349)
07-16 15:47:31.910 D/StrictMode(31694):     at org.mozilla.gecko.GeckoAppShell.getScreenDepth(GeckoAppShell.java:1380)
07-16 15:47:31.910 D/StrictMode(31694):     at org.mozilla.gecko.gfx.GLController.chooseConfig(GLController.java:218)
07-16 15:47:31.910 D/StrictMode(31694):     at org.mozilla.gecko.gfx.GLController.initEGL(GLController.java:210)
07-16 15:47:31.910 D/StrictMode(31694):     at org.mozilla.gecko.gfx.GLController.access$400(GLController.java:31)
07-16 15:47:31.910 D/StrictMode(31694):     at org.mozilla.gecko.gfx.GLController$1.run(GLController.java:151)
07-16 15:47:31.910 D/StrictMode(31694):     at android.os.Handler.handleCallback(Handler.java:730)
07-16 15:47:31.910 D/StrictMode(31694):     at android.os.Handler.dispatchMessage(Handler.java:92)
07-16 15:47:31.910 D/StrictMode(31694):     at android.os.Looper.loop(Looper.java:137)
07-16 15:47:31.910 D/StrictMode(31694):     at android.app.ActivityThread.main(ActivityThread.java:5368)
07-16 15:47:31.910 D/StrictMode(31694):     at java.lang.reflect.Method.invokeNative(Native Method)
07-16 15:47:31.910 D/StrictMode(31694):     at java.lang.reflect.Method.invoke(Method.java:525)
07-16 15:47:31.910 D/StrictMode(31694):     at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1046)
07-16 15:47:31.910 D/StrictMode(31694):     at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:862)
07-16 15:47:31.910 D/StrictMode(31694):     at dalvik.system.NativeStart.main(Native Method)

Comment 1

[Will Hawkins]

This is still an issue. We read from /proc/meminfo to determine the total available memory on the device. As long as we do not plan on supporting Android OS versions < 16, we can replace this disk I/O with https://developer.android.com/reference/android/app/ActivityManager.MemoryInfo.html#totalMem.

Does this seem sane? If so, I will be glad to make the change.

Comment 2

[Chris Peterson [:cpeterson]]

(In reply to Will Hawkins from comment #1)

As long as we do not plan on supporting Android OS versions < 16, we can replace this disk I/O with https://developer.android.com/reference/android/app/ActivityManager.MemoryInfo.html#totalMem.

Does this seem sane? If so, I will be glad to make the change.

Good news! Fennec requires Android 4.1 (API level 16) or later, so feel free to replace this code.

For comparison, GeckoView requires Android OS version 4.3 (API Level 18) and Fenix requires Android 5.0 (API level 21).

Comment 3

[Will Hawkins]

Attachment: Bug 894567: Use MemoryInfo.totalMem to get the device's total memory rather than parse /proc/meminfo.

Comment 4

[Chris Peterson [:cpeterson]]

Comment on attachment 9069470 [details]
Bug 894567: Use MemoryInfo.totalMem to get the device's total memory rather than parse /proc/meminfo.

f+

LGTM, but I don't have the authority to review this code. :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/691239688a43
Use MemoryInfo.totalMem to get the device's total memory rather than parse /proc/meminfo. r=nalexander

Comment 6

[Chris Peterson [:cpeterson]]

68=wontfix because we don't need to uplift this optimization to Beta.

Comment 7

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/691239688a43

Comment 8

[Chris Peterson [:cpeterson]]

esr68=wontfix because we don't need to uplift this optimization for Fennec 68.