894576 - Changing the PDF.js warning to be less alarming

Status: VERIFIED FIXED

(Firefox :: PDF Viewer, defect)

Description

[Alex Keybl [:akeybl]]

me - "How do you all feel about changing the color of the bar, but leaving it in? It's very in your face, but most PDFs load just fine these days. Maybe we could also consider making it less aggressive at this point?"

bdahl - "We're currently using PRIORITY_WARNING_LOW, colors are per platform in http://mxr.mozilla.org/mozilla-central/find?text=&string=notification.css. We could change to PRIORITY_INFO_LOW which I think is more grey."

I think that's a great approach. Lukas has already signaled that she'd take this minor change all the way up to Beta 23.

Comment 1

[Brendan Dahl [:bdahl]]

Attachment: mc-info-bar.patch

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fa7746ab3ddf

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 779327 [details] [diff] [review]
mc-info-bar.patch

[Triage Comment]
Pre-approving this one-line patch that we know is low risk so it can get into our next beta this week.

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fa7746ab3ddf

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/696593313840
https://hg.mozilla.org/releases/mozilla-beta/rev/ca2df74bd97b

Comment 6

[Petruta Horea [:phorea], Desktop Test Engineering (back on Sep 5th)]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:25.0) Gecko/20130728 Firefox/25.0
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20130728 Firefox/24.0 
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20100101 Firefox/23.0 
Mozilla/5.0 (X11; Linux x86_64; rv:25.0) Gecko/20130728 Firefox/25.0
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20130728 Firefox/24.0
Mozilla/5.0 (X11; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130728 Firefox/25.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130728 Firefox/24.0
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0

Verified as fixed on Nightly 25.0a1 (Build ID: 20130728030204), Aurora 24.0a2 (Build ID: 20130728004005) and Firefox 23 beta 9 (Build ID: 20130725195523)