Closed
Bug 894576
Opened 11 years ago
Closed 11 years ago
Changing the PDF.js warning to be less alarming
Categories
(Firefox :: PDF Viewer, defect)
Firefox
PDF Viewer
Tracking
()
VERIFIED
FIXED
Firefox 25
People
(Reporter: akeybl, Assigned: bdahl)
Details
(Whiteboard: [pdfjs-c-ux][pdfjs-f-fixed-upstream] https://github.com/mozilla/pdf.js/pull/3504)
Attachments
(1 file)
1.43 KB,
patch
|
yury
:
review+
lsblakk
:
approval-mozilla-aurora+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
me - "How do you all feel about changing the color of the bar, but leaving it in? It's very in your face, but most PDFs load just fine these days. Maybe we could also consider making it less aggressive at this point?" bdahl - "We're currently using PRIORITY_WARNING_LOW, colors are per platform in http://mxr.mozilla.org/mozilla-central/find?text=&string=notification.css. We could change to PRIORITY_INFO_LOW which I think is more grey." I think that's a great approach. Lukas has already signaled that she'd take this minor change all the way up to Beta 23.
Reporter | ||
Updated•11 years ago
|
tracking-firefox23:
--- → ?
Updated•11 years ago
|
Updated•11 years ago
|
Attachment #779327 -
Flags: review?(ydelendik) → review+
Updated•11 years ago
|
OS: Mac OS X → All
Hardware: x86 → All
Whiteboard: [pdfjs-c-ux][pdfjs-f-fixed-upstream] https://github.com/mozilla/pdf.js/pull/3504
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa7746ab3ddf
Keywords: checkin-needed
Comment 3•11 years ago
|
||
Comment on attachment 779327 [details] [diff] [review] mc-info-bar.patch [Triage Comment] Pre-approving this one-line patch that we know is low risk so it can get into our next beta this week.
Attachment #779327 -
Flags: approval-mozilla-beta+
Attachment #779327 -
Flags: approval-mozilla-aurora+
https://hg.mozilla.org/mozilla-central/rev/fa7746ab3ddf
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 25
Comment 5•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/696593313840 https://hg.mozilla.org/releases/mozilla-beta/rev/ca2df74bd97b
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:25.0) Gecko/20130728 Firefox/25.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:24.0) Gecko/20130728 Firefox/24.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20100101 Firefox/23.0 Mozilla/5.0 (X11; Linux x86_64; rv:25.0) Gecko/20130728 Firefox/25.0 Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20130728 Firefox/24.0 Mozilla/5.0 (X11; Linux x86_64; rv:23.0) Gecko/20100101 Firefox/23.0 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:25.0) Gecko/20130728 Firefox/25.0 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20130728 Firefox/24.0 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:23.0) Gecko/20100101 Firefox/23.0 Verified as fixed on Nightly 25.0a1 (Build ID: 20130728030204), Aurora 24.0a2 (Build ID: 20130728004005) and Firefox 23 beta 9 (Build ID: 20130725195523)
Status: RESOLVED → VERIFIED
Keywords: verifyme
You need to log in
before you can comment on or make changes to this bug.
Description
•