894761 - Fail in configure when building with --enable-application=mobile/android without a proper --target

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

Since #mobile people are apparently inviting new developers to use the in-tree mozconfig, I figured I'd try to see what happens with minimalistic mozconfigs, and started with:

  ac_add_options --enable-application=mobile/android

Which happily builds for 20 minutes until the app tier is reached. That's a waste of a lot of time.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Fail in configure when building with --enable-application=mobile/android without a proper --target

Comment 2

[(not currently active) Ted Mielczarek]

Comment on attachment 776890 [details] [diff] [review]
Fail in configure when building with --enable-application=mobile/android without a proper --target

Review of attachment 776890 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +4526,5 @@
> +        *-android*|*-linuxandroid*)
> +            :
> +            ;;
> +        *)
> +            AC_MSG_ERROR([You must specify --target=some-android-target when building with --enable-application=mobile/android])

Can you put in a link to a wiki page with more information? Also, might be more helpful to just mention the most sane default here, like --target=arm-linux-androideabi

Comment 3

[Mike Hommey [:glandium]]

(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> Can you put in a link to a wiki page with more information? Also, might be
> more helpful to just mention the most sane default here, like
> --target=arm-linux-androideabi

There's also x86 android...

Comment 4

[(not currently active) Ted Mielczarek]

Sure, this is just the most common usage. It seems better than the faux "--target=some-android-target".

Comment 5

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d45f9158606c

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d45f9158606c