Closed Bug 894761 Opened 7 years ago Closed 7 years ago

Fail in configure when building with --enable-application=mobile/android without a proper --target

Categories

(Firefox Build System :: General, defect)

All
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla25

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

Since #mobile people are apparently inviting new developers to use the in-tree mozconfig, I figured I'd try to see what happens with minimalistic mozconfigs, and started with:

  ac_add_options --enable-application=mobile/android

Which happily builds for 20 minutes until the app tier is reached. That's a waste of a lot of time.
Comment on attachment 776890 [details] [diff] [review]
Fail in configure when building with --enable-application=mobile/android without a proper --target

Review of attachment 776890 [details] [diff] [review]:
-----------------------------------------------------------------

::: configure.in
@@ +4526,5 @@
> +        *-android*|*-linuxandroid*)
> +            :
> +            ;;
> +        *)
> +            AC_MSG_ERROR([You must specify --target=some-android-target when building with --enable-application=mobile/android])

Can you put in a link to a wiki page with more information? Also, might be more helpful to just mention the most sane default here, like --target=arm-linux-androideabi
Attachment #776890 - Flags: review?(ted) → review+
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2)
> Can you put in a link to a wiki page with more information? Also, might be
> more helpful to just mention the most sane default here, like
> --target=arm-linux-androideabi

There's also x86 android...
Sure, this is just the most common usage. It seems better than the faux "--target=some-android-target".
https://hg.mozilla.org/mozilla-central/rev/d45f9158606c
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.