894815 - [Buri] Alarm screen and permission screen displays abnormally on the top of Apps

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[sync-1]

AU_LINUX_GECKO_ICS_STRAWBERRY.01.01.00.019.152
 Firefox os  v1.1
 Mozilla build ID:20130702230206
 
 Created an attachment (id=463326)
 PIC
 
 DEFECT DESCRIPTION:
  The screen display abnormally on he top in camera
  REPRODUCING PROCEDURES:
  Prerequisites:
  Geolocation option needs to be enabled in Settings.
  1.Launch the Settings app.
  2.Scroll down to Phone Lock and enable Lock Screen and enable Passcode Lock with a valid passcode.
  3.Exit Settings to Home screen then tap the Power button to lock the phone.
  4.Tap the power button again then tap the Camera icon on the lock screen.
  5.Wait a couple seconds.
  6.The screen display abnormally on he top->KO
  EXPECTED BEHAVIOUR:
  The screen should display correctly
  ASSOCIATE SPECIFICATION:
 
  TEST PLAN REFERENCE:
 
  TOOLS AND PLATFORMS USED:
 
  USER IMPACT:
  Mid
  REPRODUCING RATE:
  5/5
  For FT PR, Please list reference mobile's behavior:

Comment 1

[sync-1]

Clone from brother

Comment 2

[Mike Habicher [:mikeh] (high bugzilla latency)]

Can you please attach a screenshot?

Comment 3

[buri.blff]

Attachment: pic

Comment 4

[buri.blff]

Attachment: sometimes,the system will reset

Comment 5

[Sotaro Ikeda [:sotaro]]

(In reply to buri.blff from comment #4)
> Created attachment 778262 [details]
> sometimes,the system will reset

buri.blff, can you create another bug for it. It is a different bug.

Comment 6

[Sotaro Ikeda [:sotaro]]

This ui behavior is controlled by System App. It seems like System app's bug. The crash seems a camera related bug.

Comment 7

[Sotaro Ikeda [:sotaro]]

FYI, mikeh is PTO until Aug 5.

Comment 8

[buri.blff]

(In reply to Sotaro Ikeda [:sotaro] from comment #5)
> (In reply to buri.blff from comment #4)
> > Created attachment 778262 [details]
> > sometimes,the system will reset
> 
> buri.blff, can you create another bug for it. It is a different bug.

OK, I will file a new bug.

Comment 9

[Wayne Chang [:wchang]]

Triage - Buri can you confirm after closing the dialogue in the attached image, the camera functions correctly?

Comment 10

[buri.blff]

(In reply to Wayne Chang [:wchang] from comment #9)
> Triage - Buri can you confirm after closing the dialogue in the attached
> image, the camera functions correctly?

The camera functions is OK.

Comment 11

[bhavana bajaj [:bajaj]]

Not blocking given testing in comment 10

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

Taken. UI polish.

Comment 13

[Mike Habicher [:mikeh] (high bugzilla latency)]

(In reply to Alive Kuo [:alive] from comment #12)
>
> Taken. UI polish.

BTW, alive: I notice that the text in the message says "_System_ would like to know your location." This is because the lockscreen runs in the System app; but I hate to say it: this will probably be confusing to the user. Can we make it say _Camera_ instead?

Comment 14

[(inactive after 6/18) Alive Kuo [:alive]]

Ya, I knew this before...and I am afraid there's no way to fix it now. The name is provided from gecko side.

Comment 16

[Scoobidiver (away)]

leo+ requested per bug 899451.

Comment 17

[bhavana bajaj [:bajaj]]

Still not a blocker given the workaround in comment #10.Pushing this to 1.2 for consideration.

Comment 19

[Leo]

Please re-evaluate on blocking status considering bug 902814. This can be reproduced with applications like Gallery, Video and many more 3rd Party Apps like Notes, Cut the rope.

Comment 20

[Leo]

Attachment: Alarm permission request screen above camera

This is a screenshot with Geolocation permission request view and Alarm "OnRing" screen on top of camera for Leo device.

Comment 21

[hanj.kim25]

(In reply to Alive Kuo [:alive] from comment #14)
> Ya, I knew this before...and I am afraid there's no way to fix it now. The
> name is provided from gecko side.

Hi Alive, 

Wasn't this issue fixed by 889175 before?
Somehow I can reproduce the issue now.

Comment 22

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to hanj.kim25 from comment #21)
> (In reply to Alive Kuo [:alive] from comment #14)
> > Ya, I knew this before...and I am afraid there's no way to fix it now. The
> > name is provided from gecko side.
> 
> Hi Alive, 
> 
> Wasn't this issue fixed by 889175 before?
> Somehow I can reproduce the issue now.

I'm replying this:

(In reply to Mike Habicher [:mikeh] from comment #13)
> BTW, alive: I notice that the text in the message says "_System_ would like
> to know your location." This is because the lockscreen runs in the System
> app; but I hate to say it: this will probably be confusing to the user. Can
> we make it say _Camera_ instead?

And even the original issue is different from 889175.
Do you still repro 889175?

Comment 23

[hanj.kim25]

(In reply to Alive Kuo [:alive] from comment #22)

I see. I thought this is the same issue as 889175. 

Yes, for some reason I can repro 889175. I think, I verified the patch before..

Comment 24

[(inactive after 6/18) Alive Kuo [:alive]]

Hmm, I cannot repro using "Mozilla"'s v1-train.
Could you use mozilla v1-train to repro?

Comment 25

[hanj.kim25]

(In reply to Alive Kuo [:alive] from comment #24)
> Hmm, I cannot repro using "Mozilla"'s v1-train.
> Could you use mozilla v1-train to repro?

I have tested with the latest v1-train and I have seen the statusbar becoming transparent. Please take a look at a new bug I created, 903271.

Comment 27

[(inactive after 6/18) Alive Kuo [:alive]]

This seems only reproducible in v1-train

Comment 28

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Stealing..

Comment 29

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

Just hesitated whether I should add a .fullscreen-app to #screen when switching
to lockscreen camera.. In the end I decide just do css polish after looking around 
current codes.

Alive may you review the patch?

Comment 30

[KM Lee [:rexboy] (inactivate after Sep. 22)]

The patch fixes both 
 - Alarm screen on secure camera (fail on both master and v1-train)
 - Permission screen on secure camera (fail on v1-train)

The latter one simply doesn't jump up on master.

Comment 31

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patched screenshot 1 (alarm)

Comment 32

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patched screenshot 2 (permission window)

Comment 33

[Scoobidiver (away)]

What about the symptoms of bug 903271 for Incoming Call (duplicated to this bug)?

Comment 34

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 788151 [details]
patch

r=me, thanks.

Comment 35

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Scoobidiver from comment #33)
> What about the symptoms of bug 903271 for Incoming Call (duplicated to this
> bug)?

Different issue I think. Rex do you want to take it too?

Comment 36

[Scoobidiver (away)]

(In reply to Alive Kuo [:alive] from comment #35)
> (In reply to Scoobidiver from comment #33)
> > What about the symptoms of bug 903271 for Incoming Call (duplicated to this
> > bug)?
> Different issue I think. Rex do you want to take it too?
If it's too different, you can undupe bug 903271.

Comment 37

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Yes it's different issue. This bug doesn't help bug 903271.

Seems there's already a patch by Leo? Anyway we can take a look there, let's
close this bug first.

Comment 38

[KM Lee [:rexboy] (inactivate after Sep. 22)]

master:
https://github.com/mozilla-b2g/gaia/commit/94a40401610c28fb47419d44726f199a0fae742e

Comment 39

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 94a40401610c28fb47419d44726f199a0fae742e to:
v1-train: 4cd749e4136473c3835667689ecccfa1961e4e64

Comment 40

[hanj.kim25]

(In reply to KM Lee [:rexboy] from comment #37)
> Yes it's different issue. This bug doesn't help bug 903271.
> 
> Seems there's already a patch by Leo? Anyway we can take a look there, let's
> close this bug first.

(In reply to Alive Kuo [:alive] from comment #34)
> Comment on attachment 788151 [details]
> patch
> 
> r=me, thanks.

I have tested with the latest v1-train and the issue is still reproducible. 
The last commit of v1-train was 0c6b0cefeee504b7ed42ba36b983f155b8c6d666.

Steps to repro:
1. Launch Clock app and set an alarm for the next minute.
2. Launch Gallery app and wait until the alarm set off.

The statuabar is still transparent..

Comment 41

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 4cd749e4136473c3835667689ecccfa1961e4e64

Comment 42

[hanj.kim25]

(In reply to KM Lee [:rexboy] from comment #37)
> Yes it's different issue. This bug doesn't help bug 903271.
> 
> Seems there's already a patch by Leo? Anyway we can take a look there, let's
> close this bug first.

The patch suggested by Leo was to hide the statusbar, instead of transparent statusbar area. I guess the patch is not acceptable because it changes the behavior..

Comment 43

[KM Lee [:rexboy] (inactivate after Sep. 22)]

> 
> Steps to repro:
> 1. Launch Clock app and set an alarm for the next minute.
> 2. Launch Gallery app and wait until the alarm set off.
> 
> The statuabar is still transparent..

This symptom looks similar but it needs a different patch. Secure camera is an
individual component inside system app, whereas gallery app is an full-screen app.
Since they don't share the same layout rule, I think we can open another
bug for it.

Comment 44

[hanj.kim25]

(In reply to KM Lee [:rexboy] from comment #43)

Then, does the Bug 903271 cover the Gallery app case?

   Bug 903271 - [Statusbar] becomes transparent on incoming call using fullscreen app

No need to open a new bug?

Comment 45

[KM Lee [:rexboy] (inactivate after Sep. 22)]

I can try to ensure the STR in comment #40 in bug 903271.