Memory Card import needs to support contact dedup

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jmcf, Assigned: jmcf)

Tracking

unspecified
x86
Mac OS X
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:koi+)

Details

(Whiteboard: [u=commsapps-user c=dialer p=0])

Attachments

(4 attachments)

Comment hidden (empty)
Before I start with this, is there a general way to solve duplicates in import APIs?
(Assignee)

Comment 2

5 years ago
yes, it is ongoing, please wait until all the related bugs land
(Assignee)

Updated

5 years ago
blocking-b2g: --- → koi?
(Assignee)

Comment 4

5 years ago
Sergi, You can start with this bug if you have time. Please see import_sim_contacts.js for an example on how to deal with matching and merging.
(Assignee)

Updated

5 years ago
Assignee: nobody → jmcf
(Assignee)

Comment 5

5 years ago
Created attachment 781035 [details]
Pointer to GH PR
Attachment #781035 - Flags: review?(sergi.mansilla)
Is this supposed to avoid duplication when importing the same contacts several times? When I test it on the device, it duplicates existing contacts when I run the importer twice.
Flags: needinfo?(jmcf)
(Assignee)

Comment 7

5 years ago
yes, it is. It was working perfectly for me. Please, could you attach the vCard you were using for your tests? thanks
Flags: needinfo?(jmcf)
Created attachment 783023 [details]
VCF cards example

I am testing with this vcard file.
(Assignee)

Comment 9

5 years ago
Sergi,

I think you are testing with the wrong branch. With your vcard file it is working perfectly for me. I have rebased the branch, please update your branch with the correct one and test again. 

thanks
(Assignee)

Comment 10

5 years ago
If I don't get review results by today I will re-assign review to Francisco. 

best
I will try again today and let you know.

Thanks
Created attachment 783689 [details]
Screenshot of duplicated contacts and device info

Jose Manuel,

I still have the same issue with your branch. I am testing on a Peak, B2G 1.2, Build ID 20130729085713. Git Gaia commit is fa5fe75ee97, and I am doing the following:

- Open contacts app
- Contact Settings -> Memory Card import
- The process goes smoothly, but it adds duplicated contacts each time I repeat the process.

Please let me know if I am on a wrong build or if I am not testing the proper flow.
We are on track for catching this x file :)

Thanks Sergi and Jose Manuel!
(Assignee)

Comment 14

5 years ago
Hi Sergi,

Could you test the same example removing the SIM card from your device? It seems the 'match' filter in contacts API is not working properly with your SIM. 

Please let me know
Flags: needinfo?(sergi.mansilla)
(Assignee)

Updated

5 years ago
Depends on: 900480
Hi Jose Manuel,

I was testing with a device with no SIM card in it, just a SD card with the contacts file in it.
Flags: needinfo?(sergi.mansilla)

Updated

5 years ago
Whiteboard: [u=commsapps-user c=dialer p=0]
blocking-b2g: koi? → koi+
Hi Jose: is this really targeted for Sprint 3?
Flags: needinfo?(jmcf)
Hi Joe, don't think so, we've just removed it from sprint 3 and added to "ready backlog" for v1.2
Flags: needinfo?(jmcf)
(Assignee)

Comment 18

5 years ago
Created attachment 800188 [details]
11955.html
Attachment #800188 - Flags: review?(francisco.jordano)
(Assignee)

Updated

5 years ago
Attachment #781035 - Flags: review?(sergi.mansilla)
(Assignee)

Comment 19

5 years ago
Comment on attachment 781035 [details]
Pointer to GH PR

this patch is obsolete
Comment on attachment 800188 [details]
11955.html

Code looking good to me, and unit tests passing locally.

r+!

Thanks Jose Manuel!
Attachment #800188 - Flags: review?(francisco.jordano) → review+
(Assignee)

Comment 21

5 years ago
https://github.com/mozilla-b2g/gaia/commit/29c0baad1ad100648cc080e17dc42c96bd6cf841
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.