894872 - Memory Card import needs to support contact dedup

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Comment 1

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Before I start with this, is there a general way to solve duplicates in import APIs?

Comment 2

[Jose Manuel Cantera]

yes, it is ongoing, please wait until all the related bugs land

Comment 3

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Ok, thanks.

Comment 4

[Jose Manuel Cantera]

Sergi, You can start with this bug if you have time. Please see import_sim_contacts.js for an example on how to deal with matching and merging.

Comment 5

[Jose Manuel Cantera]

Attachment: Pointer to GH PR

Comment 6

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Is this supposed to avoid duplication when importing the same contacts several times? When I test it on the device, it duplicates existing contacts when I run the importer twice.

Comment 7

[Jose Manuel Cantera]

yes, it is. It was working perfectly for me. Please, could you attach the vCard you were using for your tests? thanks

Comment 8

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: VCF cards example

I am testing with this vcard file.

Comment 9

[Jose Manuel Cantera]

Sergi,

I think you are testing with the wrong branch. With your vcard file it is working perfectly for me. I have rebased the branch, please update your branch with the correct one and test again. 

thanks

Comment 10

[Jose Manuel Cantera]

If I don't get review results by today I will re-assign review to Francisco. 

best

Comment 11

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

I will try again today and let you know.

Thanks

Comment 12

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Attachment: Screenshot of duplicated contacts and device info

Jose Manuel,

I still have the same issue with your branch. I am testing on a Peak, B2G 1.2, Build ID 20130729085713. Git Gaia commit is fa5fe75ee97, and I am doing the following:

- Open contacts app
- Contact Settings -> Memory Card import
- The process goes smoothly, but it adds duplicated contacts each time I repeat the process.

Please let me know if I am on a wrong build or if I am not testing the proper flow.

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

We are on track for catching this x file :)

Thanks Sergi and Jose Manuel!

Comment 14

[Jose Manuel Cantera]

Hi Sergi,

Could you test the same example removing the SIM card from your device? It seems the 'match' filter in contacts API is not working properly with your SIM. 

Please let me know

Comment 15

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Hi Jose Manuel,

I was testing with a device with no SIM card in it, just a SD card with the contacts file in it.

Comment 16

[Joe Cheng [:jcheng] (please needinfo)]

Hi Jose: is this really targeted for Sprint 3?

Comment 17

[Noemí Freire (:noemi)]

Hi Joe, don't think so, we've just removed it from sprint 3 and added to "ready backlog" for v1.2

Comment 18

[Jose Manuel Cantera]

Attachment: 11955.html

Comment 19

[Jose Manuel Cantera]

Comment on attachment 781035 [details]
Pointer to GH PR

this patch is obsolete

Comment 20

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 800188 [details]
11955.html

Code looking good to me, and unit tests passing locally.

r+!

Thanks Jose Manuel!

Comment 21

[Jose Manuel Cantera]

https://github.com/mozilla-b2g/gaia/commit/29c0baad1ad100648cc080e17dc42c96bd6cf841