Before I start with this, is there a general way to solve duplicates in import APIs?
yes, it is ongoing, please wait until all the related bugs land
Sergi, You can start with this bug if you have time. Please see import_sim_contacts.js for an example on how to deal with matching and merging.
Created attachment 781035 [details] Pointer to GH PR
Is this supposed to avoid duplication when importing the same contacts several times? When I test it on the device, it duplicates existing contacts when I run the importer twice.
yes, it is. It was working perfectly for me. Please, could you attach the vCard you were using for your tests? thanks
Sergi, I think you are testing with the wrong branch. With your vcard file it is working perfectly for me. I have rebased the branch, please update your branch with the correct one and test again. thanks
If I don't get review results by today I will re-assign review to Francisco. best
I will try again today and let you know. Thanks
Created attachment 783689 [details] Screenshot of duplicated contacts and device info Jose Manuel, I still have the same issue with your branch. I am testing on a Peak, B2G 1.2, Build ID 20130729085713. Git Gaia commit is fa5fe75ee97, and I am doing the following: - Open contacts app - Contact Settings -> Memory Card import - The process goes smoothly, but it adds duplicated contacts each time I repeat the process. Please let me know if I am on a wrong build or if I am not testing the proper flow.
We are on track for catching this x file :) Thanks Sergi and Jose Manuel!
Hi Sergi, Could you test the same example removing the SIM card from your device? It seems the 'match' filter in contacts API is not working properly with your SIM. Please let me know
Hi Jose Manuel, I was testing with a device with no SIM card in it, just a SD card with the contacts file in it.
Hi Jose: is this really targeted for Sprint 3?
Hi Joe, don't think so, we've just removed it from sprint 3 and added to "ready backlog" for v1.2
Created attachment 800188 [details] 11955.html
Attachment #800188 - Flags: review?(francisco.jordano)
Comment on attachment 800188 [details] 11955.html Code looking good to me, and unit tests passing locally. r+! Thanks Jose Manuel!
Attachment #800188 - Flags: review?(francisco.jordano) → review+
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.