Closed Bug 894884 Opened 6 years ago Closed 6 years ago
B2G RIL: Enable get
Card Lock Retry Count on emulator
409 bytes, text/html
1.86 KB, patch
|Details | Diff | Splinter Review|
We need to enable the quirk RILQUIRKS_HAVE_QUERY_ICC_LOCK_RETRY_COUNT.
Hi Vicamo, I added some Makefiles to the device/generic/goldfish for setting the RIL quirk, but it doesn't work. The commit is available at https://github.com/tdz/device_generic_goldfish/commit/07d42fea01e7f00f8217b7155911ec55d3ec2cc9 The files are parsed by the build system, but the defined property does not show up in the builds 'system/build.prop'. I've seen this working for the phones. Did I miss something? Or is there a major difference between the emulator and the phone's build systems that causes this problem?
Hi Thomas, Emulator variants' product files are located in https://github.com/mozilla-b2g/platform_build/tree/master/target/product/ . We're using |full.mk| for emulator and |full_x86.mk| emulator-x86. But Unagi also inherits |full.mk| as well, so having that overriding on inheritance path of |full.mk| might be a bad idea. To add read-only properties, we have ADDITIONAL_DEFAULT_PROPERTIES (installed to /default.prop) and ADDITIONAL_BUILD_PROPERTIES (installed to /system/build.prop). Both are affected by ordinary |Android.mk| files. So you can simply have following code in device/generic/goldfish/Android.mk: ADDITIONAL_DEFAULT_PROPERTIES += \ ro.moz.ril.have_query_icc_lock_retry_count=true \ $(NULL) : https://github.com/mozilla-b2g/android-device-unagi/blob/master/full_unagi.mk#L11
Thanks for your help, Vicamo. This makefile sets the property correctly. The whole thing was quite painful. After I set property it still didn't work for an unknown reason. I finally figured out that Android's init filters out all properties with names longer then 32 characters. So I also had to shorten the string bit.
Attachment #777858 - Flags: review?(vyang)
This is the Gecko change for the new property name.
Attachment #777859 - Flags: review?(vyang)
Comment on attachment 777859 [details] [diff] [review] Bug 894884: Use ro.moz.ril.query_icc_count property Review of attachment 777859 [details] [diff] [review]: ----------------------------------------------------------------- Sorry I forgot that 32 chars limit. Thank you :)
Attachment #777859 - Flags: review?(vyang) → review+
Comment on attachment 777858 [details] https://github.com/mozilla-b2g/device_generic_goldfish/pull/3 Actually I said |Android.mk|, not |AndroidProducts.mk|. Anyway, this PR has been merged and I just had another fix to correct this.
Attachment #777858 - Flags: review?(vyang) → review-
Please check-in attachment 777859 [details] [diff] [review] after g-m-o has picked up device/generic/goldfish merges. : http://git.mozilla.org/?p=b2g/device_generic_goldfish.git;a=summary
(In reply to Vicamo Yang [:vicamo][:vyang] from comment #6) > Comment on attachment 777858 [details] > https://github.com/mozilla-b2g/device_generic_goldfish/pull/3 > > Actually I said |Android.mk|, not |AndroidProducts.mk|. Anyway, this PR has > been merged and I just had another fix to correct this. Oops :( Thanks for fixing this.
Thanks Vicamo. https://hg.mozilla.org/projects/birch/rev/21200bb2eaf0
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.