Created attachment 777124 [details] [diff] [review] part 1: make AppendBackgroundItemsToTop return a bool instead of an nsDisplayBackgroundImage I think it makes sense to separate -moz-appearance handling from nsDisplayBackgroundImage because there's an if (mIsThemed) at the beginning of almost every nsDisplayBackgroundImage method.
Attachment #777124 - Flags: review?(roc)
Created attachment 777126 [details] [diff] [review] part 2: create nsDisplayThemedBackground There's one unfortunate aspect of this change, and that's the need to create another subclass for nsDisplayCanvasThemedBackground. Apparently, the purpose of this class is to clip painting properly. However, it looks like we ignore the clip rect for -moz-appearance anyway, so I'm not sure whether it makes sense to have the class.
Attachment #777126 - Flags: review?(roc)
Attachment #777124 - Flags: review?(roc) → review+
Attachment #777126 - Flags: review?(roc) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.