Create a new nsDisplayThemedBackground class instead of lumping it together with nsDisplayBackgroundImage

RESOLVED FIXED in mozilla25

Status

()

Core
Layout
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mstange, Assigned: mstange)

Tracking

(Blocks: 1 bug)

Trunk
mozilla25
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
Created attachment 777124 [details] [diff] [review]
part 1: make AppendBackgroundItemsToTop return a bool instead of an nsDisplayBackgroundImage

I think it makes sense to separate -moz-appearance handling from nsDisplayBackgroundImage because there's an if (mIsThemed) at the beginning of almost every nsDisplayBackgroundImage method.
Attachment #777124 - Flags: review?(roc)
(Assignee)

Comment 1

5 years ago
Created attachment 777126 [details] [diff] [review]
part 2: create nsDisplayThemedBackground

There's one unfortunate aspect of this change, and that's the need to create another subclass for nsDisplayCanvasThemedBackground. Apparently, the purpose of this class is to clip painting properly. However, it looks like we ignore the clip rect for -moz-appearance  anyway, so I'm not sure whether it makes sense to have the class.
Attachment #777126 - Flags: review?(roc)
https://hg.mozilla.org/mozilla-central/rev/9cc2abd1f1a0
https://hg.mozilla.org/mozilla-central/rev/fcc730af1e8b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.