Closed Bug 894905 Opened 6 years ago Closed 6 years ago

Create a new nsDisplayThemedBackground class instead of lumping it together with nsDisplayBackgroundImage

Categories

(Core :: Layout, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla25

People

(Reporter: mstange, Assigned: mstange)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

I think it makes sense to separate -moz-appearance handling from nsDisplayBackgroundImage because there's an if (mIsThemed) at the beginning of almost every nsDisplayBackgroundImage method.
Attachment #777124 - Flags: review?(roc)
There's one unfortunate aspect of this change, and that's the need to create another subclass for nsDisplayCanvasThemedBackground. Apparently, the purpose of this class is to clip painting properly. However, it looks like we ignore the clip rect for -moz-appearance  anyway, so I'm not sure whether it makes sense to have the class.
Attachment #777126 - Flags: review?(roc)
https://hg.mozilla.org/mozilla-central/rev/9cc2abd1f1a0
https://hg.mozilla.org/mozilla-central/rev/fcc730af1e8b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.