Closed Bug 894905 Opened 6 years ago Closed 6 years ago
Create a new ns
Display Themed Background class instead of lumping it together with ns Display Background Image
I think it makes sense to separate -moz-appearance handling from nsDisplayBackgroundImage because there's an if (mIsThemed) at the beginning of almost every nsDisplayBackgroundImage method.
Attachment #777124 - Flags: review?(roc)
There's one unfortunate aspect of this change, and that's the need to create another subclass for nsDisplayCanvasThemedBackground. Apparently, the purpose of this class is to clip painting properly. However, it looks like we ignore the clip rect for -moz-appearance anyway, so I'm not sure whether it makes sense to have the class.
Attachment #777126 - Flags: review?(roc)
Attachment #777124 - Flags: review?(roc) → review+
Attachment #777126 - Flags: review?(roc) → review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.