Closed
Bug 894926
Opened 11 years ago
Closed 11 years ago
[Dialer][Call log] Close DB before deleting it
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Tracking
(blocking-b2g:koi+)
RESOLVED
FIXED
| blocking-b2g | koi+ |
People
(Reporter: ferjm, Assigned: ferjm)
References
Details
(Whiteboard: [u=commsapps-user c=dialer p=0])
Attachments
(1 file, 1 obsolete file)
|
2.21 KB,
patch
|
gtorodelvalle
:
review+
|
Details | Diff | Splinter Review |
We cannot delete an opened indexedDB.
|
Assignee | |
Comment 1•11 years ago
|
||
Assignee: nobody → ferjmoreno
Attachment #777137 -
Flags: review?(etienne)
|
||
Comment 2•11 years ago
|
||
Thanks Fernando! As soon as this lands, we will be able to merge https://github.com/mozilla-b2g/gaia/pull/11001 with all the tests cases passing ;-)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 777137 [details] [diff] [review]
v1
I've been told that Etienne is on PTO, so moving the review to Germán.
Attachment #777137 -
Flags: review?(etienne) → review?(gtorodelvalle)
|
|
Assignee | |
Comment 4•11 years ago
|
||
This blocks a koi? that blocks a koi+, so koi?
blocking-b2g: --- → koi?
|
||
Updated•11 years ago
|
Whiteboard: [u=commsapps-user c=dialer p=0]
|
|
Assignee | |
Comment 5•11 years ago
|
||
Rebased patch
Attachment #777137 -
Attachment is obsolete: true
Attachment #777137 -
Flags: review?(gtorodelvalle)
Attachment #778418 -
Flags: review?(gtorodelvalle)
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 778418 [details] [diff] [review]
v1
Simple and effective patch! ;-) Unit tests up and running, even the new "Clean up" one at the end of calllog_db_test.js. We're good to prepare the PR and merge. Thanks!
Attachment #778418 -
Flags: review?(gtorodelvalle) → review+
|
||
Updated•11 years ago
|
blocking-b2g: koi? → koi+
|
|
Assignee | |
Comment 7•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•