894958 - Improve Negatus support for Linux

Status: RESOLVED FIXED

(Testing Graveyard :: SUTAgent, defect)

Description

[Dan Minor [:dminor]]

In the course of doing some tests of Negatus on Linux to support the WebRTC testing improvement work, I've hit a few things that do not work as expected:
* info os
* info memory
* ps
* default test root

I have a patch for the above, but I'll hold off submitting to see if any other small issues come up over the next few days.

Comment 1

[Mark Côté [:mcote]]

Saw this patch still sitting in your fork--maybe it's time to submit it? :)

Comment 2

[Dan Minor [:dminor]]

Attachment: Small linux fixes

Probably tomorrow I'll find something new to fix :)

The changes from int to long in memory() were necessary to avoid overflows on linux. I'm guessing this will do the appropriate thing on B2G, but maybe it should be #ifdef'ed.

Comment 3

[Mark Côté [:mcote]]

Comment on attachment 8355273 [details] [diff] [review]
Small linux fixes

Review of attachment 8355273 [details] [diff] [review]:
-----------------------------------------------------------------

This breaks Android support, at least, since __linux__ is defined there, and I wouldn't be surprised if it is on b2g too.  We'll need a better way to determine if this is a desktop linux distro or a linux-based device (android, b2g).

Comment 4

[Dan Minor [:dminor]]

Attachment: Small linux fixes.

Added a define in Makefile.linux for desktop linux builds.

Sorry, I should have done an Android build for the last patch. Unfortunately I don't have access to my Android test device this week, so once again this is only tested this on Linux.

Comment 5

[Mark Côté [:mcote]]

Comment on attachment 8356181 [details] [diff] [review]
Small linux fixes.

Cool cool.

Comment 6

[Dan Minor [:dminor]]

Thanks, created pull request: https://github.com/mozilla/Negatus/pull/8