895168 - Remove the remaining usages of LL_ macros from the tree

Status: RESOLVED FIXED

(Core :: General, defect)

Comment 1

[(no longer active)]

Attachment: Part 1: LL_I2L

Comment 2

[(no longer active)]

Attachment: Part 2: LL_ZERO

Comment 3

[(no longer active)]

Attachment: Part 3: LL_SHR

Comment 4

[(no longer active)]

Attachment: Part 4: LL_L2D

Comment 5

[(no longer active)]

Attachment: Part 5: LL_EQ

Comment 6

[(no longer active)]

Attachment: Part 6: LL_DIV

Comment 7

[Joshua Cranmer [:jcranmer]]

Comment on attachment 777440 [details] [diff] [review]
Part 4: LL_L2D

Review of attachment 777440 [details] [diff] [review]:
-----------------------------------------------------------------

::: docshell/shistory/src/nsSHistory.cpp
@@ +312,5 @@
>      bytes = INT64_MAX;
>  
>    uint64_t kbytes = bytes >> 10;
>  
> +  double kBytesD = kbytes;

Couldn't you just make this double kBytesD = (double)(bytes >> 10)?

Actually, on further glance, this method could be entirely rewritten without using a double conversion as well, using stuff from prbit.h, but I'd expect an actual docshell reviewer to own that conversion.

Comment 8

[Joshua Cranmer [:jcranmer]]

Comment on attachment 777437 [details] [diff] [review]
Part 1: LL_I2L

Review of attachment 777437 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/base/src/nsContentSink.cpp
@@ +1263,1 @@
>    diff = now - mLastNotificationTime;

You could combine these with the declarations, so it looks like:

int64_t interval = GetNotificationInterval();
int64_t diff = PR_Now() - mLastNotificationTime;

::: rdf/base/src/rdfutil.cpp
@@ +108,1 @@
>          t += temp;

Just say t += usec; ?

::: rdf/datasource/src/nsFileSystemDataSource.cpp
@@ +1114,3 @@
>      temp64 = lastModDate * thousand;
>  
>      mRDFService->GetDateLiteral(temp64, aResult);

mRDFService->GetDateLiteral(lastModDate * PR_MSEC_PER_SEC, aResult); ?

Comment 9

[(no longer active)]

(In reply to Joshua Cranmer [:jcranmer] from comment #7)
> Comment on attachment 777440 [details] [diff] [review]
> Part 4: LL_L2D
> 
> Review of attachment 777440 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: docshell/shistory/src/nsSHistory.cpp
> @@ +312,5 @@
> >      bytes = INT64_MAX;
> >  
> >    uint64_t kbytes = bytes >> 10;
> >  
> > +  double kBytesD = kbytes;
> 
> Couldn't you just make this double kBytesD = (double)(bytes >> 10)?

I guess so, I don't see the benefit of doing that though.

> Actually, on further glance, this method could be entirely rewritten without
> using a double conversion as well, using stuff from prbit.h, but I'd expect
> an actual docshell reviewer to own that conversion.

It should probably be done in another bug.  :-)

Comment 10

[(no longer active)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b580862e93f6
https://hg.mozilla.org/integration/mozilla-inbound/rev/f900f2d0d3f1
https://hg.mozilla.org/integration/mozilla-inbound/rev/efe5a0a1b181
https://hg.mozilla.org/integration/mozilla-inbound/rev/c7ea8253f816
https://hg.mozilla.org/integration/mozilla-inbound/rev/4a603adadb74
https://hg.mozilla.org/integration/mozilla-inbound/rev/d96476b2b850

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b580862e93f6
https://hg.mozilla.org/mozilla-central/rev/f900f2d0d3f1
https://hg.mozilla.org/mozilla-central/rev/efe5a0a1b181
https://hg.mozilla.org/mozilla-central/rev/c7ea8253f816
https://hg.mozilla.org/mozilla-central/rev/4a603adadb74
https://hg.mozilla.org/mozilla-central/rev/d96476b2b850