895174 - defect - not able to scroll list of recent history in snap view

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: General, defect, P2)

Description

[juan becerra [:juanb]]

Tested on 2013-07-17 using latest nightly.

While testing bug 886584 I noticed that you can't scroll vertically in the list of Recent History items.

Steps:
1. Open Firefox Metro (make sure you have several items in the recent history)
2. Put Firefox in snap view
3. Select Recent History (notice the item at the bottom might be cut off)
4. Try to scroll down the list

Expected: You can scroll down the list

Actual: You can't scroll down the list.

More often than not I find myself trying to scroll down the list, because that seems natural.

Comment 1

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v1

This patch will handle mouse wheel scroll in snapped. At least with bug 892046 touch is working too - but it will select a tile if touch start on a tile, we will need to adjust that.

Comment 2

[Marco Mucci [:MarcoM]]

Hey Rodrigo, can you provide a point estimate?

Comment 3

[Rodrigo Silveira [:rsilveira] [:rodms]]

p=1

Comment 4

[Matt Brubeck (:mbrubeck)]

Comment on attachment 778712 [details] [diff] [review]
Patch v1

Review of attachment 778712 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/metro/base/content/browser-ui.js
@@ +1200,5 @@
>        case "MozMousePixelScroll":
>          let startBox = document.getElementById("start-scrollbox");
>          let [, scrollInterface] = ScrollUtils.getScrollboxFromElement(startBox);
>  
> +        if (MetroUtils.snappedState == Ci.nsIWinMetroUtils.snapped) {

I think that MetroUtils.snappedState might go away soon with bug 892512 and bug 891056... but we can change this line if and when it does.

Comment 5

[Rodrigo Silveira [:rsilveira] [:rodms]]

Attachment: Patch v2

Actually Ci.nsIWinMetroUtils was throwing in -metrodesktop mode, switching to viewstate instead.

Comment 6

[Rodrigo Silveira [:rsilveira] [:rodms]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ac9174e8ed06

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ac9174e8ed06

Comment 8

[Manuela Muntean [Away]]

Win 8 64bit - latest Nightly - Mozilla/5.0 (Windows NT 6.2; Win64; x64; rv:25.0) Gecko/20130729 Firefox/25.0

Win 8 32bit - latest Nightly - Mozilla/5.0 (Windows NT 6.2; rv:25.0) Gecko/20130728 Firefox/25.0

With both builds, I can still reproduce the issue mentioned in the description. I can't scroll down the list. All I can see are 14 items in the Recent History list.

Comment 9

[Manuela Muntean [Away]]

Verified as fixed, for iteration #15, with both Win 8 32-bit and 64-bit, using latest Nightly (build ID: 20131006030201) and the STR from comment 0.