895187 - Some code and tests are still using the old contentPrefService from DownloadLastDir.jsm

Status: RESOLVED INVALID

(Toolkit :: Downloads API, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

the file getter uses getFile, that used the old contentPrefService.
http://mxr.mozilla.org/mozilla-central/search?string=downloadLastDir.file
Also getFileAsync invokes getFile in its first line, that will cause deprecation warnings.

Comment 1

[Drew Willcoxon :adw]

In DownloadLastDir.jsm, getFileAsync and the file getter are the only getFile callers, and neither hit its CPS1 path.  So the only concern is getFile callers outside the jsm, but none of the files that import the jsm [1] call it.

In other words, Felipe did a good job in bug 854299. :-)

[1] http://mxr.mozilla.org/mozilla-central/search?string=DownloadLastDir.jsm