Closed Bug 895187 Opened 7 years ago Closed 7 years ago

Some code and tests are still using the old contentPrefService from DownloadLastDir.jsm

Categories

(Toolkit :: Downloads API, defect)

defect
Not set

Tracking

()

RESOLVED INVALID

People

(Reporter: mak, Unassigned)

References

Details

the file getter uses getFile, that used the old contentPrefService.
http://mxr.mozilla.org/mozilla-central/search?string=downloadLastDir.file
Also getFileAsync invokes getFile in its first line, that will cause deprecation warnings.
In DownloadLastDir.jsm, getFileAsync and the file getter are the only getFile callers, and neither hit its CPS1 path.  So the only concern is getFile callers outside the jsm, but none of the files that import the jsm [1] call it.

In other words, Felipe did a good job in bug 854299. :-)

[1] http://mxr.mozilla.org/mozilla-central/search?string=DownloadLastDir.jsm
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.