Closed Bug 895203 Opened 7 years ago Closed 6 years ago

Disable overlay scrollbars in FF23

Categories

(Core :: Layout, defect)

23 Branch
All
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla23
Tracking Status
firefox23 + disabled
firefox24 + unaffected
firefox25 --- unaffected
relnote-firefox --- 24+

People

(Reporter: spohl, Assigned: spohl)

References

Details

(Whiteboard: [lion-scrollbars+])

Attachments

(1 file, 1 obsolete file)

Due to bug 894931 comment 14 we should disable overlay scrollbars in FF23.
Attached patch PatchSplinter Review
Attachment #777495 - Flags: review?(smichaud)
Status: NEW → ASSIGNED
Whiteboard: [lion-scrollbars+]
Comment on attachment 777495 [details] [diff] [review]
Patch

Too bad.  But yes, I agree.
Attachment #777495 - Flags: review?(smichaud) → review+
Unfortunately it has to be this way this late in the FF23 cycle.  Will nominate for tracking FF24 just to keep it on the radar in case the loose ends aren't wrapped up in time for that release as well, but hopefully we'll get it sorted in time. Let's get this onto Beta for today's build.
Comment on attachment 777495 [details] [diff] [review]
Patch

[Triage Comment]
Attachment #777495 - Flags: approval-mozilla-beta+
Whiteboard: [lion-scrollbars+] → [lion-scrollbars+][checkin-needed-beta]
https://hg.mozilla.org/releases/mozilla-beta/rev/6db59702f033
Whiteboard: [lion-scrollbars+][checkin-needed-beta] → [lion-scrollbars+]
Attached patch Additional debugging patch (obsolete) — Splinter Review
Here's my patch.  It adds information to the Breakpad crash reports' app notes field for crashes that are triggered by the original patch's calls to MOZ_CRASH.

It's conceivable that the information from TextInputHandlerBase::IsSecureEventInputEnabled()'s call to CrashReporter::AppendAppNotesToCrashReport() might also add information to other kinds of crash reports.  But I don't think that's a bad thing.

Masayuki, can you think of any other information that'd be useful for us to have in the app notes field of this bug's crash reports?
Attachment #778013 - Flags: review?(ted)
Attachment #778013 - Flags: review?(masayuki)
Attachment #778013 - Attachment is obsolete: true
Attachment #778013 - Flags: review?(ted)
Attachment #778013 - Flags: review?(masayuki)
Oops, wrong bug :-(
Per comment 3 I think this should stay in tracking-firefox24=?. Need-info=lsblakk to make sure.
Flags: needinfo?(lsblakk)
(In reply to Stephen Pohl [:spohl] from comment #8)
> Per comment 3 I think this should stay in tracking-firefox24=?.
> Need-info=lsblakk to make sure.

Hey :sphol, this is just a way of keeping this bug under release-mgmt radar.I understand we may not be disabling this in FX24 and hence your concern about tracking.But this really helpful to me in the end if there are any outstanding issues and we may have to disable again.
Flags: needinfo?(lsblakk)
That makes sense. Thanks for the clarification. :-)
Blocks: 866402, 877097, 894931
No longer depends on: 894931
Native scrollbars for OS X are still listed under the Firefox Beta notes:
http://www.mozilla.org/en-US/firefox/23.0/releasenotes/

I guess that this should be removed?
Bumped this note to FF24 notes, it will not be in the release notes (drafts being created shortly).
I am going to mark status for Firefox24 as unaffected here, given we are going to have scrollbars enabled in Fx24 and above.
Bhavana, would you like to keep this bug open? We might want to update the title and summary if that's the case. I believe we can close it otherwise. Thank you!
Flags: needinfo?(bbajaj)
(In reply to Stephen Pohl [:spohl] from comment #14)
> Bhavana, would you like to keep this bug open? We might want to update the
> title and summary if that's the case. I believe we can close it otherwise.
> Thank you!

:spohl, closing this makes sense. Marking it resolved.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: needinfo?(bbajaj)
Resolution: --- → FIXED
Target Milestone: --- → mozilla23
You need to log in before you can comment on or make changes to this bug.