895203 - Disable overlay scrollbars in FF23

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Stephen A Pohl [:spohl]]

Due to bug 894931 comment 14 we should disable overlay scrollbars in FF23.

Comment 1

[Stephen A Pohl [:spohl]]

Attachment: Patch

Comment 2

[Steven Michaud [:smichaud] (Retired)]

Comment on attachment 777495 [details] [diff] [review]
Patch

Too bad.  But yes, I agree.

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Unfortunately it has to be this way this late in the FF23 cycle.  Will nominate for tracking FF24 just to keep it on the radar in case the loose ends aren't wrapped up in time for that release as well, but hopefully we'll get it sorted in time. Let's get this onto Beta for today's build.

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 777495 [details] [diff] [review]
Patch

[Triage Comment]

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/6db59702f033

Comment 6

[Steven Michaud [:smichaud] (Retired)]

Attachment: Additional debugging patch

Here's my patch.  It adds information to the Breakpad crash reports' app notes field for crashes that are triggered by the original patch's calls to MOZ_CRASH.

It's conceivable that the information from TextInputHandlerBase::IsSecureEventInputEnabled()'s call to CrashReporter::AppendAppNotesToCrashReport() might also add information to other kinds of crash reports.  But I don't think that's a bad thing.

Masayuki, can you think of any other information that'd be useful for us to have in the app notes field of this bug's crash reports?

Comment 7

[Steven Michaud [:smichaud] (Retired)]

Oops, wrong bug :-(

Comment 8

[Stephen A Pohl [:spohl]]

Per comment 3 I think this should stay in tracking-firefox24=?. Need-info=lsblakk to make sure.

Comment 9

[bhavana bajaj [:bajaj]]

(In reply to Stephen Pohl [:spohl] from comment #8)
> Per comment 3 I think this should stay in tracking-firefox24=?.
> Need-info=lsblakk to make sure.

Hey :sphol, this is just a way of keeping this bug under release-mgmt radar.I understand we may not be disabling this in FX24 and hence your concern about tracking.But this really helpful to me in the end if there are any outstanding issues and we may have to disable again.

Comment 10

[Stephen A Pohl [:spohl]]

That makes sense. Thanks for the clarification. :-)

Comment 11

[José Jeria]

Native scrollbars for OS X are still listed under the Firefox Beta notes:
http://www.mozilla.org/en-US/firefox/23.0/releasenotes/

I guess that this should be removed?

Comment 12

[Lukas Blakk [:lsblakk] use ?needinfo]

Bumped this note to FF24 notes, it will not be in the release notes (drafts being created shortly).

Comment 13

[bhavana bajaj [:bajaj]]

I am going to mark status for Firefox24 as unaffected here, given we are going to have scrollbars enabled in Fx24 and above.

Comment 14

[Stephen A Pohl [:spohl]]

Bhavana, would you like to keep this bug open? We might want to update the title and summary if that's the case. I believe we can close it otherwise. Thank you!

Comment 15

[bhavana bajaj [:bajaj]]

(In reply to Stephen Pohl [:spohl] from comment #14)
> Bhavana, would you like to keep this bug open? We might want to update the
> title and summary if that's the case. I believe we can close it otherwise.
> Thank you!

:spohl, closing this makes sense. Marking it resolved.