Closed Bug 895274 Opened 6 years ago Closed 4 years ago

Change GUI MESSAGES to enum

Categories

(Core :: DOM: Events, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: kanru, Assigned: masayuki)

References

Details

Attachments

(271 files, 2 obsolete files)

278.44 KB, patch
smaug
: review+
Details | Diff | Splinter Review
87.03 KB, patch
smaug
: review+
Details | Diff | Splinter Review
243.49 KB, patch
smaug
: review+
Details | Diff | Splinter Review
241.15 KB, patch
Details | Diff | Splinter Review
8.50 KB, patch
smaug
: review+
Details | Diff | Splinter Review
35.52 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.45 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.70 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.56 KB, patch
smaug
: review+
Details | Diff | Splinter Review
63.95 KB, patch
smaug
: review+
Details | Diff | Splinter Review
40.31 KB, patch
smaug
: review+
Details | Diff | Splinter Review
41.89 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.99 KB, patch
smaug
: review+
Details | Diff | Splinter Review
6.12 KB, patch
smaug
: review+
Details | Diff | Splinter Review
6.67 KB, patch
smaug
: review+
Details | Diff | Splinter Review
6.57 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.73 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.20 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.88 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.07 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.11 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.04 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.32 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.24 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.12 KB, patch
smaug
: review+
Details | Diff | Splinter Review
54.64 KB, patch
smaug
: review+
Details | Diff | Splinter Review
69.74 KB, patch
smaug
: review+
Details | Diff | Splinter Review
68.62 KB, patch
smaug
: review+
Details | Diff | Splinter Review
21.23 KB, patch
smaug
: review+
Details | Diff | Splinter Review
25.29 KB, patch
smaug
: review+
Details | Diff | Splinter Review
20.49 KB, patch
smaug
: review+
Details | Diff | Splinter Review
31.05 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.57 KB, patch
smaug
: review+
Details | Diff | Splinter Review
16.70 KB, patch
smaug
: review+
Details | Diff | Splinter Review
18.14 KB, patch
smaug
: review+
Details | Diff | Splinter Review
6.78 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.72 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.27 KB, patch
smaug
: review+
Details | Diff | Splinter Review
8.17 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.86 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.76 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.58 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.64 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.35 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.20 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.82 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.67 KB, patch
smaug
: review+
Details | Diff | Splinter Review
7.34 KB, patch
smaug
: review+
Details | Diff | Splinter Review
7.59 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.72 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.50 KB, patch
smaug
: review+
Details | Diff | Splinter Review
18.93 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.37 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.22 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.00 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.94 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.21 KB, patch
smaug
: review+
Details | Diff | Splinter Review
6.79 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.59 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.19 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.79 KB, patch
smaug
: review+
Details | Diff | Splinter Review
12.68 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.87 KB, patch
smaug
: review+
Details | Diff | Splinter Review
13.28 KB, patch
smaug
: review+
Details | Diff | Splinter Review
10.09 KB, patch
smaug
: review+
Details | Diff | Splinter Review
6.09 KB, patch
smaug
: review+
Details | Diff | Splinter Review
8.10 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.82 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.58 KB, patch
smaug
: review+
Details | Diff | Splinter Review
23.37 KB, patch
smaug
: review+
Details | Diff | Splinter Review
23.96 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.58 KB, patch
smaug
: review+
Details | Diff | Splinter Review
8.55 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.87 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.52 KB, patch
smaug
: review+
Details | Diff | Splinter Review
19.34 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.78 KB, patch
smaug
: review+
Details | Diff | Splinter Review
19.21 KB, patch
smaug
: review+
Details | Diff | Splinter Review
9.10 KB, patch
smaug
: review+
Details | Diff | Splinter Review
7.75 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.40 KB, patch
smaug
: review+
Details | Diff | Splinter Review
17.99 KB, patch
smaug
: review+
Details | Diff | Splinter Review
13.15 KB, patch
smaug
: review+
Details | Diff | Splinter Review
16.11 KB, patch
smaug
: review+
Details | Diff | Splinter Review
8.06 KB, patch
smaug
: review+
Details | Diff | Splinter Review
9.89 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.05 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.30 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.63 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.93 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.68 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.61 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.54 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.23 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.04 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.27 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.68 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.28 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.01 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.71 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.89 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.94 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.63 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.70 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.53 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.04 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.05 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.18 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.52 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.38 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.78 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.80 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.59 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.20 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.77 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.60 KB, patch
smaug
: review+
Details | Diff | Splinter Review
12.22 KB, patch
smaug
: review+
Details | Diff | Splinter Review
10.53 KB, patch
smaug
: review+
Details | Diff | Splinter Review
16.53 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.27 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.71 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.90 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.90 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.89 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.87 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.92 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.91 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.99 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.10 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.16 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.03 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.02 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.02 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.00 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.93 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.92 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.94 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.87 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.83 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.84 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.86 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.30 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.51 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.16 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.62 KB, patch
smaug
: review+
Details | Diff | Splinter Review
15.71 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.63 KB, patch
smaug
: review+
Details | Diff | Splinter Review
10.66 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.98 KB, patch
smaug
: review+
Details | Diff | Splinter Review
12.42 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.90 KB, patch
smaug
: review+
Details | Diff | Splinter Review
9.32 KB, patch
smaug
: review+
Details | Diff | Splinter Review
29.94 KB, patch
smaug
: review+
Details | Diff | Splinter Review
22.02 KB, patch
smaug
: review+
Details | Diff | Splinter Review
17.07 KB, patch
smaug
: review+
Details | Diff | Splinter Review
13.87 KB, patch
smaug
: review+
Details | Diff | Splinter Review
7.12 KB, patch
smaug
: review+
Details | Diff | Splinter Review
13.23 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.37 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.50 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.96 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.98 KB, patch
smaug
: review+
Details | Diff | Splinter Review
8.44 KB, patch
smaug
: review+
Details | Diff | Splinter Review
8.61 KB, patch
smaug
: review+
Details | Diff | Splinter Review
7.48 KB, patch
smaug
: review+
Details | Diff | Splinter Review
7.83 KB, patch
smaug
: review+
Details | Diff | Splinter Review
6.69 KB, patch
smaug
: review+
Details | Diff | Splinter Review
8.01 KB, patch
smaug
: review+
Details | Diff | Splinter Review
8.41 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.63 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.54 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.85 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.85 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.89 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.38 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.05 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.81 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.51 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.97 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.19 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.45 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.84 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.81 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.49 KB, patch
smaug
: review+
Details | Diff | Splinter Review
21.92 KB, patch
smaug
: review+
Details | Diff | Splinter Review
9.08 KB, patch
smaug
: review+
Details | Diff | Splinter Review
7.53 KB, patch
smaug
: review+
Details | Diff | Splinter Review
19.63 KB, patch
smaug
: review+
Details | Diff | Splinter Review
15.12 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.53 KB, patch
smaug
: review+
Details | Diff | Splinter Review
19.98 KB, patch
smaug
: review+
Details | Diff | Splinter Review
9.99 KB, patch
smaug
: review+
Details | Diff | Splinter Review
7.86 KB, patch
smaug
: review+
Details | Diff | Splinter Review
31.40 KB, patch
smaug
: review+
Details | Diff | Splinter Review
16.46 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.54 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.65 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.56 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.97 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.89 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.95 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.87 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.93 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.99 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.69 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.01 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.79 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.72 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.56 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.37 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.47 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.93 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.93 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.90 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.80 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.64 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.27 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.61 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.16 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.02 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.30 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.96 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.85 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.70 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.60 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.48 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.68 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.78 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.52 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.52 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.15 KB, patch
smaug
: review+
Details | Diff | Splinter Review
995 bytes, patch
smaug
: review+
Details | Diff | Splinter Review
5.25 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.16 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.08 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.35 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.50 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.96 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.83 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.82 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.54 KB, patch
smaug
: review+
Details | Diff | Splinter Review
28.22 KB, patch
smaug
: review+
Details | Diff | Splinter Review
18.23 KB, patch
smaug
: review+
Details | Diff | Splinter Review
25.36 KB, patch
smaug
: review+
Details | Diff | Splinter Review
18.30 KB, patch
smaug
: review+
Details | Diff | Splinter Review
2.34 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.98 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.21 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.39 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.81 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.77 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.24 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.14 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.49 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.47 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.50 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.32 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.39 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.61 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.33 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.37 KB, patch
smaug
: review+
Details | Diff | Splinter Review
6.30 KB, patch
smaug
: review+
Details | Diff | Splinter Review
6.11 KB, patch
smaug
: review+
Details | Diff | Splinter Review
6.01 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.46 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.34 KB, patch
smaug
: review+
Details | Diff | Splinter Review
5.14 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.99 KB, patch
smaug
: review+
Details | Diff | Splinter Review
4.38 KB, patch
smaug
: review+
Details | Diff | Splinter Review
3.47 KB, patch
smaug
: review+
Details | Diff | Splinter Review
1.58 KB, patch
smaug
: review+
Details | Diff | Splinter Review
Is there any reason not to?
Enum should probably work. In theory that limits certain kinds of binary addons which might add
new types of event structs, but I haven't heard of any such addon.
Attached patch WIP patch (obsolete) — Splinter Review
Several places still use static_cast. One is the mId in EventNameMapping. I'm not sure how is it used. The others are in the interfaces defined in XPIDL, they accept uint32_t instead of the enum.

The name nsGUIMessage should be improved since in many places the variable are named aEventType but message.
Attachment #778361 - Flags: feedback?(bugs)
Comment on attachment 778361 [details] [diff] [review]
WIP patch

The name of the enum should not be nsGUIMessage.
Perhaps mozilla::EventMessageType or mozilla::EventMessage.

Couldn't you just change mapping's mId to be type of this new thing?
We really shouldn't be static_casting.

The naming should change. All thos NS_* event messages should
become eFooBar or eEventType_FooBar.

what is the sizeof a member variable which has type of this new enum?
nsEventListenerManager has an optimization and the sizeof mNoListenerForEvent
must not be more than 23 bits.
Attachment #778361 - Flags: feedback?(bugs) → feedback-
Many of the ns*Event types are not in the mozilla namespace. Should we fix this? Otherwise we have to use mozilla::EventMessageType in those declarations :(
Is there something wrong with using mozilla:: in those ns*Events?
Looks like that nobody works on this. Can I take this when I have time to fix this? Making event messages an enum help debug on Visual Studio.
(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #7)
> Looks like that nobody works on this. Can I take this when I have time to
> fix this? Making event messages an enum help debug on Visual Studio.

Please take it :)
I thought this as part of the Events refactoring effort but didn't find time to finish it.
Okay. Taking.
Assignee: nobody → masayuki
Status: NEW → ASSIGNED
Renaming WidgetEvent::message -> WidgetEvent::mMessage.

# I'd like to land patches separately because there will be a lot of patches to rename NS_* to eEventMessage_*.
Attachment #778361 - Attachment is obsolete: true
Attachment #8650912 - Flags: review?(bugs)
Attachment #8650912 - Flags: review?(bugs) → review+
I'll make the enum named enum, and rename each message name in following patches (next week).
Attachment #8651003 - Flags: review?(bugs)
And the patch breaks the 80 column per line rule, but please ignore that because each line will be modified when I rename it.
Comment on attachment 8651003 [details] [diff] [review]
part.2 Define event messages as anonymous enum with EventMessageList.h

The patch is a bit odd looking. For some reason first tons of stuff is removed, then the same thing copied and modified... I guess hg isn't clever enough to create better looking patch.

>+enum
>+{
>+
>+#define NS_EVENT_MESSAGE(aMessage, aValue) aMessage = aValue,
>+
>+#include "mozilla/EventMessageList.h"
>+
>+#undef NS_EVENT_MESSAGE
>+
>+  // For preventing bustage due to "," after the last item.
>+  eEventMessage_MaxValue
>+};

It would be nice if we could assert here or in ELM that aValue is always 
<= ((1 << 22) - 1) so that mNoListenerForEvent can handle the value.
But that can be done in a separate patch.
Attachment #8651003 - Flags: review?(bugs) → review+
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/bb91cf98a42b08db96677dd8bc3ebe5218945318
changeset:  bb91cf98a42b08db96677dd8bc3ebe5218945318
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 22 10:34:51 2015 +0900
description:
Bug 895274 part.1 Rename WidgetEvent::message to WidgetEvent::mMessage r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/756c006944ab770d06841c63a5d0f00616d3d41e
changeset:  756c006944ab770d06841c63a5d0f00616d3d41e
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 22 10:34:51 2015 +0900
description:
Bug 895274 part.2 Define event messages as anonymous enum with EventMessageList.h r=smaug
Whiteboard: [leave open]
It seems that we should use enum class instead of named enum. However, for using it, we need to replace all items of the enum. It's difficult to do it for now. Even if you like enum class better, we should use named enum for now. After we will add unique prefix like "eEventMessage_" at renaming each item, we can replace all items easier. So, if you like enum class better, please let me know. I'll do that after renaming all event messages.

Therefore, this patch just makes the enum of event messages named enum, "mozilla::EventMessage". And the type of this enum can be uint16_t rather than uint32_t.

This patch also checks the size of EventListenerManager's size at build time with static_assert(). For dosing that, I separated the integer members to EventListenerManagerBase.

And also this patch names all variables of EventMessage as "EventMesage", "Message" or "Msg".

Additionally, this patch adds a lot of "default: break;" to the switch statements since they are necessary for avoiding warnings.

I'll post this patch with -w.
Attachment #8652771 - Flags: review?(bugs)
FYI: I don't change nsBaseDragService::FireDragEventAtSource()'s argument since it's a scriptable interface method. We should make it non-scriptable or expose the concrete class later.
Now, we shouldn't call the event message as ID.
Attachment #8652775 - Flags: review?(bugs)
Attachment #8652775 - Flags: review?(bugs) → review+
Attachment #8652771 - Flags: review?(bugs) → review+
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/cd06f5f5641c3dfb7f07db878584d389fb4df1b7
changeset:  cd06f5f5641c3dfb7f07db878584d389fb4df1b7
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Aug 26 21:56:59 2015 +0900
description:
Bug 895274 part.3 Make the enum of event messages a named enum IGNORE IDL r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/5dc1087883b0c3685006722dbee0995c815ac4c1
changeset:  5dc1087883b0c3685006722dbee0995c815ac4c1
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Aug 26 21:56:59 2015 +0900
description:
Bug 895274 part.4 Clean up the macro names of EventNameList.h r=smaug
What's name do you like for each event message? I think normal event messages should be:

eEventMessage_KeyDown,
eEventMessage_MouseClick,
eEventMessage_MouseEnterWidget,
eEventMessage_MouseEnter,

On the other hand, the "start" and "end" messages should be "first" and "last" like the messages of Windows. start and end could be used by explaining operations, e.g., "drag start". So, I think they should be:

eEventMessage_KeyFirst,
eEventMessage_KeyLast,
eEventMessage_MouseFirst,
eEventMessage_MouseLast,

Do you have some better ideas?
Flags: needinfo?(bugs)
Do we need eEventMessage_* ?
Why not just eKeyDown etc?

first and last sound good.
Flags: needinfo?(bugs)
(In reply to Olli Pettay [:smaug] (high review load) from comment #30)
> Do we need eEventMessage_* ?
> Why not just eKeyDown etc?

Oh, does it OK? You don't think that we should make them enum class for stricter type check? If we should do that, common prefix helps me to replace with EventMessage::eKeyDown or something. (But if we don't need to do that, shorter name is better!)
Flags: needinfo?(bugs)
Well, does the longer name really help with type check? I think not. So I prefer shorter names, since those are still very clear.
Flags: needinfo?(bugs)
(In reply to Olli Pettay [:smaug] (high review load) from comment #32)
> Well, does the longer name really help with type check? I think not. So I
> prefer shorter names, since those are still very clear.

Okay, then, we should keep using named enum and shorter item names. I'll create some patches tomorrow.
FYI: I realized that we don't have any specific rule of naming enum items...
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style
(In reply to Olli Pettay [:smaug] (high review load) from comment #32)
> Well, does the longer name really help with type check?

Oops, I missed this point. If we use enum class, we have following merits:

We can reduce "e" prefix because each item name is valid only under the class name. So, e.g., EventMessage::Null won't conflict with anything.

enum class allows to use forward declaration. Therefore, header files don't need to include the defined header file only for a method which has EventMessage as a result type or an argument.

And enum class doesn't allow following code:

uint32_t foo = enumclass::bar; // error at build time

So, when we need to use to set to/get from integer, we need to cast explicitly.
Flags: needinfo?(bugs)
In other words, shorter names are used for us, but they may conflict with other enum items if we name some of them with too generic name.
ah, conflicts are possible, though with e-prefix hopefully unlikely.
Flags: needinfo?(bugs)
Hmm, I feel following names are odd:

NS_KEY_BEFORE_DOWN
NS_KEY_AFTER_DOWN 
NS_KEY_BEFORE_UP  
NS_KEY_AFTER_UP   

They are named as "mozbrowser(before|after)key(down|up). And the class name is InternalBeforeAfterKeyboardEvent. So, in the current idea, they should be e(Before|After)Key(Down|Up)...
I guess that if we change the enum to enum class, the longest name will be probably EventMessage::QuerySelectionAsTransferable. It's 8 characters longer than NS_QUERY_SELECTION_AS_TRANSFERABLE.
Hmm, I was hoping e-prefixed names, and without EventMessage:: everywhere.

And yes, those before/after names could be changed.
Okay, then, I'll keep yesterday's rules.
Er, *was* hoping?
I think that message indicates the meaning of message. Then, void is better than null.
Attachment #8653881 - Flags: review?(bugs)
Looks like that this is an event fired at closing window (not DOM window). Therefore, I don't think "XUL" is necessary keyword for this.
Attachment #8653884 - Flags: review?(bugs)
I think "window" resize event is better.
Attachment #8653893 - Flags: review?(bugs)
The name may be too generic...
Attachment #8653897 - Flags: review?(bugs)
I guess that somebody forgot to remove them.
Attachment #8653899 - Flags: review?(bugs)
I don't think this needs "Moz" keyword because this enum isn't exposed to the web.

And I'm not sure which is better of "HitTest" and "Hittest". According to the dictionary, a word, "hittest", doesn't exist. Therefore, I use "HitTest" in this patch.
Attachment #8654028 - Flags: review?(bugs)
This also shouldn't need "Moz" keyword.
Attachment #8654033 - Flags: review?(bugs)
Attachment #8653882 - Flags: review?(bugs) → review+
Attachment #8653883 - Flags: review?(bugs) → review+
Attachment #8653884 - Flags: review?(bugs) → review+
Attachment #8653888 - Flags: review?(bugs) → review+
Attachment #8653889 - Flags: review?(bugs) → review+
Attachment #8653890 - Flags: review?(bugs) → review+
Attachment #8653891 - Flags: review?(bugs) → review+
Comment on attachment 8653893 [details] [diff] [review]
part.16 Raneme NS_RESIZE to eWindowResize

I think this should be just eResize, since, as odd as it is, there is resize event dispatched also to media elements.
With that, r+
Attachment #8653893 - Flags: review?(bugs) → review+
Comment on attachment 8654033 [details] [diff] [review]
part.38 Raneme NS_MOUSE_MOZLONGTAP to eMouseLongTap

># HG changeset patch
># User Masayuki Nakano <masayuki@d-toybox.com>
># Parent  ba03386e5ff331d963e3c8de27ad24733078b28b
>Bug 895274 part.38 Raneme NS_MOUSE_MOZLONGTAP to eMouseLongTap r=
Rename
Attachment #8654033 - Flags: review?(bugs) → review+
Comment on attachment 8653894 [details] [diff] [review]
part.17 Raneme NS_SCROLL_EVENT to eScroll

># HG changeset patch
># User Masayuki Nakano <masayuki@d-toybox.com>
># Parent  6b624e1d45ede081c9de33b2af195d64a40df1a3
>Bug 895274 part.17 Raneme NS_SCROLL_EVENT to eScroll r=
Rename
Attachment #8653894 - Flags: review?(bugs) → review+
Comment on attachment 8653895 [details] [diff] [review]
part.18 Raneme NS_PLUGIN_ACTIVATE to ePluginActivate

># HG changeset patch
># User Masayuki Nakano <masayuki@d-toybox.com>
># Parent  c17930d465c38337eee420ef7b3afae2f69b00fc
>Bug 895274 part.18 Raneme NS_PLUGIN_ACTIVATE to ePluginActivate r=
Rename

I guess the same copy-past mistake in most of the commit messages ;)
So, not complaining that more, but please fix everywhere.
Attachment #8653895 - Flags: review?(bugs) → review+
Attachment #8653896 - Flags: review?(bugs) → review+
Attachment #8653897 - Flags: review?(bugs) → review+
Attachment #8653898 - Flags: review?(bugs) → review+
Comment on attachment 8653899 [details] [diff] [review]
part.22 Get rid of NS_MOZ_USER_* since nobody is using them

I would just remove the unused code and the comment about these.
With that, r+
Attachment #8653899 - Flags: review?(bugs) → review+
Attachment #8654025 - Flags: review?(bugs) → review+
Attachment #8654028 - Flags: review?(bugs) → review+
Attachment #8654029 - Flags: review?(bugs) → review+
Attachment #8654032 - Flags: review?(bugs) → review+
Attachment #8653900 - Flags: review?(bugs) → review+
Attachment #8654016 - Flags: review?(bugs) → review+
Attachment #8653881 - Flags: review?(bugs) → review+
Attachment #8654026 - Flags: review?(bugs) → review+
Attachment #8654027 - Flags: review?(bugs) → review+
Attachment #8654022 - Flags: review?(bugs) → review+
Attachment #8654023 - Flags: review?(bugs) → review+
Attachment #8653886 - Flags: review?(bugs) → review+
Attachment #8653885 - Flags: review?(bugs) → review+
Attachment #8653887 - Flags: review?(bugs) → review+
Comment on attachment 8654020 [details] [diff] [review]
part.28 Raneme NS_MOUSE_ENTER_WIDGET to eMouseEnterIntoWidget

>-  // Do not take account NS_MOUSE_ENTER_WIDGET/EXIT_WIDGET so that loading a page
>+  // Do not take account eMouseEnterIntoWidget/FromWidget so that loading a page
eMouseEnterIntoWidget/ExitFromWidget
Attachment #8654020 - Flags: review?(bugs) → review+
Attachment #8654021 - Flags: review?(bugs) → review+
Attachment #8654017 - Flags: review?(bugs) → review+
Attachment #8654018 - Flags: review?(bugs) → review+
Attachment #8654019 - Flags: review?(bugs) → review+
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/3de33e39e9ce795331196508ea5d36f2547a4bcb
changeset:  3de33e39e9ce795331196508ea5d36f2547a4bcb
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:26 2015 +0900
description:
Bug 895274 part.5 Rename NS_EVENT_NULL to eVoidEvent r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/8efaeb0052b0a101a70ce32f71f72c825591833e
changeset:  8efaeb0052b0a101a70ce32f71f72c825591833e
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:26 2015 +0900
description:
Bug 895274 part.6 Rename NS_EVENT_ALL to eAllEvents r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/2a4abd0f4d111e3bce761afc1d78d624664eea0c
changeset:  2a4abd0f4d111e3bce761afc1d78d624664eea0c
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:26 2015 +0900
description:
Bug 895274 part.7 Rename NS_WINDOW_START to eWindowEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/ae177f1853f552127ca9216d487bd014bbd2d6df
changeset:  ae177f1853f552127ca9216d487bd014bbd2d6df
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:26 2015 +0900
description:
Bug 895274 part.8 Rename NS_XUL_CLOSE to eWindowClose r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/6e12f5164cb9f833ec9cbb958131aadb530e164c
changeset:  6e12f5164cb9f833ec9cbb958131aadb530e164c
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:27 2015 +0900
description:
Bug 895274 part.9 Rename NS_KEY_PRESS to eKeyPress r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/83b87aa188ab9c744697b87eb0c47c8a13d5babc
changeset:  83b87aa188ab9c744697b87eb0c47c8a13d5babc
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:27 2015 +0900
description:
Bug 895274 part.10 Rename NS_KEY_UP to eKeyUp r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/4a2797061277a5a2a3ba878144431a3b2f50392f
changeset:  4a2797061277a5a2a3ba878144431a3b2f50392f
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:27 2015 +0900
description:
Bug 895274 part.11 Rename NS_KEY_DOWN to eKeyDown r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/d826b30611d8941e7ff487ea8acd51cade119ce9
changeset:  d826b30611d8941e7ff487ea8acd51cade119ce9
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:27 2015 +0900
description:
Bug 895274 part.12 Rename NS_KEY_BEFORE_DOWN to eBeforeKeyDown r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/57679af15e80758688d4bc0f54b662a084ce0904
changeset:  57679af15e80758688d4bc0f54b662a084ce0904
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:28 2015 +0900
description:
Bug 895274 part.13 Rename NS_KEY_AFTERE_DOWN to eAfterKeyDown r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/15282e20479563dc050ec3015610d880001baed2
changeset:  15282e20479563dc050ec3015610d880001baed2
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:28 2015 +0900
description:
Bug 895274 part.14 Rename NS_KEY_BEFORE_UP to eBeforeKeyUp r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/ef04b1227c95e42b29d6bf0626c021b24871d767
changeset:  ef04b1227c95e42b29d6bf0626c021b24871d767
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:28 2015 +0900
description:
Bug 895274 part.15 Rename NS_KEY_AFTER_UP to eAfterKeyUp r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/90da8b9aaf2e777b0ed64773f75e4cd45a9b3e8a
changeset:  90da8b9aaf2e777b0ed64773f75e4cd45a9b3e8a
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:28 2015 +0900
description:
Bug 895274 part.16 Rename NS_RESIZE to eResize r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/862ef097c279ec53b682694351d11e61083e08d0
changeset:  862ef097c279ec53b682694351d11e61083e08d0
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:28 2015 +0900
description:
Bug 895274 part.17 Rename NS_SCROLL_EVENT to eScroll r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/da3eb3291c32042466fcc13813d85b6b758413d7
changeset:  da3eb3291c32042466fcc13813d85b6b758413d7
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:28 2015 +0900
description:
Bug 895274 part.18 Rename NS_PLUGIN_ACTIVATE to ePluginActivate r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/4a2099a81968ec3a5f5a60a682170ceb28ae8dd4
changeset:  4a2099a81968ec3a5f5a60a682170ceb28ae8dd4
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:28 2015 +0900
description:
Bug 895274 part.19 Rename NS_PLUGIN_FOCUS to ePluginFocus r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/b409cf40a9f3b785427eaf3b387cc0b240f9c619
changeset:  b409cf40a9f3b785427eaf3b387cc0b240f9c619
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:29 2015 +0900
description:
Bug 895274 part.20 Rename NS_OFFLINE to eOffline r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/55b1a8515716fb1d6af18392e78261d7ce737c52
changeset:  55b1a8515716fb1d6af18392e78261d7ce737c52
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:29 2015 +0900
description:
Bug 895274 part.21 Rename NS_ONLINE to eOnline r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/746fe566eb9f29590d4ea733db34bef46d62ed1d
changeset:  746fe566eb9f29590d4ea733db34bef46d62ed1d
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:29 2015 +0900
description:
Bug 895274 part.22 Get rid of NS_MOZ_USER_* since nobody is using them r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/31d9af1df30fe60d55b3078776d197e311b73ff6
changeset:  31d9af1df30fe60d55b3078776d197e311b73ff6
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:29 2015 +0900
description:
Bug 895274 part.23 Rename NS_LANGUAGECHANGE to eLanguageChange r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/ef0b9c30a9e7581939b413908f2f9b7699ef9974
changeset:  ef0b9c30a9e7581939b413908f2f9b7699ef9974
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:29 2015 +0900
description:
Bug 895274 part.24 Rename NS_MOUSE_MESSAGE_START to eMouseEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/cd4d30cf8ecfb8789d0e69c2adcdfe4c1de7ac8f
changeset:  cd4d30cf8ecfb8789d0e69c2adcdfe4c1de7ac8f
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:29 2015 +0900
description:
Bug 895274 part.25 Rename NS_MOUSE_MOVE to eMouseMove r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/ae625cd90875c0f939e83fc58c9e40fb3b6fd75f
changeset:  ae625cd90875c0f939e83fc58c9e40fb3b6fd75f
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:30 2015 +0900
description:
Bug 895274 part.26 Rename NS_MOUSE_BUTTON_UP to eMouseUp r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/e637f3ff6f3e3add6aa4ac4b7325e3983504cef7
changeset:  e637f3ff6f3e3add6aa4ac4b7325e3983504cef7
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:30 2015 +0900
description:
Bug 895274 part.27 Rename NS_MOUSE_BUTTON_DOWN to eMouseDown r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/389f60113c0c037c562eb46f4dfa23feab74a20e
changeset:  389f60113c0c037c562eb46f4dfa23feab74a20e
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:31 2015 +0900
description:
Bug 895274 part.28 Rename NS_MOUSE_ENTER_WIDGET to eMouseEnterIntoWidget r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/6949e818c397150c21e14c3d05edb55a86255eba
changeset:  6949e818c397150c21e14c3d05edb55a86255eba
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:31 2015 +0900
description:
Bug 895274 part.29 Rename NS_MOUSE_EXIT_WIDGET to eMouseExitFromWidget r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/881d177f345734dee4b9b6a82da9663357dd9da1
changeset:  881d177f345734dee4b9b6a82da9663357dd9da1
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:31 2015 +0900
description:
Bug 895274 part.30 Rename NS_MOUSE_DOUBLECLICK to eMouseDoubleClick r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/c9288d4f5e63369b8f98319ac029a759519ace62
changeset:  c9288d4f5e63369b8f98319ac029a759519ace62
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:32 2015 +0900
description:
Bug 895274 part.31 Rename NS_MOUSE_CLICK to eMouseClick r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/ce720f26f58cd3a808c4af314582d21a39e77a70
changeset:  ce720f26f58cd3a808c4af314582d21a39e77a70
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:32 2015 +0900
description:
Bug 895274 part.32 Rename NS_MOUSE_ACTIVATE to eMouseActivate r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/b8fe1dac71aeb337dbdb084297b25071d03cf1a0
changeset:  b8fe1dac71aeb337dbdb084297b25071d03cf1a0
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:32 2015 +0900
description:
Bug 895274 part.33 Rename NS_MOUSE_OVER to eMouseOver r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/4bcb03faecc6d51c09068243a4b73240b7af80a2
changeset:  4bcb03faecc6d51c09068243a4b73240b7af80a2
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:32 2015 +0900
description:
Bug 895274 part.34 Rename NS_MOUSE_OUT to eMouseOut r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/0d03f7de34c57ba40ca9a60d41f8ce5ca3a47aae
changeset:  0d03f7de34c57ba40ca9a60d41f8ce5ca3a47aae
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:32 2015 +0900
description:
Bug 895274 part.35 Rename NS_MOUSE_MOZHITTEST to eMouseHitTest r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/691fe61c6289fa27fd6b41a3bc210680992a5718
changeset:  691fe61c6289fa27fd6b41a3bc210680992a5718
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:33 2015 +0900
description:
Bug 895274 part.36 Rename NS_MOUSEENTER to eMouseEnter r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/be7520290d1273ee2c9245f1347f97933d50b216
changeset:  be7520290d1273ee2c9245f1347f97933d50b216
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:33 2015 +0900
description:
Bug 895274 part.37 Rename NS_MOUSELEAVE to eMouseLeave r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/5899c44ed9ce7f54da590ce89d8922d34e4b7ac9
changeset:  5899c44ed9ce7f54da590ce89d8922d34e4b7ac9
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Sat Aug 29 08:58:33 2015 +0900
description:
Bug 895274 part.38 Rename NS_MOUSE_MOZLONGTAP to eMouseLongTap r=smaug
FYI: eResize conflicts with nsIPresShell::eResize. Therefore, I append scope to each eResize in nsPresShell.cpp.
https://hg.mozilla.org/integration/mozilla-inbound/diff/90da8b9aaf2e/layout/base/nsPresShell.cpp

If you think that this is bad, let me know.
Flags: needinfo?(bugs)
that is fine.
Flags: needinfo?(bugs)
https://hg.mozilla.org/mozilla-central/rev/3de33e39e9ce
https://hg.mozilla.org/mozilla-central/rev/8efaeb0052b0
https://hg.mozilla.org/mozilla-central/rev/2a4abd0f4d11
https://hg.mozilla.org/mozilla-central/rev/ae177f1853f5
https://hg.mozilla.org/mozilla-central/rev/6e12f5164cb9
https://hg.mozilla.org/mozilla-central/rev/83b87aa188ab
https://hg.mozilla.org/mozilla-central/rev/4a2797061277
https://hg.mozilla.org/mozilla-central/rev/d826b30611d8
https://hg.mozilla.org/mozilla-central/rev/57679af15e80
https://hg.mozilla.org/mozilla-central/rev/15282e204795
https://hg.mozilla.org/mozilla-central/rev/ef04b1227c95
https://hg.mozilla.org/mozilla-central/rev/90da8b9aaf2e
https://hg.mozilla.org/mozilla-central/rev/862ef097c279
https://hg.mozilla.org/mozilla-central/rev/da3eb3291c32
https://hg.mozilla.org/mozilla-central/rev/4a2099a81968
https://hg.mozilla.org/mozilla-central/rev/b409cf40a9f3
https://hg.mozilla.org/mozilla-central/rev/55b1a8515716
https://hg.mozilla.org/mozilla-central/rev/746fe566eb9f
https://hg.mozilla.org/mozilla-central/rev/31d9af1df30f
https://hg.mozilla.org/mozilla-central/rev/ef0b9c30a9e7
https://hg.mozilla.org/mozilla-central/rev/cd4d30cf8ecf
https://hg.mozilla.org/mozilla-central/rev/ae625cd90875
https://hg.mozilla.org/mozilla-central/rev/e637f3ff6f3e
https://hg.mozilla.org/mozilla-central/rev/389f60113c0c
https://hg.mozilla.org/mozilla-central/rev/6949e818c397
https://hg.mozilla.org/mozilla-central/rev/881d177f3457
https://hg.mozilla.org/mozilla-central/rev/c9288d4f5e63
https://hg.mozilla.org/mozilla-central/rev/ce720f26f58c
https://hg.mozilla.org/mozilla-central/rev/b8fe1dac71ae
https://hg.mozilla.org/mozilla-central/rev/4bcb03faecc6
https://hg.mozilla.org/mozilla-central/rev/0d03f7de34c5
https://hg.mozilla.org/mozilla-central/rev/691fe61c6289
https://hg.mozilla.org/mozilla-central/rev/be7520290d12
https://hg.mozilla.org/mozilla-central/rev/5899c44ed9ce
Hmm,

> 81 NS_EVENT_MESSAGE(NS_STREAM_EVENT_START, 1100)
> 82 NS_EVENT_MESSAGE(NS_LOAD,               NS_STREAM_EVENT_START)
> 83 NS_EVENT_MESSAGE(NS_PAGE_UNLOAD,        NS_STREAM_EVENT_START + 1)
> 84 NS_EVENT_MESSAGE(NS_HASHCHANGE,         NS_STREAM_EVENT_START + 2)
> 85 NS_EVENT_MESSAGE(NS_IMAGE_ABORT,        NS_STREAM_EVENT_START + 3)
> 86 NS_EVENT_MESSAGE(NS_LOAD_ERROR,         NS_STREAM_EVENT_START + 4)
> 87 NS_EVENT_MESSAGE(NS_POPSTATE,           NS_STREAM_EVENT_START + 5)
> 88 NS_EVENT_MESSAGE(NS_BEFORE_PAGE_UNLOAD, NS_STREAM_EVENT_START + 6)
> 89 NS_EVENT_MESSAGE(NS_PAGE_RESTORE,       NS_STREAM_EVENT_START + 7)
> 90 NS_EVENT_MESSAGE(NS_READYSTATECHANGE,   NS_STREAM_EVENT_START + 8)

Do you think "Page" is necessary for unload event?

eLoad, eUnload feel enough to me. I'm not sure NS_PAGE_RESTORE, though...
Flags: needinfo?(bugs)
Nice :/


Load certainly doesn't need 'Page', and I think unload could without it too.
Flags: needinfo?(bugs)
Comment on attachment 8654844 [details] [diff] [review]
part.39 Rename NS_POINTER_EVENT_START to ePointerEventFirst

>+NS_EVENT_MESSAGE(ePointerEventFirst,    4400)
I wonder if 4400 should be aligned with the ePointerEventFirst. But perhaps some other patch changes this stuff
Attachment #8654844 - Flags: review?(bugs) → review+
Attachment #8654845 - Flags: review?(bugs) → review+
Attachment #8654847 - Flags: review?(bugs) → review+
Attachment #8654850 - Flags: review?(bugs) → review+
Attachment #8654851 - Flags: review?(bugs) → review+
Attachment #8654852 - Flags: review?(bugs) → review+
Attachment #8654853 - Flags: review?(bugs) → review+
Attachment #8654854 - Flags: review?(bugs) → review+
Attachment #8654856 - Flags: review?(bugs) → review+
Attachment #8654857 - Flags: review?(bugs) → review+
Attachment #8654858 - Flags: review?(bugs) → review+
Attachment #8654859 - Flags: review?(bugs) → review+
Attachment #8654860 - Flags: review?(bugs) → review+
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/b3a11cf986072c52d4b00532febe1ec53fa4f22a
changeset:  b3a11cf986072c52d4b00532febe1ec53fa4f22a
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Tue Sep 01 00:20:05 2015 +0900
description:
Bug 895274 part.39 Rename NS_POINTER_EVENT_START to ePointerEventFirst and add ePointerEventLast r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/04ed6773489c51298603209fe7f3e0ff0c02368a
changeset:  04ed6773489c51298603209fe7f3e0ff0c02368a
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Tue Sep 01 00:20:05 2015 +0900
description:
Bug 895274 part.40 Rename NS_POINTER_LOST_CAPTURE to ePointerLostCapture r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/6fe4281b2f0bc35740e2399f01646b52ab3cd8f0
changeset:  6fe4281b2f0bc35740e2399f01646b52ab3cd8f0
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Tue Sep 01 00:20:05 2015 +0900
description:
Bug 895274 part.41 Rename NS_POINTER_GOT_CAPTURE to ePointerGotCapture r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/c0b1bff50484386fa3bcbb70e79f67f2748c69ee
changeset:  c0b1bff50484386fa3bcbb70e79f67f2748c69ee
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Tue Sep 01 00:20:05 2015 +0900
description:
Bug 895274 part.42 Rename NS_POINTER_CANCEL to ePointerCancel r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/81616c5e77d7893153138a33652694099827bc50
changeset:  81616c5e77d7893153138a33652694099827bc50
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Tue Sep 01 00:20:05 2015 +0900
description:
Bug 895274 part.43 Rename NS_POINTER_LEAVE to ePointerLeave r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/64973fea75722564451f73a524fc335d0f27d76e
changeset:  64973fea75722564451f73a524fc335d0f27d76e
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Tue Sep 01 00:20:05 2015 +0900
description:
Bug 895274 part.44 Rename NS_POINTER_ENTER to ePointerEnter r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/628fdef4a033fed83cd1bac4b1f1b6ea5b4017e1
changeset:  628fdef4a033fed83cd1bac4b1f1b6ea5b4017e1
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Tue Sep 01 00:20:05 2015 +0900
description:
Bug 895274 part.45 Rename NS_POINTER_OUT to ePointerOut r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/d7d3fe895b8dfb9176f560391b4934348fc1b630
changeset:  d7d3fe895b8dfb9176f560391b4934348fc1b630
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Tue Sep 01 00:20:05 2015 +0900
description:
Bug 895274 part.46 Rename NS_POINTER_OVER to ePointerOver r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/c66504b2b0b24846d0f9bd081ec6e36782237d7f
changeset:  c66504b2b0b24846d0f9bd081ec6e36782237d7f
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Tue Sep 01 00:20:06 2015 +0900
description:
Bug 895274 part.47 Rename NS_POINTER_DOWN to ePointerDown r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/b8957e880eba52047056b3e4d5f611fad08180e7
changeset:  b8957e880eba52047056b3e4d5f611fad08180e7
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Tue Sep 01 00:20:06 2015 +0900
description:
Bug 895274 part.48 Rename NS_POINTER_UP to ePointerUp r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/9a728655edf95ccfcd0c600eb381433bf620af9f
changeset:  9a728655edf95ccfcd0c600eb381433bf620af9f
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Tue Sep 01 00:20:06 2015 +0900
description:
Bug 895274 part.49 Rename NS_POINTER_MOVE to ePointerMove r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/44c0607b46208775584259b72146408b3ddc42ae
changeset:  44c0607b46208775584259b72146408b3ddc42ae
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Tue Sep 01 00:20:06 2015 +0900
description:
Bug 895274 part.50 Rename NS_CONTEXTMENU_MESSAGE_START to eContextMenuFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/3c16bb077e3173848498c17edb876ff2e8990e22
changeset:  3c16bb077e3173848498c17edb876ff2e8990e22
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Tue Sep 01 00:20:06 2015 +0900
description:
Bug 895274 part.51 Rename NS_CONTEXTMENU to eContextMenu r=smaug
(In reply to Olli Pettay [:smaug] (high review load, please consider other reviewers) from comment #109)
> Comment on attachment 8654844 [details] [diff] [review]
> part.39 Rename NS_POINTER_EVENT_START to ePointerEventFirst
> 
> >+NS_EVENT_MESSAGE(ePointerEventFirst,    4400)
> I wonder if 4400 should be aligned with the ePointerEventFirst. But perhaps
> some other patch changes this stuff

FYI: I'm checking every use case of the event message values. So, when we fix this bug, I think that we can remove specifying value to every event message.
Like this:

NS_EVENT_MESSAGE(ePointerMove)
NS_EVENT_MESSAGE(ePointerUp)
NS_EVENT_MESSAGE(ePointerDown)
NS_EVENT_MESSAGE(ePointerOver)
NS_EVENT_MESSAGE(ePointerOut)
NS_EVENT_MESSAGE(ePointerEnter)
NS_EVENT_MESSAGE(ePointerLeave)
NS_EVENT_MESSAGE(ePointerCancel)
NS_EVENT_MESSAGE(ePointerGotCapture)
NS_EVENT_MESSAGE(ePointerLostCapture)
NS_SPECIAL_EVENT_MESSAGE(ePointerEventLast,     ePointerMove)
NS_SPECIAL_EVENT_MESSAGE(ePointerEventLast,     ePointerLostCapture)
According to the DOM event name, this could be eError, but it's too generic. I prefer eLoadError instead.
Attachment #8654926 - Flags: review?(bugs)
According to the DOM event name, this could be eAbort. But it's too generic. Therefore, I prefer eImageAbort instead.
Attachment #8654928 - Flags: review?(bugs)
Could be eSubmit. But "Form" keyword is clearer. Therefore, I don't remove it from this event message. But it could be...
Attachment #8654935 - Flags: review?(bugs)
Same. And also "Selected" isn't good for consistency with other event message names. I like "Select" better.
Attachment #8654939 - Flags: review?(bugs)
Same, but eInvalid must be too generic.
Attachment #8654941 - Flags: review?(bugs)
I think that eFocus is enough rather than eFocusContent.
Attachment #8655393 - Flags: review?(bugs)
"UI" isn't clear to me. NS_UI_* define the event messages of legacy event which indicates an element state. So, I think that "Legacy" helps developers to understand what the events and how should they tread.

Therefore, I name this to eLegacyUIEventFirst. And each of the messages is:

* NS_UI_ACTIVATE -> eLegacyDOMActivate
* NS_UI_FOCUSIN ->  eLegacyDOMFocusIn
* NS_UI_FOCUSOUT -> eLegacyDOMFocusOut

So, the new names indicate which legacy DOM event explicitly.
Attachment #8655396 - Flags: review?(bugs)
I think that using DOM event name is better. So, I name this as eDragLeave, not eDragDropLeave.
Attachment #8655402 - Flags: review?(bugs)
Similar to NS_UI_*, let's use "Legacy" keyword for non-standard dnd events. This name must help developers what's different from the similar event, eDrop.
Attachment #8655413 - Flags: review?(bugs)
Same. This is a legacy event of eDragStart.
Attachment #8655414 - Flags: review?(bugs)
Attachment #8654917 - Flags: review?(bugs) → review+
Attachment #8654919 - Flags: review?(bugs) → review+
Attachment #8654921 - Flags: review?(bugs) → review+
Attachment #8654923 - Flags: review?(bugs) → review+
Attachment #8654925 - Flags: review?(bugs) → review+
Attachment #8654926 - Flags: review?(bugs) → review+
Attachment #8654928 - Flags: review?(bugs) → review+
Attachment #8654929 - Flags: review?(bugs) → review+
Attachment #8654930 - Flags: review?(bugs) → review+
Attachment #8654932 - Flags: review?(bugs) → review+
Attachment #8654934 - Flags: review?(bugs) → review+
Attachment #8654935 - Flags: review?(bugs) → review+
Attachment #8654936 - Flags: review?(bugs) → review+
Attachment #8654937 - Flags: review?(bugs) → review+
Attachment #8654939 - Flags: review?(bugs) → review+
Attachment #8654941 - Flags: review?(bugs) → review+
Attachment #8655392 - Flags: review?(bugs) → review+
Attachment #8655393 - Flags: review?(bugs) → review+
Attachment #8655395 - Flags: review?(bugs) → review+
Comment on attachment 8655396 [details] [diff] [review]
part.71 Rename NS_UI_EVENT_START to eLegacyUIEventFirst

Ah, I like this naming.
Attachment #8655396 - Flags: review?(bugs) → review+
Attachment #8655397 - Flags: review?(bugs) → review+
Attachment #8655398 - Flags: review?(bugs) → review+
Attachment #8655400 - Flags: review?(bugs) → review+
Attachment #8655401 - Flags: review?(bugs) → review+
Attachment #8655402 - Flags: review?(bugs) → review+
Attachment #8655403 - Flags: review?(bugs) → review+
Attachment #8655404 - Flags: review?(bugs) → review+
Attachment #8655405 - Flags: review?(bugs) → review+
Attachment #8655407 - Flags: review?(bugs) → review+
Attachment #8655409 - Flags: review?(bugs) → review+
Attachment #8655410 - Flags: review?(bugs) → review+
Attachment #8655412 - Flags: review?(bugs) → review+
Attachment #8655413 - Flags: review?(bugs) → review+
Attachment #8655414 - Flags: review?(bugs) → review+
url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/196b7de875ef521f938904e0dceb62a6ba2fd897
changeset:  196b7de875ef521f938904e0dceb62a6ba2fd897
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:07:58 2015 +0900
description:
Bug 895274 part.52 Get rid of NS_PAGE_RESTORE due to unused r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/6966f9d6f70bfeaebdd4f08afb1f725a17949787
changeset:  6966f9d6f70bfeaebdd4f08afb1f725a17949787
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:07:58 2015 +0900
description:
Bug 895274 part.53 Rename NS_STREAM_EVENT_START to eStreamEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/305e40d37ee560305b95ba5e95a73d5b0b30a28b
changeset:  305e40d37ee560305b95ba5e95a73d5b0b30a28b
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:07:58 2015 +0900
description:
Bug 895274 part.54 Rename NS_READYSTATECHANGE to eReadyStateChange r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/3bfcdb7bfe8d137cd7cba3dcdbb98d46328dcaca
changeset:  3bfcdb7bfe8d137cd7cba3dcdbb98d46328dcaca
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:07:59 2015 +0900
description:
Bug 895274 part.55 Rename NS_BEFORE_PAGE_UNLOAD to eBeforeUnload r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/44d54a262d71f16b578bdee228b7854b77a75b11
changeset:  44d54a262d71f16b578bdee228b7854b77a75b11
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:07:59 2015 +0900
description:
Bug 895274 part.56 Rename NS_POPSTATE to ePopState r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/227bdcb2316da1bb496246ca4f8034d8e4d078e3
changeset:  227bdcb2316da1bb496246ca4f8034d8e4d078e3
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:07:59 2015 +0900
description:
Bug 895274 part.57 Rename NS_LOAD_ERROR to eLoadError r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/347f30d4b57b21604f9df04fe09f09c45f66e657
changeset:  347f30d4b57b21604f9df04fe09f09c45f66e657
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:07:59 2015 +0900
description:
Bug 895274 part.58 Rename NS_IMAGE_ABORT to eImageAbort r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/0a0c6edeaeab51cf022b2d023f52c53fda196892
changeset:  0a0c6edeaeab51cf022b2d023f52c53fda196892
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:07:59 2015 +0900
description:
Bug 895274 part.59 Rename NS_HASHCHANGE to eHashChange r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/280ce6c3a4eeb770861c5a8a7c6721a3d384e65f
changeset:  280ce6c3a4eeb770861c5a8a7c6721a3d384e65f
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:07:59 2015 +0900
description:
Bug 895274 part.60 Rename NS_PAGE_UNLOAD to eUnload r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/c3d179d89c2c14b77643b7911fd5600c8af61f41
changeset:  c3d179d89c2c14b77643b7911fd5600c8af61f41
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:07:59 2015 +0900
description:
Bug 895274 part.61 Rename NS_LOAD to eLoad r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/9afdaf8b032a01c5b9fc437dbde4db57f767bc34
changeset:  9afdaf8b032a01c5b9fc437dbde4db57f767bc34
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:07:59 2015 +0900
description:
Bug 895274 part.62 Rename NS_FORM_EVENT_START to eFormEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/5443202e95e681f179b5b0a86cc4aa00164452b1
changeset:  5443202e95e681f179b5b0a86cc4aa00164452b1
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:00 2015 +0900
description:
Bug 895274 part.63 Rename NS_FORM_SUBMIT to eFormSubmit r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/58ea57abc0e9736acc0e3c7fbf1a65d92b502edc
changeset:  58ea57abc0e9736acc0e3c7fbf1a65d92b502edc
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:00 2015 +0900
description:
Bug 895274 part.64 Rename NS_FORM_RESET to eFormReset r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/a4db59edaa15f10f93bbb372cf53224c1ecc6482
changeset:  a4db59edaa15f10f93bbb372cf53224c1ecc6482
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:00 2015 +0900
description:
Bug 895274 part.65 Rename NS_FORM_CHANGE to eFormChange r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/932f80808057e731b911c0a8cfd218541a03d324
changeset:  932f80808057e731b911c0a8cfd218541a03d324
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:00 2015 +0900
description:
Bug 895274 part.66 Rename NS_FORM_SELECTED to eFormSelect r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/5653edb7c0f71dfd7444ba15e5f09e4182076f9b
changeset:  5653edb7c0f71dfd7444ba15e5f09e4182076f9b
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:00 2015 +0900
description:
Bug 895274 part.67 Rename NS_FORM_INVALID to eFormInvalid r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/5f67d5de5adb1a9b31a945cbbe91db3e620a4e57
changeset:  5f67d5de5adb1a9b31a945cbbe91db3e620a4e57
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:00 2015 +0900
description:
Bug 895274 part.68 Rename NS_FOCUS_EVENT_START to eFocusEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/e9bb1fc9977aa1fb3df612fcd4954172bad8de41
changeset:  e9bb1fc9977aa1fb3df612fcd4954172bad8de41
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:00 2015 +0900
description:
Bug 895274 part.69 Rename NS_FOCUS_CONTENT to eFocus r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/89d8ce319bd0bff6a553ec382a0669abf79de8d9
changeset:  89d8ce319bd0bff6a553ec382a0669abf79de8d9
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:00 2015 +0900
description:
Bug 895274 part.70 Rename NS_BLUR_CONTENT to eBlur r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/4682f4db642d462d74c8afa0102373e191f47edd
changeset:  4682f4db642d462d74c8afa0102373e191f47edd
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:01 2015 +0900
description:
Bug 895274 part.71 Rename NS_UI_EVENT_START to eLegacyUIEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/cf4c3be6ea5689cf5cedf253b1bfd27290d2ba25
changeset:  cf4c3be6ea5689cf5cedf253b1bfd27290d2ba25
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:01 2015 +0900
description:
Bug 895274 part.72 Rename NS_UI_ACTIVATE to eLegacyDOMActivate r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/deb5c3173e6e250766cb28957dd919fd5e38dc3e
changeset:  deb5c3173e6e250766cb28957dd919fd5e38dc3e
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:01 2015 +0900
description:
Bug 895274 part.73 Rename NS_UI_FOCUSIN to eLegacyDOMFocusIn r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/be746a34f096038983737ea2f143bfc7daec1004
changeset:  be746a34f096038983737ea2f143bfc7daec1004
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:01 2015 +0900
description:
Bug 895274 part.74 Rename NS_UI_FOCUSOUT to eLegacyDOMFocusOut r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/38c50d1c496bcb1d3436ea34cfe7863a8e0004de
changeset:  38c50d1c496bcb1d3436ea34cfe7863a8e0004de
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:01 2015 +0900
description:
Bug 895274 part.75 Rename NS_DRAGDROP_EVENT_START to eDragDropEventFirst, define eDragDropEventLast and correct the type and name of event message in DataTransfer r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/76a8bd3c6ea34a2eccadf4a47d0eb6818e66aecc
changeset:  76a8bd3c6ea34a2eccadf4a47d0eb6818e66aecc
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:01 2015 +0900
description:
Bug 895274 part.76 Rename NS_DRAGDROP_LEAVE to eDragLeave r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/df96cb04b9dd41d97951a8cc6e68d7c332616c08
changeset:  df96cb04b9dd41d97951a8cc6e68d7c332616c08
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:01 2015 +0900
description:
Bug 895274 part.77 Rename NS_DRAGDROP_DROP to eDrop r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/2eb6dbb32ddc41d166123699cbc750d704cd120a
changeset:  2eb6dbb32ddc41d166123699cbc750d704cd120a
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:01 2015 +0900
description:
Bug 895274 part.78 Rename NS_DRAGDROP_START to eDragStart r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/99bfe44528f6dc6041a997710cdc49a5a53f13e7
changeset:  99bfe44528f6dc6041a997710cdc49a5a53f13e7
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:02 2015 +0900
description:
Bug 895274 part.79 Rename NS_DRAGDROP_END to eDragEnd r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/42d861b4a03568fa6bf3d4c45f6f089d04453f31
changeset:  42d861b4a03568fa6bf3d4c45f6f089d04453f31
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:02 2015 +0900
description:
Bug 895274 part.80 Rename NS_DRAGDROP_DRAG to eDrag r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/4f79fccb269836a8053a036c8a0734d618d92b41
changeset:  4f79fccb269836a8053a036c8a0734d618d92b41
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:02 2015 +0900
description:
Bug 895274 part.81 Rename NS_DRAGDROP_OVER to eDragOver r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/cad395df60d302e74ba82c7f46626180eb885d13
changeset:  cad395df60d302e74ba82c7f46626180eb885d13
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:02 2015 +0900
description:
Bug 895274 part.82 Rename NS_DRAGDROP_ENTER to eDragEnter r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/aaffbbb943e446e995c9f08c363bae24e0712a28
changeset:  aaffbbb943e446e995c9f08c363bae24e0712a28
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:02 2015 +0900
description:
Bug 895274 part.83 Rename NS_DRAGDROP_EXIT to eDragExit r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/3a188aef7f84eac26f6401ee337dd7c4d37b3f90
changeset:  3a188aef7f84eac26f6401ee337dd7c4d37b3f90
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:03 2015 +0900
description:
Bug 895274 part.84 Rename NS_DRAGDROP_DRAGDROP to eLegacyDragDrop r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/bd0d6c41b33ec106579e405ee660e150c0cac513
changeset:  bd0d6c41b33ec106579e405ee660e150c0cac513
user:       Masayuki Nakano <masayuki@d-toybox.com>
date:       Wed Sep 02 15:08:03 2015 +0900
description:
Bug 895274 part.85 Rename NS_DRAGDROP_GESTURE to eLegacyDragGesture r=smaug
https://hg.mozilla.org/mozilla-central/rev/196b7de875ef
https://hg.mozilla.org/mozilla-central/rev/6966f9d6f70b
https://hg.mozilla.org/mozilla-central/rev/305e40d37ee5
https://hg.mozilla.org/mozilla-central/rev/3bfcdb7bfe8d
https://hg.mozilla.org/mozilla-central/rev/44d54a262d71
https://hg.mozilla.org/mozilla-central/rev/227bdcb2316d
https://hg.mozilla.org/mozilla-central/rev/347f30d4b57b
https://hg.mozilla.org/mozilla-central/rev/0a0c6edeaeab
https://hg.mozilla.org/mozilla-central/rev/280ce6c3a4ee
https://hg.mozilla.org/mozilla-central/rev/c3d179d89c2c
https://hg.mozilla.org/mozilla-central/rev/9afdaf8b032a
https://hg.mozilla.org/mozilla-central/rev/5443202e95e6
https://hg.mozilla.org/mozilla-central/rev/58ea57abc0e9
https://hg.mozilla.org/mozilla-central/rev/a4db59edaa15
https://hg.mozilla.org/mozilla-central/rev/932f80808057
https://hg.mozilla.org/mozilla-central/rev/5653edb7c0f7
https://hg.mozilla.org/mozilla-central/rev/5f67d5de5adb
https://hg.mozilla.org/mozilla-central/rev/e9bb1fc9977a
https://hg.mozilla.org/mozilla-central/rev/89d8ce319bd0
https://hg.mozilla.org/mozilla-central/rev/4682f4db642d
https://hg.mozilla.org/mozilla-central/rev/cf4c3be6ea56
https://hg.mozilla.org/mozilla-central/rev/deb5c3173e6e
https://hg.mozilla.org/mozilla-central/rev/be746a34f096
https://hg.mozilla.org/mozilla-central/rev/38c50d1c496b
https://hg.mozilla.org/mozilla-central/rev/76a8bd3c6ea3
https://hg.mozilla.org/mozilla-central/rev/df96cb04b9dd
https://hg.mozilla.org/mozilla-central/rev/2eb6dbb32ddc
https://hg.mozilla.org/mozilla-central/rev/99bfe44528f6
https://hg.mozilla.org/mozilla-central/rev/42d861b4a035
https://hg.mozilla.org/mozilla-central/rev/4f79fccb2698
https://hg.mozilla.org/mozilla-central/rev/cad395df60d3
https://hg.mozilla.org/mozilla-central/rev/aaffbbb943e4
https://hg.mozilla.org/mozilla-central/rev/3a188aef7f84
https://hg.mozilla.org/mozilla-central/rev/bd0d6c41b33e
When you have much time, could you check the patches? I don't like to ask review for the others since the new names should be decided by same person.
Flags: needinfo?(bugs)