895274 - Change GUI MESSAGES to enum

Status: RESOLVED FIXED

(Core :: DOM: Events, defect)

Description

[Kan-Ru Chen [:kanru] (UTC+9)]

Is there any reason not to?

Comment 1

[Kan-Ru Chen [:kanru] (UTC+9)]

http://dxr.mozilla.org/mozilla-central/source/widget/nsGUIEvent.h#l113
http://dxr.mozilla.org/mozilla-central/source/widget/nsGUIEvent.h#l677

Currently defined as a uint32_t

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Enum should probably work. In theory that limits certain kinds of binary addons which might add
new types of event structs, but I haven't heard of any such addon.

Comment 3

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: WIP patch

Several places still use static_cast. One is the mId in EventNameMapping. I'm not sure how is it used. The others are in the interfaces defined in XPIDL, they accept uint32_t instead of the enum.

The name nsGUIMessage should be improved since in many places the variable are named aEventType but message.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 778361 [details] [diff] [review]
WIP patch

The name of the enum should not be nsGUIMessage.
Perhaps mozilla::EventMessageType or mozilla::EventMessage.

Couldn't you just change mapping's mId to be type of this new thing?
We really shouldn't be static_casting.

The naming should change. All thos NS_* event messages should
become eFooBar or eEventType_FooBar.

what is the sizeof a member variable which has type of this new enum?
nsEventListenerManager has an optimization and the sizeof mNoListenerForEvent
must not be more than 23 bits.

Comment 5

[Kan-Ru Chen [:kanru] (UTC+9)]

Many of the ns*Event types are not in the mozilla namespace. Should we fix this? Otherwise we have to use mozilla::EventMessageType in those declarations :(

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Is there something wrong with using mozilla:: in those ns*Events?

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Looks like that nobody works on this. Can I take this when I have time to fix this? Making event messages an enum help debug on Visual Studio.

Comment 8

[Kan-Ru Chen [:kanru] (UTC+9)]

(In reply to Masayuki Nakano (:masayuki) (Mozilla Japan) from comment #7)
> Looks like that nobody works on this. Can I take this when I have time to
> fix this? Making event messages an enum help debug on Visual Studio.

Please take it :)
I thought this as part of the Events refactoring effort but didn't find time to finish it.

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c943442b2959

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Okay. Taking.

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.1 Rename WidgetEvent::message to WidgetEvent::mMessage

Renaming WidgetEvent::message -> WidgetEvent::mMessage.

# I'd like to land patches separately because there will be a lot of patches to rename NS_* to eEventMessage_*.

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=81dfea1bb081

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.2 Define event messages as anonymous enum with EventMessageList.h

I'll make the enum named enum, and rename each message name in following patches (next week).

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

And the patch breaks the 80 column per line rule, but please ignore that because each line will be modified when I rename it.

Comment 15

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8651003 [details] [diff] [review]
part.2 Define event messages as anonymous enum with EventMessageList.h

The patch is a bit odd looking. For some reason first tons of stuff is removed, then the same thing copied and modified... I guess hg isn't clever enough to create better looking patch.

>+enum
>+{
>+
>+#define NS_EVENT_MESSAGE(aMessage, aValue) aMessage = aValue,
>+
>+#include "mozilla/EventMessageList.h"
>+
>+#undef NS_EVENT_MESSAGE
>+
>+  // For preventing bustage due to "," after the last item.
>+  eEventMessage_MaxValue
>+};

It would be nice if we could assert here or in ELM that aValue is always 
<= ((1 << 22) - 1) so that mNoListenerForEvent can handle the value.
But that can be done in a separate patch.

Comment 16

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/bb91cf98a42b08db96677dd8bc3ebe5218945318
changeset:  bb91cf98a42b08db96677dd8bc3ebe5218945318
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 22 10:34:51 2015 +0900
description:
Bug 895274 part.1 Rename WidgetEvent::message to WidgetEvent::mMessage r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/756c006944ab770d06841c63a5d0f00616d3d41e
changeset:  756c006944ab770d06841c63a5d0f00616d3d41e
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 22 10:34:51 2015 +0900
description:
Bug 895274 part.2 Define event messages as anonymous enum with EventMessageList.h r=smaug

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bb91cf98a42b
https://hg.mozilla.org/mozilla-central/rev/756c006944ab

Comment 18

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=81d76a5f25b6

Comment 19

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ace592eb9959

Comment 20

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=28113dd275fe

Comment 21

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f871ecf2c36

Comment 22

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1b7eeee7b0ab

Comment 23

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.3 Make the enum of event messages a named enum

It seems that we should use enum class instead of named enum. However, for using it, we need to replace all items of the enum. It's difficult to do it for now. Even if you like enum class better, we should use named enum for now. After we will add unique prefix like "eEventMessage_" at renaming each item, we can replace all items easier. So, if you like enum class better, please let me know. I'll do that after renaming all event messages.

Therefore, this patch just makes the enum of event messages named enum, "mozilla::EventMessage". And the type of this enum can be uint16_t rather than uint32_t.

This patch also checks the size of EventListenerManager's size at build time with static_assert(). For dosing that, I separated the integer members to EventListenerManagerBase.

And also this patch names all variables of EventMessage as "EventMesage", "Message" or "Msg".

Additionally, this patch adds a lot of "default: break;" to the switch statements since they are necessary for avoiding warnings.

I'll post this patch with -w.

Comment 24

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.3 Make the enum of event messages a named enum (-w)

Comment 25

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.3 Make the enum of event messages a named enum (-w)

Comment 26

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

FYI: I don't change nsBaseDragService::FireDragEventAtSource()'s argument since it's a scriptable interface method. We should make it non-scriptable or expose the concrete class later.

Comment 27

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.4 Clean up the macro names of EventNameList.h

Now, we shouldn't call the event message as ID.

Comment 28

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/cd06f5f5641c3dfb7f07db878584d389fb4df1b7
changeset:  cd06f5f5641c3dfb7f07db878584d389fb4df1b7
user:       Masayuki Nakano <[e-mail]>
date:       Wed Aug 26 21:56:59 2015 +0900
description:
Bug 895274 part.3 Make the enum of event messages a named enum IGNORE IDL r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/5dc1087883b0c3685006722dbee0995c815ac4c1
changeset:  5dc1087883b0c3685006722dbee0995c815ac4c1
user:       Masayuki Nakano <[e-mail]>
date:       Wed Aug 26 21:56:59 2015 +0900
description:
Bug 895274 part.4 Clean up the macro names of EventNameList.h r=smaug

Comment 29

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

What's name do you like for each event message? I think normal event messages should be:

eEventMessage_KeyDown,
eEventMessage_MouseClick,
eEventMessage_MouseEnterWidget,
eEventMessage_MouseEnter,

On the other hand, the "start" and "end" messages should be "first" and "last" like the messages of Windows. start and end could be used by explaining operations, e.g., "drag start". So, I think they should be:

eEventMessage_KeyFirst,
eEventMessage_KeyLast,
eEventMessage_MouseFirst,
eEventMessage_MouseLast,

Do you have some better ideas?

Comment 30

[Olli Pettay [:smaug][[e-mail]]]

Do we need eEventMessage_* ?
Why not just eKeyDown etc?

first and last sound good.

Comment 31

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Olli Pettay [:smaug] (high review load) from comment #30)
> Do we need eEventMessage_* ?
> Why not just eKeyDown etc?

Oh, does it OK? You don't think that we should make them enum class for stricter type check? If we should do that, common prefix helps me to replace with EventMessage::eKeyDown or something. (But if we don't need to do that, shorter name is better!)

Comment 32

[Olli Pettay [:smaug][[e-mail]]]

Well, does the longer name really help with type check? I think not. So I prefer shorter names, since those are still very clear.

Comment 33

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Olli Pettay [:smaug] (high review load) from comment #32)
> Well, does the longer name really help with type check? I think not. So I
> prefer shorter names, since those are still very clear.

Okay, then, we should keep using named enum and shorter item names. I'll create some patches tomorrow.

Comment 34

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/cd06f5f5641c
https://hg.mozilla.org/mozilla-central/rev/5dc1087883b0

Comment 35

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

FYI: I realized that we don't have any specific rule of naming enum items...
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style

Comment 36

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Olli Pettay [:smaug] (high review load) from comment #32)
> Well, does the longer name really help with type check?

Oops, I missed this point. If we use enum class, we have following merits:

We can reduce "e" prefix because each item name is valid only under the class name. So, e.g., EventMessage::Null won't conflict with anything.

enum class allows to use forward declaration. Therefore, header files don't need to include the defined header file only for a method which has EventMessage as a result type or an argument.

And enum class doesn't allow following code:

uint32_t foo = enumclass::bar; // error at build time

So, when we need to use to set to/get from integer, we need to cast explicitly.

Comment 37

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

In other words, shorter names are used for us, but they may conflict with other enum items if we name some of them with too generic name.

Comment 38

[Olli Pettay [:smaug][[e-mail]]]

ah, conflicts are possible, though with e-prefix hopefully unlikely.

Comment 39

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Hmm, I feel following names are odd:

NS_KEY_BEFORE_DOWN
NS_KEY_AFTER_DOWN 
NS_KEY_BEFORE_UP  
NS_KEY_AFTER_UP   

They are named as "mozbrowser(before|after)key(down|up). And the class name is InternalBeforeAfterKeyboardEvent. So, in the current idea, they should be e(Before|After)Key(Down|Up)...

Comment 40

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I guess that if we change the enum to enum class, the longest name will be probably EventMessage::QuerySelectionAsTransferable. It's 8 characters longer than NS_QUERY_SELECTION_AS_TRANSFERABLE.

Comment 41

[Olli Pettay [:smaug][[e-mail]]]

Hmm, I was hoping e-prefixed names, and without EventMessage:: everywhere.

And yes, those before/after names could be changed.

Comment 42

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Okay, then, I'll keep yesterday's rules.

Comment 43

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Er, *was* hoping?

Comment 44

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0f1376ffa666

Comment 45

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=303aed77be71

Comment 46

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.5 Raneme NS_EVENT_NULL to eVoidEvent

I think that message indicates the meaning of message. Then, void is better than null.

Comment 47

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.6 Raneme NS_EVENT_ALL to eAllEvents

Comment 48

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.7 Raneme NS_WINDOW_START to eWindowEventFirst

Comment 49

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.8 Raneme NS_XUL_CLOSE to eWindowClose

Looks like that this is an event fired at closing window (not DOM window). Therefore, I don't think "XUL" is necessary keyword for this.

Comment 50

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.9 Raneme NS_KEY_PRESS to eKeyPress

Comment 51

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.10 Raneme NS_KEY_UP to eKeyUp

Comment 52

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.11 Raneme NS_KEY_DOWN to eKeyDown

Comment 53

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.12 Raneme NS_KEY_BEFORE_DOWN to eBeforeKeyDown

Comment 54

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.13 Raneme NS_KEY_AFTERE_DOWN to eAfterKeyDown

Comment 55

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.14 Raneme NS_KEY_BEFORE_UP to eBeforeKeyUp

Comment 56

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.15 Raneme NS_KEY_AFTER_UP to eAfterKeyUp

Comment 57

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.16 Raneme NS_RESIZE to eWindowResize

I think "window" resize event is better.

Comment 58

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.17 Raneme NS_SCROLL_EVENT to eScroll

Comment 59

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.18 Raneme NS_PLUGIN_ACTIVATE to ePluginActivate

Comment 60

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.19 Raneme NS_PLUGIN_FOCUS to ePluginFocus

Comment 61

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.20 Raneme NS_OFFLINE to eOffline

The name may be too generic...

Comment 62

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.21 Raneme NS_ONLINE to eOnline

Comment 63

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.22 Get rid of NS_MOZ_USER_* since nobody is using them

I guess that somebody forgot to remove them.

Comment 64

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.23 Raneme NS_LANGUAGECHANGE to eLanguageChange

Comment 65

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.24 Raneme NS_MOUSE_MESSAGE_START to eMouseEventFirst

Comment 66

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.25 Raneme NS_MOUSE_MOVE to eMouseMove

Comment 67

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.26 Raneme NS_MOUSE_BUTTON_UP to eMouseUp

Comment 68

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.27 Raneme NS_MOUSE_BUTTON_DOWN to eMouseDown

Comment 69

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.28 Raneme NS_MOUSE_ENTER_WIDGET to eMouseEnterIntoWidget

Comment 70

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.29 Raneme NS_MOUSE_EXIT_WIDGET to eMouseExitFromWidget

Comment 71

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.30 Raneme NS_MOUSE_DOUBLECLICK to eMouseDoubleClick

Comment 72

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.31 Raneme NS_MOUSE_CLICK to eMouseClick

Comment 73

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.32 Raneme NS_MOUSE_ACTIVATE to eMouseActivate

Comment 74

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.33 Raneme NS_MOUSE_OVER to eMouseOver

Comment 75

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.34 Raneme NS_MOUSE_OUT to eMouseOut

Comment 76

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.35 Raneme NS_MOUSE_MOZHITTEST to eMouseHitTest

I don't think this needs "Moz" keyword because this enum isn't exposed to the web.

And I'm not sure which is better of "HitTest" and "Hittest". According to the dictionary, a word, "hittest", doesn't exist. Therefore, I use "HitTest" in this patch.

Comment 77

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.36 Raneme NS_MOUSEENTER to eMouseEnter

Comment 78

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.37 Raneme NS_MOUSELEAVE to eMouseLeave

Comment 79

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.38 Raneme NS_MOUSE_MOZLONGTAP to eMouseLongTap

This also shouldn't need "Moz" keyword.

Comment 80

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8653893 [details] [diff] [review]
part.16 Raneme NS_RESIZE to eWindowResize

I think this should be just eResize, since, as odd as it is, there is resize event dispatched also to media elements.
With that, r+

Comment 81

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8654033 [details] [diff] [review]
part.38 Raneme NS_MOUSE_MOZLONGTAP to eMouseLongTap

># HG changeset patch
># User Masayuki Nakano <[e-mail]>
># Parent  ba03386e5ff331d963e3c8de27ad24733078b28b
>Bug 895274 part.38 Raneme NS_MOUSE_MOZLONGTAP to eMouseLongTap r=
Rename

Comment 82

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8653894 [details] [diff] [review]
part.17 Raneme NS_SCROLL_EVENT to eScroll

># HG changeset patch
># User Masayuki Nakano <[e-mail]>
># Parent  6b624e1d45ede081c9de33b2af195d64a40df1a3
>Bug 895274 part.17 Raneme NS_SCROLL_EVENT to eScroll r=
Rename

Comment 83

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8653895 [details] [diff] [review]
part.18 Raneme NS_PLUGIN_ACTIVATE to ePluginActivate

># HG changeset patch
># User Masayuki Nakano <[e-mail]>
># Parent  c17930d465c38337eee420ef7b3afae2f69b00fc
>Bug 895274 part.18 Raneme NS_PLUGIN_ACTIVATE to ePluginActivate r=
Rename

I guess the same copy-past mistake in most of the commit messages ;)
So, not complaining that more, but please fix everywhere.

Comment 84

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8653899 [details] [diff] [review]
part.22 Get rid of NS_MOZ_USER_* since nobody is using them

I would just remove the unused code and the comment about these.
With that, r+

Comment 85

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8654020 [details] [diff] [review]
part.28 Raneme NS_MOUSE_ENTER_WIDGET to eMouseEnterIntoWidget

>-  // Do not take account NS_MOUSE_ENTER_WIDGET/EXIT_WIDGET so that loading a page
>+  // Do not take account eMouseEnterIntoWidget/FromWidget so that loading a page
eMouseEnterIntoWidget/ExitFromWidget

Comment 86

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/3de33e39e9ce795331196508ea5d36f2547a4bcb
changeset:  3de33e39e9ce795331196508ea5d36f2547a4bcb
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:26 2015 +0900
description:
Bug 895274 part.5 Rename NS_EVENT_NULL to eVoidEvent r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/8efaeb0052b0a101a70ce32f71f72c825591833e
changeset:  8efaeb0052b0a101a70ce32f71f72c825591833e
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:26 2015 +0900
description:
Bug 895274 part.6 Rename NS_EVENT_ALL to eAllEvents r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/2a4abd0f4d111e3bce761afc1d78d624664eea0c
changeset:  2a4abd0f4d111e3bce761afc1d78d624664eea0c
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:26 2015 +0900
description:
Bug 895274 part.7 Rename NS_WINDOW_START to eWindowEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/ae177f1853f552127ca9216d487bd014bbd2d6df
changeset:  ae177f1853f552127ca9216d487bd014bbd2d6df
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:26 2015 +0900
description:
Bug 895274 part.8 Rename NS_XUL_CLOSE to eWindowClose r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/6e12f5164cb9f833ec9cbb958131aadb530e164c
changeset:  6e12f5164cb9f833ec9cbb958131aadb530e164c
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:27 2015 +0900
description:
Bug 895274 part.9 Rename NS_KEY_PRESS to eKeyPress r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/83b87aa188ab9c744697b87eb0c47c8a13d5babc
changeset:  83b87aa188ab9c744697b87eb0c47c8a13d5babc
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:27 2015 +0900
description:
Bug 895274 part.10 Rename NS_KEY_UP to eKeyUp r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/4a2797061277a5a2a3ba878144431a3b2f50392f
changeset:  4a2797061277a5a2a3ba878144431a3b2f50392f
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:27 2015 +0900
description:
Bug 895274 part.11 Rename NS_KEY_DOWN to eKeyDown r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/d826b30611d8941e7ff487ea8acd51cade119ce9
changeset:  d826b30611d8941e7ff487ea8acd51cade119ce9
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:27 2015 +0900
description:
Bug 895274 part.12 Rename NS_KEY_BEFORE_DOWN to eBeforeKeyDown r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/57679af15e80758688d4bc0f54b662a084ce0904
changeset:  57679af15e80758688d4bc0f54b662a084ce0904
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:28 2015 +0900
description:
Bug 895274 part.13 Rename NS_KEY_AFTERE_DOWN to eAfterKeyDown r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/15282e20479563dc050ec3015610d880001baed2
changeset:  15282e20479563dc050ec3015610d880001baed2
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:28 2015 +0900
description:
Bug 895274 part.14 Rename NS_KEY_BEFORE_UP to eBeforeKeyUp r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/ef04b1227c95e42b29d6bf0626c021b24871d767
changeset:  ef04b1227c95e42b29d6bf0626c021b24871d767
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:28 2015 +0900
description:
Bug 895274 part.15 Rename NS_KEY_AFTER_UP to eAfterKeyUp r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/90da8b9aaf2e777b0ed64773f75e4cd45a9b3e8a
changeset:  90da8b9aaf2e777b0ed64773f75e4cd45a9b3e8a
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:28 2015 +0900
description:
Bug 895274 part.16 Rename NS_RESIZE to eResize r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/862ef097c279ec53b682694351d11e61083e08d0
changeset:  862ef097c279ec53b682694351d11e61083e08d0
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:28 2015 +0900
description:
Bug 895274 part.17 Rename NS_SCROLL_EVENT to eScroll r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/da3eb3291c32042466fcc13813d85b6b758413d7
changeset:  da3eb3291c32042466fcc13813d85b6b758413d7
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:28 2015 +0900
description:
Bug 895274 part.18 Rename NS_PLUGIN_ACTIVATE to ePluginActivate r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/4a2099a81968ec3a5f5a60a682170ceb28ae8dd4
changeset:  4a2099a81968ec3a5f5a60a682170ceb28ae8dd4
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:28 2015 +0900
description:
Bug 895274 part.19 Rename NS_PLUGIN_FOCUS to ePluginFocus r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/b409cf40a9f3b785427eaf3b387cc0b240f9c619
changeset:  b409cf40a9f3b785427eaf3b387cc0b240f9c619
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:29 2015 +0900
description:
Bug 895274 part.20 Rename NS_OFFLINE to eOffline r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/55b1a8515716fb1d6af18392e78261d7ce737c52
changeset:  55b1a8515716fb1d6af18392e78261d7ce737c52
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:29 2015 +0900
description:
Bug 895274 part.21 Rename NS_ONLINE to eOnline r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/746fe566eb9f29590d4ea733db34bef46d62ed1d
changeset:  746fe566eb9f29590d4ea733db34bef46d62ed1d
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:29 2015 +0900
description:
Bug 895274 part.22 Get rid of NS_MOZ_USER_* since nobody is using them r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/31d9af1df30fe60d55b3078776d197e311b73ff6
changeset:  31d9af1df30fe60d55b3078776d197e311b73ff6
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:29 2015 +0900
description:
Bug 895274 part.23 Rename NS_LANGUAGECHANGE to eLanguageChange r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/ef0b9c30a9e7581939b413908f2f9b7699ef9974
changeset:  ef0b9c30a9e7581939b413908f2f9b7699ef9974
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:29 2015 +0900
description:
Bug 895274 part.24 Rename NS_MOUSE_MESSAGE_START to eMouseEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/cd4d30cf8ecfb8789d0e69c2adcdfe4c1de7ac8f
changeset:  cd4d30cf8ecfb8789d0e69c2adcdfe4c1de7ac8f
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:29 2015 +0900
description:
Bug 895274 part.25 Rename NS_MOUSE_MOVE to eMouseMove r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/ae625cd90875c0f939e83fc58c9e40fb3b6fd75f
changeset:  ae625cd90875c0f939e83fc58c9e40fb3b6fd75f
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:30 2015 +0900
description:
Bug 895274 part.26 Rename NS_MOUSE_BUTTON_UP to eMouseUp r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/e637f3ff6f3e3add6aa4ac4b7325e3983504cef7
changeset:  e637f3ff6f3e3add6aa4ac4b7325e3983504cef7
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:30 2015 +0900
description:
Bug 895274 part.27 Rename NS_MOUSE_BUTTON_DOWN to eMouseDown r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/389f60113c0c037c562eb46f4dfa23feab74a20e
changeset:  389f60113c0c037c562eb46f4dfa23feab74a20e
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:31 2015 +0900
description:
Bug 895274 part.28 Rename NS_MOUSE_ENTER_WIDGET to eMouseEnterIntoWidget r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/6949e818c397150c21e14c3d05edb55a86255eba
changeset:  6949e818c397150c21e14c3d05edb55a86255eba
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:31 2015 +0900
description:
Bug 895274 part.29 Rename NS_MOUSE_EXIT_WIDGET to eMouseExitFromWidget r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/881d177f345734dee4b9b6a82da9663357dd9da1
changeset:  881d177f345734dee4b9b6a82da9663357dd9da1
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:31 2015 +0900
description:
Bug 895274 part.30 Rename NS_MOUSE_DOUBLECLICK to eMouseDoubleClick r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/c9288d4f5e63369b8f98319ac029a759519ace62
changeset:  c9288d4f5e63369b8f98319ac029a759519ace62
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:32 2015 +0900
description:
Bug 895274 part.31 Rename NS_MOUSE_CLICK to eMouseClick r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/ce720f26f58cd3a808c4af314582d21a39e77a70
changeset:  ce720f26f58cd3a808c4af314582d21a39e77a70
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:32 2015 +0900
description:
Bug 895274 part.32 Rename NS_MOUSE_ACTIVATE to eMouseActivate r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/b8fe1dac71aeb337dbdb084297b25071d03cf1a0
changeset:  b8fe1dac71aeb337dbdb084297b25071d03cf1a0
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:32 2015 +0900
description:
Bug 895274 part.33 Rename NS_MOUSE_OVER to eMouseOver r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/4bcb03faecc6d51c09068243a4b73240b7af80a2
changeset:  4bcb03faecc6d51c09068243a4b73240b7af80a2
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:32 2015 +0900
description:
Bug 895274 part.34 Rename NS_MOUSE_OUT to eMouseOut r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/0d03f7de34c57ba40ca9a60d41f8ce5ca3a47aae
changeset:  0d03f7de34c57ba40ca9a60d41f8ce5ca3a47aae
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:32 2015 +0900
description:
Bug 895274 part.35 Rename NS_MOUSE_MOZHITTEST to eMouseHitTest r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/691fe61c6289fa27fd6b41a3bc210680992a5718
changeset:  691fe61c6289fa27fd6b41a3bc210680992a5718
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:33 2015 +0900
description:
Bug 895274 part.36 Rename NS_MOUSEENTER to eMouseEnter r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/be7520290d1273ee2c9245f1347f97933d50b216
changeset:  be7520290d1273ee2c9245f1347f97933d50b216
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:33 2015 +0900
description:
Bug 895274 part.37 Rename NS_MOUSELEAVE to eMouseLeave r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/5899c44ed9ce7f54da590ce89d8922d34e4b7ac9
changeset:  5899c44ed9ce7f54da590ce89d8922d34e4b7ac9
user:       Masayuki Nakano <[e-mail]>
date:       Sat Aug 29 08:58:33 2015 +0900
description:
Bug 895274 part.38 Rename NS_MOUSE_MOZLONGTAP to eMouseLongTap r=smaug

Comment 87

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

FYI: eResize conflicts with nsIPresShell::eResize. Therefore, I append scope to each eResize in nsPresShell.cpp.
https://hg.mozilla.org/integration/mozilla-inbound/diff/90da8b9aaf2e/layout/base/nsPresShell.cpp

If you think that this is bad, let me know.

Comment 88

[Olli Pettay [:smaug][[e-mail]]]

that is fine.

Comment 89

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3de33e39e9ce
https://hg.mozilla.org/mozilla-central/rev/8efaeb0052b0
https://hg.mozilla.org/mozilla-central/rev/2a4abd0f4d11
https://hg.mozilla.org/mozilla-central/rev/ae177f1853f5
https://hg.mozilla.org/mozilla-central/rev/6e12f5164cb9
https://hg.mozilla.org/mozilla-central/rev/83b87aa188ab
https://hg.mozilla.org/mozilla-central/rev/4a2797061277
https://hg.mozilla.org/mozilla-central/rev/d826b30611d8
https://hg.mozilla.org/mozilla-central/rev/57679af15e80
https://hg.mozilla.org/mozilla-central/rev/15282e204795
https://hg.mozilla.org/mozilla-central/rev/ef04b1227c95
https://hg.mozilla.org/mozilla-central/rev/90da8b9aaf2e
https://hg.mozilla.org/mozilla-central/rev/862ef097c279
https://hg.mozilla.org/mozilla-central/rev/da3eb3291c32
https://hg.mozilla.org/mozilla-central/rev/4a2099a81968
https://hg.mozilla.org/mozilla-central/rev/b409cf40a9f3
https://hg.mozilla.org/mozilla-central/rev/55b1a8515716
https://hg.mozilla.org/mozilla-central/rev/746fe566eb9f
https://hg.mozilla.org/mozilla-central/rev/31d9af1df30f
https://hg.mozilla.org/mozilla-central/rev/ef0b9c30a9e7
https://hg.mozilla.org/mozilla-central/rev/cd4d30cf8ecf
https://hg.mozilla.org/mozilla-central/rev/ae625cd90875
https://hg.mozilla.org/mozilla-central/rev/e637f3ff6f3e
https://hg.mozilla.org/mozilla-central/rev/389f60113c0c
https://hg.mozilla.org/mozilla-central/rev/6949e818c397
https://hg.mozilla.org/mozilla-central/rev/881d177f3457
https://hg.mozilla.org/mozilla-central/rev/c9288d4f5e63
https://hg.mozilla.org/mozilla-central/rev/ce720f26f58c
https://hg.mozilla.org/mozilla-central/rev/b8fe1dac71ae
https://hg.mozilla.org/mozilla-central/rev/4bcb03faecc6
https://hg.mozilla.org/mozilla-central/rev/0d03f7de34c5
https://hg.mozilla.org/mozilla-central/rev/691fe61c6289
https://hg.mozilla.org/mozilla-central/rev/be7520290d12
https://hg.mozilla.org/mozilla-central/rev/5899c44ed9ce

Comment 90

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dec7e8893c4c

Comment 91

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Hmm,

> 81 NS_EVENT_MESSAGE(NS_STREAM_EVENT_START, 1100)
> 82 NS_EVENT_MESSAGE(NS_LOAD,               NS_STREAM_EVENT_START)
> 83 NS_EVENT_MESSAGE(NS_PAGE_UNLOAD,        NS_STREAM_EVENT_START + 1)
> 84 NS_EVENT_MESSAGE(NS_HASHCHANGE,         NS_STREAM_EVENT_START + 2)
> 85 NS_EVENT_MESSAGE(NS_IMAGE_ABORT,        NS_STREAM_EVENT_START + 3)
> 86 NS_EVENT_MESSAGE(NS_LOAD_ERROR,         NS_STREAM_EVENT_START + 4)
> 87 NS_EVENT_MESSAGE(NS_POPSTATE,           NS_STREAM_EVENT_START + 5)
> 88 NS_EVENT_MESSAGE(NS_BEFORE_PAGE_UNLOAD, NS_STREAM_EVENT_START + 6)
> 89 NS_EVENT_MESSAGE(NS_PAGE_RESTORE,       NS_STREAM_EVENT_START + 7)
> 90 NS_EVENT_MESSAGE(NS_READYSTATECHANGE,   NS_STREAM_EVENT_START + 8)

Do you think "Page" is necessary for unload event?

eLoad, eUnload feel enough to me. I'm not sure NS_PAGE_RESTORE, though...

Comment 92

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Oh, NS_PAGE_RESTORE isn't used.
http://mxr.mozilla.org/mozilla-central/search?string=NS_PAGE_RESTORE

Comment 93

[Olli Pettay [:smaug][[e-mail]]]

Nice :/


Load certainly doesn't need 'Page', and I think unload could without it too.

Comment 94

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Thanks!

Comment 95

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.39 Rename NS_POINTER_EVENT_START to ePointerEventFirst

Comment 96

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.40 Rename NS_POINTER_LOST_CAPTURE to ePointerLostCapture

Comment 97

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.41 Rename NS_POINTER_GOT_CAPTURE to ePointerGotCapture

Comment 98

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.42 Rename NS_POINTER_CANCEL to ePointerCancel

Comment 99

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.43 Rename NS_POINTER_LEAVE to ePointerLeave

Comment 100

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.44 Rename NS_POINTER_ENTER to ePointerEnter

Comment 101

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.45 Rename NS_POINTER_OUT to ePointerOut

Comment 102

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.46 Rename NS_POINTER_OVER to ePointerOver

Comment 103

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.47 Rename NS_POINTER_DOWN to ePointerDown

Comment 104

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.48 Rename NS_POINTER_UP to ePointerUp

Comment 105

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.49 Rename NS_POINTER_MOVE to ePointerMove

Comment 106

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.50 Rename NS_CONTEXTMENU_MESSAGE_START to eContextMenuFirst

Comment 107

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.51 Rename NS_CONTEXTMENU to eContextMenu

Comment 108

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba8e948c7f93

Comment 109

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8654844 [details] [diff] [review]
part.39 Rename NS_POINTER_EVENT_START to ePointerEventFirst

>+NS_EVENT_MESSAGE(ePointerEventFirst,    4400)
I wonder if 4400 should be aligned with the ePointerEventFirst. But perhaps some other patch changes this stuff

Comment 110

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/b3a11cf986072c52d4b00532febe1ec53fa4f22a
changeset:  b3a11cf986072c52d4b00532febe1ec53fa4f22a
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 01 00:20:05 2015 +0900
description:
Bug 895274 part.39 Rename NS_POINTER_EVENT_START to ePointerEventFirst and add ePointerEventLast r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/04ed6773489c51298603209fe7f3e0ff0c02368a
changeset:  04ed6773489c51298603209fe7f3e0ff0c02368a
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 01 00:20:05 2015 +0900
description:
Bug 895274 part.40 Rename NS_POINTER_LOST_CAPTURE to ePointerLostCapture r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/6fe4281b2f0bc35740e2399f01646b52ab3cd8f0
changeset:  6fe4281b2f0bc35740e2399f01646b52ab3cd8f0
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 01 00:20:05 2015 +0900
description:
Bug 895274 part.41 Rename NS_POINTER_GOT_CAPTURE to ePointerGotCapture r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/c0b1bff50484386fa3bcbb70e79f67f2748c69ee
changeset:  c0b1bff50484386fa3bcbb70e79f67f2748c69ee
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 01 00:20:05 2015 +0900
description:
Bug 895274 part.42 Rename NS_POINTER_CANCEL to ePointerCancel r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/81616c5e77d7893153138a33652694099827bc50
changeset:  81616c5e77d7893153138a33652694099827bc50
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 01 00:20:05 2015 +0900
description:
Bug 895274 part.43 Rename NS_POINTER_LEAVE to ePointerLeave r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/64973fea75722564451f73a524fc335d0f27d76e
changeset:  64973fea75722564451f73a524fc335d0f27d76e
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 01 00:20:05 2015 +0900
description:
Bug 895274 part.44 Rename NS_POINTER_ENTER to ePointerEnter r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/628fdef4a033fed83cd1bac4b1f1b6ea5b4017e1
changeset:  628fdef4a033fed83cd1bac4b1f1b6ea5b4017e1
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 01 00:20:05 2015 +0900
description:
Bug 895274 part.45 Rename NS_POINTER_OUT to ePointerOut r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/d7d3fe895b8dfb9176f560391b4934348fc1b630
changeset:  d7d3fe895b8dfb9176f560391b4934348fc1b630
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 01 00:20:05 2015 +0900
description:
Bug 895274 part.46 Rename NS_POINTER_OVER to ePointerOver r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/c66504b2b0b24846d0f9bd081ec6e36782237d7f
changeset:  c66504b2b0b24846d0f9bd081ec6e36782237d7f
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 01 00:20:06 2015 +0900
description:
Bug 895274 part.47 Rename NS_POINTER_DOWN to ePointerDown r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/b8957e880eba52047056b3e4d5f611fad08180e7
changeset:  b8957e880eba52047056b3e4d5f611fad08180e7
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 01 00:20:06 2015 +0900
description:
Bug 895274 part.48 Rename NS_POINTER_UP to ePointerUp r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/9a728655edf95ccfcd0c600eb381433bf620af9f
changeset:  9a728655edf95ccfcd0c600eb381433bf620af9f
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 01 00:20:06 2015 +0900
description:
Bug 895274 part.49 Rename NS_POINTER_MOVE to ePointerMove r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/44c0607b46208775584259b72146408b3ddc42ae
changeset:  44c0607b46208775584259b72146408b3ddc42ae
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 01 00:20:06 2015 +0900
description:
Bug 895274 part.50 Rename NS_CONTEXTMENU_MESSAGE_START to eContextMenuFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/3c16bb077e3173848498c17edb876ff2e8990e22
changeset:  3c16bb077e3173848498c17edb876ff2e8990e22
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 01 00:20:06 2015 +0900
description:
Bug 895274 part.51 Rename NS_CONTEXTMENU to eContextMenu r=smaug

Comment 111

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Olli Pettay [:smaug] (high review load, please consider other reviewers) from comment #109)
> Comment on attachment 8654844 [details] [diff] [review]
> part.39 Rename NS_POINTER_EVENT_START to ePointerEventFirst
> 
> >+NS_EVENT_MESSAGE(ePointerEventFirst,    4400)
> I wonder if 4400 should be aligned with the ePointerEventFirst. But perhaps
> some other patch changes this stuff

FYI: I'm checking every use case of the event message values. So, when we fix this bug, I think that we can remove specifying value to every event message.

Comment 112

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Like this:

NS_EVENT_MESSAGE(ePointerMove)
NS_EVENT_MESSAGE(ePointerUp)
NS_EVENT_MESSAGE(ePointerDown)
NS_EVENT_MESSAGE(ePointerOver)
NS_EVENT_MESSAGE(ePointerOut)
NS_EVENT_MESSAGE(ePointerEnter)
NS_EVENT_MESSAGE(ePointerLeave)
NS_EVENT_MESSAGE(ePointerCancel)
NS_EVENT_MESSAGE(ePointerGotCapture)
NS_EVENT_MESSAGE(ePointerLostCapture)
NS_SPECIAL_EVENT_MESSAGE(ePointerEventLast,     ePointerMove)
NS_SPECIAL_EVENT_MESSAGE(ePointerEventLast,     ePointerLostCapture)

Comment 113

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.52 Get rid of NS_PAGE_RESTORE due to unused

Comment 114

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.53 Rename NS_STREAM_EVENT_START to eStreamEventFirst

Comment 115

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.54 Rename NS_READYSTATECHANGE to eReadyStateChange

Comment 116

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.55 Rename NS_BEFORE_PAGE_UNLOAD to eBeforeUnload

Comment 117

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.56 Rename NS_POPSTATE to ePopState

Comment 118

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.57 Rename NS_LOAD_ERROR to eLoadError

According to the DOM event name, this could be eError, but it's too generic. I prefer eLoadError instead.

Comment 119

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.58 Rename NS_IMAGE_ABORT to eImageAbort

According to the DOM event name, this could be eAbort. But it's too generic. Therefore, I prefer eImageAbort instead.

Comment 120

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.59 Rename NS_HASHCHANGE to eHashChange

Comment 121

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.60 Rename NS_PAGE_UNLOAD to eUnload

Comment 122

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.61 Rename NS_LOAD to eLoad

Comment 123

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.62 Rename NS_FORM_EVENT_START to eFormEventFirst

Comment 124

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.63 Rename NS_FORM_SUBMIT to eFormSubmit

Could be eSubmit. But "Form" keyword is clearer. Therefore, I don't remove it from this event message. But it could be...

Comment 125

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.64 Rename NS_FORM_RESET to eFormReset

Same.

Comment 126

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.65 Rename NS_FORM_CHANGE to eFormChange

Same.

Comment 127

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.66 Rename NS_FORM_SELECTED to eFormSelect

Same. And also "Selected" isn't good for consistency with other event message names. I like "Select" better.

Comment 128

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.67 Rename NS_FORM_INVALID to eFormInvalid

Same, but eInvalid must be too generic.

Comment 129

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f939fab5362a

Comment 130

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.68 Rename NS_FOCUS_EVENT_START to eFocusEventFirst

Comment 131

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.69 Rename NS_FOCUS_CONTENT to eFocus

I think that eFocus is enough rather than eFocusContent.

Comment 132

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.70 Rename NS_BLUR_CONTENT to eBlur

Same.

Comment 133

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.71 Rename NS_UI_EVENT_START to eLegacyUIEventFirst

"UI" isn't clear to me. NS_UI_* define the event messages of legacy event which indicates an element state. So, I think that "Legacy" helps developers to understand what the events and how should they tread.

Therefore, I name this to eLegacyUIEventFirst. And each of the messages is:

* NS_UI_ACTIVATE -> eLegacyDOMActivate
* NS_UI_FOCUSIN ->  eLegacyDOMFocusIn
* NS_UI_FOCUSOUT -> eLegacyDOMFocusOut

So, the new names indicate which legacy DOM event explicitly.

Comment 134

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b3a11cf98607
https://hg.mozilla.org/mozilla-central/rev/04ed6773489c
https://hg.mozilla.org/mozilla-central/rev/6fe4281b2f0b
https://hg.mozilla.org/mozilla-central/rev/c0b1bff50484
https://hg.mozilla.org/mozilla-central/rev/81616c5e77d7
https://hg.mozilla.org/mozilla-central/rev/64973fea7572
https://hg.mozilla.org/mozilla-central/rev/628fdef4a033
https://hg.mozilla.org/mozilla-central/rev/d7d3fe895b8d
https://hg.mozilla.org/mozilla-central/rev/c66504b2b0b2
https://hg.mozilla.org/mozilla-central/rev/b8957e880eba
https://hg.mozilla.org/mozilla-central/rev/9a728655edf9
https://hg.mozilla.org/mozilla-central/rev/44c0607b4620
https://hg.mozilla.org/mozilla-central/rev/3c16bb077e31

Comment 135

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.72 Rename NS_UI_ACTIVATE to eLegacyDOMActivate

Comment 136

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.73 Rename NS_UI_FOCUSIN to eLegacyDOMFocusIn

Comment 137

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.74 Rename NS_UI_FOCUSOUT to eLegacyDOMFocusOut

Comment 138

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.75 Rename NS_DRAGDROP_EVENT_START to eDragDropEventFirst

Comment 139

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.76 Rename NS_DRAGDROP_LEAVE to eDragLeave

I think that using DOM event name is better. So, I name this as eDragLeave, not eDragDropLeave.

Comment 140

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.77 Rename NS_DRAGDROP_DROP to eDrop

Comment 141

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.78 Rename NS_DRAGDROP_START to eDragStart

Comment 142

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.79 Rename NS_DRAGDROP_END to eDragEnd

Comment 143

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.80 Rename NS_DRAGDROP_DRAG to eDrag

Comment 144

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.81 Rename NS_DRAGDROP_OVER to eDragOver

Comment 145

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.82 Rename NS_DRAGDROP_ENTER to eDragEnter

Comment 146

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.83 Rename NS_DRAGDROP_EXIT to eDragExit

Comment 147

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.84 Rename NS_DRAGDROP_DRAGDROP to eLegacyDragDrop

Similar to NS_UI_*, let's use "Legacy" keyword for non-standard dnd events. This name must help developers what's different from the similar event, eDrop.

Comment 148

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.85 Rename NS_DRAGDROP_GESTURE to eLegacyDragGesture

Same. This is a legacy event of eDragStart.

Comment 149

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8655396 [details] [diff] [review]
part.71 Rename NS_UI_EVENT_START to eLegacyUIEventFirst

Ah, I like this naming.

Comment 150

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=354c192eca80

Comment 151

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=53f4ccbfcd39

Comment 152

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/196b7de875ef521f938904e0dceb62a6ba2fd897
changeset:  196b7de875ef521f938904e0dceb62a6ba2fd897
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:07:58 2015 +0900
description:
Bug 895274 part.52 Get rid of NS_PAGE_RESTORE due to unused r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/6966f9d6f70bfeaebdd4f08afb1f725a17949787
changeset:  6966f9d6f70bfeaebdd4f08afb1f725a17949787
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:07:58 2015 +0900
description:
Bug 895274 part.53 Rename NS_STREAM_EVENT_START to eStreamEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/305e40d37ee560305b95ba5e95a73d5b0b30a28b
changeset:  305e40d37ee560305b95ba5e95a73d5b0b30a28b
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:07:58 2015 +0900
description:
Bug 895274 part.54 Rename NS_READYSTATECHANGE to eReadyStateChange r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/3bfcdb7bfe8d137cd7cba3dcdbb98d46328dcaca
changeset:  3bfcdb7bfe8d137cd7cba3dcdbb98d46328dcaca
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:07:59 2015 +0900
description:
Bug 895274 part.55 Rename NS_BEFORE_PAGE_UNLOAD to eBeforeUnload r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/44d54a262d71f16b578bdee228b7854b77a75b11
changeset:  44d54a262d71f16b578bdee228b7854b77a75b11
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:07:59 2015 +0900
description:
Bug 895274 part.56 Rename NS_POPSTATE to ePopState r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/227bdcb2316da1bb496246ca4f8034d8e4d078e3
changeset:  227bdcb2316da1bb496246ca4f8034d8e4d078e3
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:07:59 2015 +0900
description:
Bug 895274 part.57 Rename NS_LOAD_ERROR to eLoadError r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/347f30d4b57b21604f9df04fe09f09c45f66e657
changeset:  347f30d4b57b21604f9df04fe09f09c45f66e657
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:07:59 2015 +0900
description:
Bug 895274 part.58 Rename NS_IMAGE_ABORT to eImageAbort r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/0a0c6edeaeab51cf022b2d023f52c53fda196892
changeset:  0a0c6edeaeab51cf022b2d023f52c53fda196892
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:07:59 2015 +0900
description:
Bug 895274 part.59 Rename NS_HASHCHANGE to eHashChange r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/280ce6c3a4eeb770861c5a8a7c6721a3d384e65f
changeset:  280ce6c3a4eeb770861c5a8a7c6721a3d384e65f
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:07:59 2015 +0900
description:
Bug 895274 part.60 Rename NS_PAGE_UNLOAD to eUnload r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/c3d179d89c2c14b77643b7911fd5600c8af61f41
changeset:  c3d179d89c2c14b77643b7911fd5600c8af61f41
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:07:59 2015 +0900
description:
Bug 895274 part.61 Rename NS_LOAD to eLoad r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/9afdaf8b032a01c5b9fc437dbde4db57f767bc34
changeset:  9afdaf8b032a01c5b9fc437dbde4db57f767bc34
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:07:59 2015 +0900
description:
Bug 895274 part.62 Rename NS_FORM_EVENT_START to eFormEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/5443202e95e681f179b5b0a86cc4aa00164452b1
changeset:  5443202e95e681f179b5b0a86cc4aa00164452b1
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:00 2015 +0900
description:
Bug 895274 part.63 Rename NS_FORM_SUBMIT to eFormSubmit r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/58ea57abc0e9736acc0e3c7fbf1a65d92b502edc
changeset:  58ea57abc0e9736acc0e3c7fbf1a65d92b502edc
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:00 2015 +0900
description:
Bug 895274 part.64 Rename NS_FORM_RESET to eFormReset r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/a4db59edaa15f10f93bbb372cf53224c1ecc6482
changeset:  a4db59edaa15f10f93bbb372cf53224c1ecc6482
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:00 2015 +0900
description:
Bug 895274 part.65 Rename NS_FORM_CHANGE to eFormChange r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/932f80808057e731b911c0a8cfd218541a03d324
changeset:  932f80808057e731b911c0a8cfd218541a03d324
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:00 2015 +0900
description:
Bug 895274 part.66 Rename NS_FORM_SELECTED to eFormSelect r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/5653edb7c0f71dfd7444ba15e5f09e4182076f9b
changeset:  5653edb7c0f71dfd7444ba15e5f09e4182076f9b
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:00 2015 +0900
description:
Bug 895274 part.67 Rename NS_FORM_INVALID to eFormInvalid r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/5f67d5de5adb1a9b31a945cbbe91db3e620a4e57
changeset:  5f67d5de5adb1a9b31a945cbbe91db3e620a4e57
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:00 2015 +0900
description:
Bug 895274 part.68 Rename NS_FOCUS_EVENT_START to eFocusEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/e9bb1fc9977aa1fb3df612fcd4954172bad8de41
changeset:  e9bb1fc9977aa1fb3df612fcd4954172bad8de41
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:00 2015 +0900
description:
Bug 895274 part.69 Rename NS_FOCUS_CONTENT to eFocus r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/89d8ce319bd0bff6a553ec382a0669abf79de8d9
changeset:  89d8ce319bd0bff6a553ec382a0669abf79de8d9
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:00 2015 +0900
description:
Bug 895274 part.70 Rename NS_BLUR_CONTENT to eBlur r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/4682f4db642d462d74c8afa0102373e191f47edd
changeset:  4682f4db642d462d74c8afa0102373e191f47edd
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:01 2015 +0900
description:
Bug 895274 part.71 Rename NS_UI_EVENT_START to eLegacyUIEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/cf4c3be6ea5689cf5cedf253b1bfd27290d2ba25
changeset:  cf4c3be6ea5689cf5cedf253b1bfd27290d2ba25
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:01 2015 +0900
description:
Bug 895274 part.72 Rename NS_UI_ACTIVATE to eLegacyDOMActivate r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/deb5c3173e6e250766cb28957dd919fd5e38dc3e
changeset:  deb5c3173e6e250766cb28957dd919fd5e38dc3e
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:01 2015 +0900
description:
Bug 895274 part.73 Rename NS_UI_FOCUSIN to eLegacyDOMFocusIn r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/be746a34f096038983737ea2f143bfc7daec1004
changeset:  be746a34f096038983737ea2f143bfc7daec1004
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:01 2015 +0900
description:
Bug 895274 part.74 Rename NS_UI_FOCUSOUT to eLegacyDOMFocusOut r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/38c50d1c496bcb1d3436ea34cfe7863a8e0004de
changeset:  38c50d1c496bcb1d3436ea34cfe7863a8e0004de
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:01 2015 +0900
description:
Bug 895274 part.75 Rename NS_DRAGDROP_EVENT_START to eDragDropEventFirst, define eDragDropEventLast and correct the type and name of event message in DataTransfer r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/76a8bd3c6ea34a2eccadf4a47d0eb6818e66aecc
changeset:  76a8bd3c6ea34a2eccadf4a47d0eb6818e66aecc
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:01 2015 +0900
description:
Bug 895274 part.76 Rename NS_DRAGDROP_LEAVE to eDragLeave r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/df96cb04b9dd41d97951a8cc6e68d7c332616c08
changeset:  df96cb04b9dd41d97951a8cc6e68d7c332616c08
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:01 2015 +0900
description:
Bug 895274 part.77 Rename NS_DRAGDROP_DROP to eDrop r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/2eb6dbb32ddc41d166123699cbc750d704cd120a
changeset:  2eb6dbb32ddc41d166123699cbc750d704cd120a
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:01 2015 +0900
description:
Bug 895274 part.78 Rename NS_DRAGDROP_START to eDragStart r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/99bfe44528f6dc6041a997710cdc49a5a53f13e7
changeset:  99bfe44528f6dc6041a997710cdc49a5a53f13e7
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:02 2015 +0900
description:
Bug 895274 part.79 Rename NS_DRAGDROP_END to eDragEnd r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/42d861b4a03568fa6bf3d4c45f6f089d04453f31
changeset:  42d861b4a03568fa6bf3d4c45f6f089d04453f31
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:02 2015 +0900
description:
Bug 895274 part.80 Rename NS_DRAGDROP_DRAG to eDrag r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/4f79fccb269836a8053a036c8a0734d618d92b41
changeset:  4f79fccb269836a8053a036c8a0734d618d92b41
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:02 2015 +0900
description:
Bug 895274 part.81 Rename NS_DRAGDROP_OVER to eDragOver r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/cad395df60d302e74ba82c7f46626180eb885d13
changeset:  cad395df60d302e74ba82c7f46626180eb885d13
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:02 2015 +0900
description:
Bug 895274 part.82 Rename NS_DRAGDROP_ENTER to eDragEnter r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/aaffbbb943e446e995c9f08c363bae24e0712a28
changeset:  aaffbbb943e446e995c9f08c363bae24e0712a28
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:02 2015 +0900
description:
Bug 895274 part.83 Rename NS_DRAGDROP_EXIT to eDragExit r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/3a188aef7f84eac26f6401ee337dd7c4d37b3f90
changeset:  3a188aef7f84eac26f6401ee337dd7c4d37b3f90
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:03 2015 +0900
description:
Bug 895274 part.84 Rename NS_DRAGDROP_DRAGDROP to eLegacyDragDrop r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/bd0d6c41b33ec106579e405ee660e150c0cac513
changeset:  bd0d6c41b33ec106579e405ee660e150c0cac513
user:       Masayuki Nakano <[e-mail]>
date:       Wed Sep 02 15:08:03 2015 +0900
description:
Bug 895274 part.85 Rename NS_DRAGDROP_GESTURE to eLegacyDragGesture r=smaug

Comment 153

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/196b7de875ef
https://hg.mozilla.org/mozilla-central/rev/6966f9d6f70b
https://hg.mozilla.org/mozilla-central/rev/305e40d37ee5
https://hg.mozilla.org/mozilla-central/rev/3bfcdb7bfe8d
https://hg.mozilla.org/mozilla-central/rev/44d54a262d71
https://hg.mozilla.org/mozilla-central/rev/227bdcb2316d
https://hg.mozilla.org/mozilla-central/rev/347f30d4b57b
https://hg.mozilla.org/mozilla-central/rev/0a0c6edeaeab
https://hg.mozilla.org/mozilla-central/rev/280ce6c3a4ee
https://hg.mozilla.org/mozilla-central/rev/c3d179d89c2c
https://hg.mozilla.org/mozilla-central/rev/9afdaf8b032a
https://hg.mozilla.org/mozilla-central/rev/5443202e95e6
https://hg.mozilla.org/mozilla-central/rev/58ea57abc0e9
https://hg.mozilla.org/mozilla-central/rev/a4db59edaa15
https://hg.mozilla.org/mozilla-central/rev/932f80808057
https://hg.mozilla.org/mozilla-central/rev/5653edb7c0f7
https://hg.mozilla.org/mozilla-central/rev/5f67d5de5adb
https://hg.mozilla.org/mozilla-central/rev/e9bb1fc9977a
https://hg.mozilla.org/mozilla-central/rev/89d8ce319bd0
https://hg.mozilla.org/mozilla-central/rev/4682f4db642d
https://hg.mozilla.org/mozilla-central/rev/cf4c3be6ea56
https://hg.mozilla.org/mozilla-central/rev/deb5c3173e6e
https://hg.mozilla.org/mozilla-central/rev/be746a34f096
https://hg.mozilla.org/mozilla-central/rev/38c50d1c496b
https://hg.mozilla.org/mozilla-central/rev/76a8bd3c6ea3
https://hg.mozilla.org/mozilla-central/rev/df96cb04b9dd
https://hg.mozilla.org/mozilla-central/rev/2eb6dbb32ddc
https://hg.mozilla.org/mozilla-central/rev/99bfe44528f6
https://hg.mozilla.org/mozilla-central/rev/42d861b4a035
https://hg.mozilla.org/mozilla-central/rev/4f79fccb2698
https://hg.mozilla.org/mozilla-central/rev/cad395df60d3
https://hg.mozilla.org/mozilla-central/rev/aaffbbb943e4
https://hg.mozilla.org/mozilla-central/rev/3a188aef7f84
https://hg.mozilla.org/mozilla-central/rev/bd0d6c41b33e

Comment 154

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f015e9e9a52c

Comment 155

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=210b6659bfa3

Comment 156

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=05118fce4014

Comment 157

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.86 Rename NS_XUL_EVENT_START to eXULEventFirst

When you have much time, could you check the patches? I don't like to ask review for the others since the new names should be decided by same person.

Comment 158

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.87 Rename NS_XUL_POPUP_SHOWING to eXULPopupShowing

Comment 159

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.88 Rename NS_XUL_POPUP_SHOWN to eXULPopupShown

Comment 160

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.89 Rename NS_XUL_POPUP_HIDING to eXULPopupHiding

Comment 161

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.90 Rename NS_XUL_POPUP_HIDDEN to eXULPopupHidden

Comment 162

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8656604 [details] [diff] [review]
part.86 Rename NS_XUL_EVENT_START to eXULEventFirst

This is trivial stuff

Comment 163

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.91 Rename NS_XUL_BROADCAST to eXULBroadcast

Comment 164

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.92 Rename NS_XUL_COMMAND_UPDATE to eXULCommandUpdate

Comment 165

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.93 Rename NS_XULCOMMAND_EVENT_START to eXULCommandEventFirst

I don't understand why this was separated from NS_XUL_*...

Comment 166

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.94 Rename NS_XUL_COMMAND to eXULCommand

Comment 167

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Could you review the remaining two patches?
https://bugzilla.mozilla.org/attachment.cgi?id=8656608&action=edit
https://bugzilla.mozilla.org/attachment.cgi?id=8656609&action=edit

Comment 168

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8656608 [details] [diff] [review]
part.90 Rename NS_XUL_POPUP_HIDDEN to eXULPopupHidden

Oh, I missed these.

Comment 169

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/e109ec7a6df6621a08bfe34e6e6c4e159bf2c8d4
changeset:  e109ec7a6df6621a08bfe34e6e6c4e159bf2c8d4
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 04 19:54:11 2015 +0900
description:
Bug 895274 part.86 Rename NS_XUL_EVENT_START to eXULEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/c24765571791120685b21e7f5b8bc7dc625a1eae
changeset:  c24765571791120685b21e7f5b8bc7dc625a1eae
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 04 19:54:11 2015 +0900
description:
Bug 895274 part.87 Rename NS_XUL_POPUP_SHOWING to eXULPopupShowing r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/97e0ba98dd52703a0040a4883c626fa5170f4785
changeset:  97e0ba98dd52703a0040a4883c626fa5170f4785
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 04 19:54:11 2015 +0900
description:
Bug 895274 part.88 Rename NS_XUL_POPUP_SHOWN to eXULPopupShown r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/7a48f1bb8b42a984c1ccf81dc2eb5b93583ed221
changeset:  7a48f1bb8b42a984c1ccf81dc2eb5b93583ed221
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 04 19:54:11 2015 +0900
description:
Bug 895274 part.89 Rename NS_XUL_POPUP_HIDING to eXULPopupHiding r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/decc683d234c431ffe003ccbbade26cf312563ff
changeset:  decc683d234c431ffe003ccbbade26cf312563ff
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 04 19:54:11 2015 +0900
description:
Bug 895274 part.90 Rename NS_XUL_POPUP_HIDDEN to eXULPopupHidden r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/8f9d85e978cac16a296c52cc1dd050e2fbdc3f86
changeset:  8f9d85e978cac16a296c52cc1dd050e2fbdc3f86
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 04 19:54:12 2015 +0900
description:
Bug 895274 part.91 Rename NS_XUL_BROADCAST to eXULBroadcast r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/7fd80515c0fecca6849e56ca1e392df06e8f0c7f
changeset:  7fd80515c0fecca6849e56ca1e392df06e8f0c7f
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 04 19:54:12 2015 +0900
description:
Bug 895274 part.92 Rename NS_XUL_COMMAND_UPDATE to eXULCommandUpdate r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/25c5f2f3ee8a1e011d985921bb2f4d60595892f4
changeset:  25c5f2f3ee8a1e011d985921bb2f4d60595892f4
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 04 19:54:12 2015 +0900
description:
Bug 895274 part.93 Rename NS_XULCOMMAND_EVENT_START to eXULCommandEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/0720ec8893664f4dd3a48f56f0b92e99ed3a4fdb
changeset:  0720ec8893664f4dd3a48f56f0b92e99ed3a4fdb
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 04 19:54:12 2015 +0900
description:
Bug 895274 part.94 Rename NS_XUL_COMMAND to eXULCommand r=smaug

Comment 170

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e109ec7a6df6
https://hg.mozilla.org/mozilla-central/rev/c24765571791
https://hg.mozilla.org/mozilla-central/rev/97e0ba98dd52
https://hg.mozilla.org/mozilla-central/rev/7a48f1bb8b42
https://hg.mozilla.org/mozilla-central/rev/decc683d234c
https://hg.mozilla.org/mozilla-central/rev/8f9d85e978ca
https://hg.mozilla.org/mozilla-central/rev/7fd80515c0fe
https://hg.mozilla.org/mozilla-central/rev/25c5f2f3ee8a
https://hg.mozilla.org/mozilla-central/rev/0720ec889366

Comment 171

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.95 Rename NS_MUTATION_NODEINSERTEDINTODOCUMENT to eLegacyNodeInsertedIntoDocument

I think that mutation events should have "legacy" keyword.

Comment 172

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.96 Rename NS_MUTATION_START to eLegacyMutationEventFirst

Comment 173

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.97 Rename NS_MUTATION_NODEREMOVEDFROMDOCUMENT to eLegacyNodeRemovedFromDocument

Comment 174

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.98 Rename NS_MUTATION_CHARACTERDATAMODIFIED to eLegacyCharacterDataModified

Comment 175

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.99 Rename NS_MUTATION_SUBTREEMODIFIED to eLegacySubtreeModified

Comment 176

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.100 Rename NS_MUTATION_NODEINSERTED to eLegacyNodeInserted

Comment 177

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.101 Rename NS_MUTATION_NODEREMOVED to eLegacyNodeRemoved

Comment 178

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.102 Rename NS_MUTATION_ATTRMODIFIED to eLegacyAttrModified

Comment 179

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.103 Rename NS_MUTATION_END to eLegacyMutationEventLast

Comment 180

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab2f2d00b7f9

Comment 181

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8657744 [details] [diff] [review]
part.95 Rename NS_MUTATION_NODEINSERTEDINTODOCUMENT to eLegacyNodeInsertedIntoDocument

(we should just get rid of this event message at some point)

Comment 182

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.104 Rename NS_PAGETRANSITION_START to ePageTransitionEventFirst

Comment 183

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.105 Rename NS_PAGE_SHOW to ePageShow

Comment 184

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.106 Rename NS_PAGE_HIDE to ePageHide

Comment 185

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.107 Get rid of NS_SVG_ABORT and NS_SVG_ERROR due to unused

Hmm, they are defined in the spec, but we don't register them in EventNameList.h.

Comment 186

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.108 Rename NS_SVG_EVENT_START to eSVGEventFirst

Comment 187

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.109 Rename NS_SVG_LOAD to eSVGLoad

Comment 188

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.110 Rename NS_SVG_UNLOAD to eSVGUnload

A lot of SVG events are only registered in EventNameList.h. We don't fire the events? Or do we have a way to fire the simple events without creating Widget*Event in the stack?

Comment 189

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.111 Rename NS_SVG_RESIZE to eSVGResize

Comment 190

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.112 Rename NS_SVG_SCROLL to eSVGScroll

Comment 191

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.113 Rename NS_SVGZOOM_EVENT_START to eSVGZoomEventFirst

Comment 192

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.114 Rename NS_SVG_ZOOM to eSVGZoom

Comment 193

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/460f5affc668d32c3227aca44a0b55e761dec6eb
changeset:  460f5affc668d32c3227aca44a0b55e761dec6eb
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:50 2015 +0900
description:
Bug 895274 part.95 Rename NS_MUTATION_NODEINSERTEDINTODOCUMENT to eLegacyNodeInsertedIntoDocument r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/53fbc3307221c5635d3a6c23631c0380645c203f
changeset:  53fbc3307221c5635d3a6c23631c0380645c203f
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:50 2015 +0900
description:
Bug 895274 part.96 Rename NS_MUTATION_START to eLegacyMutationEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/2f8c25b844e6acc92d446b6b0576f31f1efb0e8b
changeset:  2f8c25b844e6acc92d446b6b0576f31f1efb0e8b
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:50 2015 +0900
description:
Bug 895274 part.97 Rename NS_MUTATION_NODEREMOVEDFROMDOCUMENT to eLegacyNodeRemovedFromDocument r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/79e293defe0fa1211255c62cf5cada0cbcd27e5f
changeset:  79e293defe0fa1211255c62cf5cada0cbcd27e5f
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:50 2015 +0900
description:
Bug 895274 part.98 Rename NS_MUTATION_CHARACTERDATAMODIFIED to eLegacyCharacterDataModified r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/f6f918d677aabe854314d81d65d02d07216dddae
changeset:  f6f918d677aabe854314d81d65d02d07216dddae
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:51 2015 +0900
description:
Bug 895274 part.99 Rename NS_MUTATION_SUBTREEMODIFIED to eLegacySubtreeModified r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/d643e9bbecbcc0e9a71752e6bb24c90572872b73
changeset:  d643e9bbecbcc0e9a71752e6bb24c90572872b73
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:51 2015 +0900
description:
Bug 895274 part.100 Rename NS_MUTATION_NODEINSERTED to eLegacyNodeInserted r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/50a074c6f1e11e0ec19205f97f138927119de8dd
changeset:  50a074c6f1e11e0ec19205f97f138927119de8dd
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:51 2015 +0900
description:
Bug 895274 part.101 Rename NS_MUTATION_NODEREMOVED to eLegacyNodeRemoved r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/ec25eda8de151b000251faa14b478822dade1d93
changeset:  ec25eda8de151b000251faa14b478822dade1d93
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:51 2015 +0900
description:
Bug 895274 part.102 Rename NS_MUTATION_ATTRMODIFIED to eLegacyAttrModified r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/82aa99137da495953561777280da9d4e41554776
changeset:  82aa99137da495953561777280da9d4e41554776
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:51 2015 +0900
description:
Bug 895274 part.103 Rename NS_MUTATION_END to eLegacyMutationEventLast r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/ca2ed2eb12c063168835797e989d8a2bab39fe04
changeset:  ca2ed2eb12c063168835797e989d8a2bab39fe04
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:51 2015 +0900
description:
Bug 895274 part.104 Rename NS_PAGETRANSITION_START to ePageTransitionEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/396816b81be5c18f02691205e5babf70b35927d8
changeset:  396816b81be5c18f02691205e5babf70b35927d8
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:51 2015 +0900
description:
Bug 895274 part.105 Rename NS_PAGE_SHOW to ePageShow r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/182b27c4a45848afe761e7e2e8091abeb771be3e
changeset:  182b27c4a45848afe761e7e2e8091abeb771be3e
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:51 2015 +0900
description:
Bug 895274 part.106 Rename NS_PAGE_HIDE to ePageHide r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/573aca3165b2f6c7f2f168cc37c8b42198d6b422
changeset:  573aca3165b2f6c7f2f168cc37c8b42198d6b422
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:51 2015 +0900
description:
Bug 895274 part.107 Get rid of NS_SVG_ABORT and NS_SVG_ERROR due to unused r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/9472b6dbaf255c9116f6d4b37e932dac76c6f909
changeset:  9472b6dbaf255c9116f6d4b37e932dac76c6f909
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:51 2015 +0900
description:
Bug 895274 part.108 Rename NS_SVG_EVENT_START to eSVGEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/080f2acf959d6ae5a56db596ee0f69dbc94915cc
changeset:  080f2acf959d6ae5a56db596ee0f69dbc94915cc
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:51 2015 +0900
description:
Bug 895274 part.109 Rename NS_SVG_LOAD to eSVGLoad r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/549e7a38a199f096d2ca313e3417226dc92f7d9b
changeset:  549e7a38a199f096d2ca313e3417226dc92f7d9b
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:51 2015 +0900
description:
Bug 895274 part.110 Rename NS_SVG_UNLOAD to eSVGUnload r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/b33b114ec6d4d8e6b9c4557f45d50efe130d0f8d
changeset:  b33b114ec6d4d8e6b9c4557f45d50efe130d0f8d
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:52 2015 +0900
description:
Bug 895274 part.111 Rename NS_SVG_RESIZE to eSVGResize r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/9b40d2b9c5f1bb0b6ce536ebf56d7a2d9b9206fe
changeset:  9b40d2b9c5f1bb0b6ce536ebf56d7a2d9b9206fe
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:52 2015 +0900
description:
Bug 895274 part.112 Rename NS_SVG_SCROLL to eSVGScroll r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/92668c18d13158c4bc2d6e07a218dc556ea994f6
changeset:  92668c18d13158c4bc2d6e07a218dc556ea994f6
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:52 2015 +0900
description:
Bug 895274 part.113 Rename NS_SVGZOOM_EVENT_START to eSVGZoomEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/3f2f4df587af31ad56641e067e1864ad57c61d10
changeset:  3f2f4df587af31ad56641e067e1864ad57c61d10
user:       Masayuki Nakano <[e-mail]>
date:       Mon Sep 07 23:55:52 2015 +0900
description:
Bug 895274 part.114 Rename NS_SVG_ZOOM to eSVGZoom r=smaug

Comment 194

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.115 Rename NS_CUTCOPYPASTE_EVENT to eClipboardEventFirst

Comment 195

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.116 Rename NS_COPY to eCopy

Comment 196

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.117 Rename NS_CUT to eCut

Comment 197

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.118 Rename NS_PASTE to ePaste

Comment 198

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.119 Get rid of NS_NEED_KEY due to unused

Comment 199

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.120 Rename NS_MEDIA_EVENT_START to eMeditaEventFirst

Comment 200

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.121 Rename NS_LOADSTART to eLoadStart

Comment 201

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.122 Rename NS_PROGRESS to eProgress

Comment 202

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.123 Rename NS_SUSPEND to eSuspend

Comment 203

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.124 Rename NS_EMPTIED to eEmptied

Comment 204

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.125 Rename NS_STALED to eStalled

Comment 205

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.126 Rename NS_PLAY to ePlay

Comment 206

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.127 Rename NS_PAUSE to ePause

Comment 207

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.128 Rename NS_LOADEDMETADATA to eLoadedMetaData

Comment 208

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.129 Rename NS_LOADEDDATA to eLoadedData

Comment 209

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.130 Rename NS_WAITING to eWaiting

Comment 210

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.131 Rename NS_PLAYING to ePlaying

Comment 211

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.132 Rename NS_CANPLAY to eCanPlay

Comment 212

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.133 Rename NS_CANPLAYTHROUGH to eCanPlayThrough

Comment 213

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.134 Rename NS_SEEKING to eSeeking

Comment 214

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.135 Rename NS_SEEKED to eSeeked

Comment 215

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.136 Rename NS_TIMEUPDATE to eTimeUpdate

Comment 216

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.137 Rename NS_ENDED to eEnded

Comment 217

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.138 Rename NS_RATECHANGE to eRateChange

Comment 218

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.139 Rename NS_DURATIONCHANGE to eDurationChange

Comment 219

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.140 Rename NS_VOLUMECHANGE to eVolumeChange

Comment 220

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.141 Get rid of NS_PLUGIN_FOCUS_EVENT due to unused

Comment 221

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.142 Rename NS_PLUGIN_EVENT_START to ePluginEventFirst

Comment 222

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.143 Rename NS_PLUGIN_INPUT_EVENT to ePluginInputEvent

Comment 223

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.144 Rename NS_SELECTION_EVENT_START to eSelectionEventFirst

Comment 224

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.145 Rename NS_SELECTION_SET to eSetSelection

Comment 225

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8658065 [details] [diff] [review]
part.145 Rename NS_SELECTION_SET to eSetSelection

Ah, this is about setSelection, not selectionSet

Comment 226

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/460f5affc668
https://hg.mozilla.org/mozilla-central/rev/53fbc3307221
https://hg.mozilla.org/mozilla-central/rev/2f8c25b844e6
https://hg.mozilla.org/mozilla-central/rev/79e293defe0f
https://hg.mozilla.org/mozilla-central/rev/f6f918d677aa
https://hg.mozilla.org/mozilla-central/rev/d643e9bbecbc
https://hg.mozilla.org/mozilla-central/rev/50a074c6f1e1
https://hg.mozilla.org/mozilla-central/rev/ec25eda8de15
https://hg.mozilla.org/mozilla-central/rev/82aa99137da4
https://hg.mozilla.org/mozilla-central/rev/ca2ed2eb12c0
https://hg.mozilla.org/mozilla-central/rev/396816b81be5
https://hg.mozilla.org/mozilla-central/rev/182b27c4a458
https://hg.mozilla.org/mozilla-central/rev/573aca3165b2
https://hg.mozilla.org/mozilla-central/rev/9472b6dbaf25
https://hg.mozilla.org/mozilla-central/rev/080f2acf959d
https://hg.mozilla.org/mozilla-central/rev/549e7a38a199
https://hg.mozilla.org/mozilla-central/rev/b33b114ec6d4
https://hg.mozilla.org/mozilla-central/rev/9b40d2b9c5f1
https://hg.mozilla.org/mozilla-central/rev/92668c18d131
https://hg.mozilla.org/mozilla-central/rev/3f2f4df587af

Comment 227

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/cc988d9676a400f8a7cb0596e2738daf1f845bfc
changeset:  cc988d9676a400f8a7cb0596e2738daf1f845bfc
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:34 2015 +0900
description:
Bug 895274 part.115 Rename NS_CUTCOPYPASTE_EVENT to eClipboardEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/e248269468d485ddf48fe63e5e3ee955c74c03e0
changeset:  e248269468d485ddf48fe63e5e3ee955c74c03e0
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:34 2015 +0900
description:
Bug 895274 part.116 Rename NS_COPY to eCopy r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/a25fc31cd465e517a19870f311e7bfe733cae19a
changeset:  a25fc31cd465e517a19870f311e7bfe733cae19a
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:35 2015 +0900
description:
Bug 895274 part.117 Rename NS_CUT to eCut r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/2f15d2b271c76a22c8cb3a8696ded760caa23732
changeset:  2f15d2b271c76a22c8cb3a8696ded760caa23732
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:35 2015 +0900
description:
Bug 895274 part.118 Rename NS_PASTE to ePaste r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/096cf51d192007b304f27e8e8ceb6a1c3117371b
changeset:  096cf51d192007b304f27e8e8ceb6a1c3117371b
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:35 2015 +0900
description:
Bug 895274 part.119 Get rid of NS_NEED_KEY due to unused r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/8d2cc2f0fa0658bd285c8b3d582e98d906e3384b
changeset:  8d2cc2f0fa0658bd285c8b3d582e98d906e3384b
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:35 2015 +0900
description:
Bug 895274 part.120 Rename NS_MEDIA_EVENT_START to eMeditaEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/3ff229821a764ed555c8b66ffb1c2ba54055922b
changeset:  3ff229821a764ed555c8b66ffb1c2ba54055922b
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:35 2015 +0900
description:
Bug 895274 part.121 Rename NS_LOADSTART to eLoadStart r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/3f98fcec61b98041873521620a7232219339f46b
changeset:  3f98fcec61b98041873521620a7232219339f46b
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:35 2015 +0900
description:
Bug 895274 part.122 Rename NS_PROGRESS to eProgress r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/c510ffab1014c17f3173a3e9efcf15ba372265b3
changeset:  c510ffab1014c17f3173a3e9efcf15ba372265b3
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:35 2015 +0900
description:
Bug 895274 part.123 Rename NS_SUSPEND to eSuspend r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/94d303f30c15e9fa9c13cbc2a7cbfb58e70ace3d
changeset:  94d303f30c15e9fa9c13cbc2a7cbfb58e70ace3d
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:35 2015 +0900
description:
Bug 895274 part.124 Rename NS_EMPTIED to eEmptied r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/e208587b46fe983109ea1b82fe4f0bcd522f4ab1
changeset:  e208587b46fe983109ea1b82fe4f0bcd522f4ab1
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:36 2015 +0900
description:
Bug 895274 part.125 Rename NS_STALED to eStalled r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/7ce3a3e55500afaf19147e667735b8ea12f5af9e
changeset:  7ce3a3e55500afaf19147e667735b8ea12f5af9e
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:36 2015 +0900
description:
Bug 895274 part.126 Rename NS_PLAY to ePlay r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/7345eb48f962707973447323a729cc44d67365b0
changeset:  7345eb48f962707973447323a729cc44d67365b0
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:36 2015 +0900
description:
Bug 895274 part.127 Rename NS_PAUSE to ePause r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/1f6ce21b418e097d91d5e01662cf55979caf5f9a
changeset:  1f6ce21b418e097d91d5e01662cf55979caf5f9a
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:36 2015 +0900
description:
Bug 895274 part.128 Rename NS_LOADEDMETADATA to eLoadedMetaData r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/b33ca0b66d59dbd9e018d1e8b76745235b8750a0
changeset:  b33ca0b66d59dbd9e018d1e8b76745235b8750a0
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:36 2015 +0900
description:
Bug 895274 part.129 Rename NS_LOADEDDATA to eLoadedData r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/301e51d22aff888f330584974367ddae78cdb30b
changeset:  301e51d22aff888f330584974367ddae78cdb30b
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:36 2015 +0900
description:
Bug 895274 part.130 Rename NS_WAITING to eWaiting r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/834502fe7f2f948a4e8887f19bc809ebe6c7fa9b
changeset:  834502fe7f2f948a4e8887f19bc809ebe6c7fa9b
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:36 2015 +0900
description:
Bug 895274 part.131 Rename NS_PLAYING to ePlaying r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/b96778df945a73ac46c25870525e4e8889d1dae2
changeset:  b96778df945a73ac46c25870525e4e8889d1dae2
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:36 2015 +0900
description:
Bug 895274 part.132 Rename NS_CANPLAY to eCanPlay r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/78245a0ea853f873e33cd80644187aa0a9888878
changeset:  78245a0ea853f873e33cd80644187aa0a9888878
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:36 2015 +0900
description:
Bug 895274 part.133 Rename NS_CANPLAYTHROUGH to eCanPlayThrough r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/d80ad0e1eb053db6644d7dfa149eedc9cceaafde
changeset:  d80ad0e1eb053db6644d7dfa149eedc9cceaafde
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:37 2015 +0900
description:
Bug 895274 part.134 Rename NS_SEEKING to eSeeking r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/f08ab30607efb9257ccd5b12cd01606b8dd7c8c5
changeset:  f08ab30607efb9257ccd5b12cd01606b8dd7c8c5
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:37 2015 +0900
description:
Bug 895274 part.135 Rename NS_SEEKED to eSeeked r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/da9a63509cdc2555c4ff1c4f138feca1ee622086
changeset:  da9a63509cdc2555c4ff1c4f138feca1ee622086
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:37 2015 +0900
description:
Bug 895274 part.136 Rename NS_TIMEUPDATE to eTimeUpdate r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/7dfa381f18367183202ea12363562b10f0a451ff
changeset:  7dfa381f18367183202ea12363562b10f0a451ff
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:37 2015 +0900
description:
Bug 895274 part.137 Rename NS_ENDED to eEnded r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/9127d9bfb36a836198b9a78b433137214aa94549
changeset:  9127d9bfb36a836198b9a78b433137214aa94549
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:37 2015 +0900
description:
Bug 895274 part.138 Rename NS_RATECHANGE to eRateChange r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/1537722345b068ef919ee13cf545be233b4647e7
changeset:  1537722345b068ef919ee13cf545be233b4647e7
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:37 2015 +0900
description:
Bug 895274 part.139 Rename NS_DURATIONCHANGE to eDurationChange r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/a501c28cb98bccdb0a1b379a368e35278ffe0325
changeset:  a501c28cb98bccdb0a1b379a368e35278ffe0325
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:37 2015 +0900
description:
Bug 895274 part.140 Rename NS_VOLUMECHANGE to eVolumeChange r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/25e2d9a9d1f7e4fbc59dc7864aa91b13fd7499e3
changeset:  25e2d9a9d1f7e4fbc59dc7864aa91b13fd7499e3
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:37 2015 +0900
description:
Bug 895274 part.141 Get rid of NS_PLUGIN_FOCUS_EVENT due to unused r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/02d003c047ea5f9c0bd09cf36fe206d020b5949e
changeset:  02d003c047ea5f9c0bd09cf36fe206d020b5949e
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:38 2015 +0900
description:
Bug 895274 part.142 Rename NS_PLUGIN_EVENT_START to ePluginEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/8851fdf3cae405a9bf578898724454537a59a71d
changeset:  8851fdf3cae405a9bf578898724454537a59a71d
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:38 2015 +0900
description:
Bug 895274 part.143 Rename NS_PLUGIN_INPUT_EVENT to ePluginInputEvent r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/a6a0afa7ed7617c487c4c9d94ce7b9ddfd57fb3d
changeset:  a6a0afa7ed7617c487c4c9d94ce7b9ddfd57fb3d
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:38 2015 +0900
description:
Bug 895274 part.144 Rename NS_SELECTION_EVENT_START to eSelectionEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/59783997dbd58d4e46a819e544bf94bf42e1c93f
changeset:  59783997dbd58d4e46a819e544bf94bf42e1c93f
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 08 23:33:38 2015 +0900
description:
Bug 895274 part.145 Rename NS_SELECTION_SET to eSetSelection r=smaug

Comment 228

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cbeb0f2be84d

Comment 229

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/cc988d9676a4
https://hg.mozilla.org/mozilla-central/rev/e248269468d4
https://hg.mozilla.org/mozilla-central/rev/a25fc31cd465
https://hg.mozilla.org/mozilla-central/rev/2f15d2b271c7
https://hg.mozilla.org/mozilla-central/rev/096cf51d1920
https://hg.mozilla.org/mozilla-central/rev/8d2cc2f0fa06
https://hg.mozilla.org/mozilla-central/rev/3ff229821a76
https://hg.mozilla.org/mozilla-central/rev/3f98fcec61b9
https://hg.mozilla.org/mozilla-central/rev/c510ffab1014
https://hg.mozilla.org/mozilla-central/rev/94d303f30c15
https://hg.mozilla.org/mozilla-central/rev/e208587b46fe
https://hg.mozilla.org/mozilla-central/rev/7ce3a3e55500
https://hg.mozilla.org/mozilla-central/rev/7345eb48f962
https://hg.mozilla.org/mozilla-central/rev/1f6ce21b418e
https://hg.mozilla.org/mozilla-central/rev/b33ca0b66d59
https://hg.mozilla.org/mozilla-central/rev/301e51d22aff
https://hg.mozilla.org/mozilla-central/rev/834502fe7f2f
https://hg.mozilla.org/mozilla-central/rev/b96778df945a
https://hg.mozilla.org/mozilla-central/rev/78245a0ea853
https://hg.mozilla.org/mozilla-central/rev/d80ad0e1eb05
https://hg.mozilla.org/mozilla-central/rev/f08ab30607ef
https://hg.mozilla.org/mozilla-central/rev/da9a63509cdc
https://hg.mozilla.org/mozilla-central/rev/7dfa381f1836
https://hg.mozilla.org/mozilla-central/rev/9127d9bfb36a
https://hg.mozilla.org/mozilla-central/rev/1537722345b0
https://hg.mozilla.org/mozilla-central/rev/a501c28cb98b
https://hg.mozilla.org/mozilla-central/rev/25e2d9a9d1f7
https://hg.mozilla.org/mozilla-central/rev/02d003c047ea
https://hg.mozilla.org/mozilla-central/rev/8851fdf3cae4
https://hg.mozilla.org/mozilla-central/rev/a6a0afa7ed76
https://hg.mozilla.org/mozilla-central/rev/59783997dbd5

Comment 230

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=efcbac6d4358

Comment 231

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.146 Rename NS_MOUSE_SCROLL_START to eLegacyMouseScrollEventFirst

"Legacy" should be included.

Comment 232

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.147 Rename NS_MOUSE_SCROLL to eLegacyMouseLineOrPageScroll

The new name, eLegacyMouseLineOrPageScroll, should be clearer what the event represents. "LineOrPage" is same as "WidgetWheelEvent::mLineOrPageDelta(X|Y)".

Comment 233

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.148 Rename NS_MOUSE_PIXEL_SCROLL to eLegacyMousePixelScroll

Comment 234

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.149 Rename NS_USER_DEFINED_EVENT to eUnidentifiedEvent

According to KeyboardEvent.key, "unidentified" is better word for DOM Events. I don't like "user defined" due to unclear what it means.

Comment 235

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.150 Rename NS_QUERY_CONTENT_EVENT_START to eQueryContentEventFirst

Comment 236

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.151 Rename NS_QUERY_SELECTION_AS_TRANSFERABLE to eQuerySelectionAsTransferable

Comment 237

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.152 Rename NS_QUERY_SELECTED_TEXT to eQuerySelectedText

Comment 238

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.153 Rename NS_QUERY_TEXT_CONTENT to eQueryTextContent

Comment 239

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.154 Rename NS_QUERY_CARET_RECT to eQueryCaretRect

Comment 240

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.155 Rename NS_QUERY_EDITOR_RECT to eQueryEditorRect

Comment 241

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.156 Rename NS_QUERY_CONTENT_STATE to eQueryContentState

Comment 242

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.157 Rename NS_QUERY_CHARACTER_AT_POINT to eQueryCharacterAtPoint

Comment 243

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.158 Rename NS_QUERY_DOM_WIDGET_HITTEST to eQueryDOMWidgetHittest

Comment 244

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.159 Rename NS_NOTIFYPAINT_START to ePaintEventFirst

Comment 245

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.160 Rename NS_AFTERPAINT to eAfterPaint

Comment 246

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8658725 [details] [diff] [review]
part.148 Rename NS_MOUSE_PIXEL_SCROLL to eLegacyMousePixelScroll

s/eLegacyMousePiexelScroll/eLegacyMousePixelScroll/
everywhere in the patch.
With that, r+

Comment 247

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8658728 [details] [diff] [review]
part.149 Rename NS_USER_DEFINED_EVENT to eUnidentifiedEvent

I guess I can live with eUnidentifiedEvent.

Comment 248

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8658731 [details] [diff] [review]
part.152 Rename NS_QUERY_SELECTED_TEXT to eQuerySelectedText

> nsQueryContentEventResult::GetSucceeded(bool *aSucceeded)
> {
>-  NS_ENSURE_TRUE(mEventID != 0, NS_ERROR_NOT_INITIALIZED);
>+  NS_ENSURE_TRUE(mEventMessage != 0, NS_ERROR_NOT_INITIALIZED);
Don't you want to compare to eVoidEvent here.

Comment 249

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

(In reply to Olli Pettay [:smaug] from comment #246)
> Comment on attachment 8658725 [details] [diff] [review]
> part.148 Rename NS_MOUSE_PIXEL_SCROLL to eLegacyMousePixelScroll
> 
> s/eLegacyMousePiexelScroll/eLegacyMousePixelScroll/
> everywhere in the patch.
> With that, r+

Oops!

(In reply to Olli Pettay [:smaug] from comment #248)
> Comment on attachment 8658731 [details] [diff] [review]
> part.152 Rename NS_QUERY_SELECTED_TEXT to eQuerySelectedText
> 
> > nsQueryContentEventResult::GetSucceeded(bool *aSucceeded)
> > {
> >-  NS_ENSURE_TRUE(mEventID != 0, NS_ERROR_NOT_INITIALIZED);
> >+  NS_ENSURE_TRUE(mEventMessage != 0, NS_ERROR_NOT_INITIALIZED);
> Don't you want to compare to eVoidEvent here.

Right. Thank you for finding the mistake!

Comment 250

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8658738 [details] [diff] [review]
part.158 Rename NS_QUERY_DOM_WIDGET_HITTEST to eQueryDOMWidgetHittest

Not about this bug or patch, but I noticed
return "Unsupprted message"; 

Should be
return "Unsupported message";

Comment 251

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/6e4fc82f286ba247a31c7e9160aa73668e4efa36
changeset:  6e4fc82f286ba247a31c7e9160aa73668e4efa36
user:       Masayuki Nakano <[e-mail]>
date:       Thu Sep 10 10:40:04 2015 +0900
description:
Bug 895274 part.146 Rename NS_MOUSE_SCROLL_START to eLegacyMouseScrollEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/c46079d8b6ed24f7533f1844873b8f18bdffc13c
changeset:  c46079d8b6ed24f7533f1844873b8f18bdffc13c
user:       Masayuki Nakano <[e-mail]>
date:       Thu Sep 10 10:40:04 2015 +0900
description:
Bug 895274 part.147 Rename NS_MOUSE_SCROLL to eLegacyMouseLineOrPageScroll r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/7f6201ff997f763e3e6aff0689b742c043244a39
changeset:  7f6201ff997f763e3e6aff0689b742c043244a39
user:       Masayuki Nakano <[e-mail]>
date:       Thu Sep 10 10:40:04 2015 +0900
description:
Bug 895274 part.148 Rename NS_MOUSE_PIXEL_SCROLL to eLegacyMousePixelScroll r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/4cdae41b9305f75ac82226a52f860ecd512c547c
changeset:  4cdae41b9305f75ac82226a52f860ecd512c547c
user:       Masayuki Nakano <[e-mail]>
date:       Thu Sep 10 10:40:04 2015 +0900
description:
Bug 895274 part.149 Rename NS_USER_DEFINED_EVENT to eUnidentifiedEvent r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/4557cfecc20d65bc48fe43b6460038473fd4ed7d
changeset:  4557cfecc20d65bc48fe43b6460038473fd4ed7d
user:       Masayuki Nakano <[e-mail]>
date:       Thu Sep 10 10:40:05 2015 +0900
description:
Bug 895274 part.150 Rename NS_QUERY_CONTENT_EVENT_START to eQueryContentEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/aaf1002beb949b424841d3fef3c731b25820f600
changeset:  aaf1002beb949b424841d3fef3c731b25820f600
user:       Masayuki Nakano <[e-mail]>
date:       Thu Sep 10 10:40:05 2015 +0900
description:
Bug 895274 part.151 Rename NS_QUERY_SELECTION_AS_TRANSFERABLE to eQuerySelectionAsTransferable r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/ec614033e8225b089920f84d43d5930a2bef93c9
changeset:  ec614033e8225b089920f84d43d5930a2bef93c9
user:       Masayuki Nakano <[e-mail]>
date:       Thu Sep 10 10:40:05 2015 +0900
description:
Bug 895274 part.152 Rename NS_QUERY_SELECTED_TEXT to eQuerySelectedText r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/25399075c9efe898cb2b2f137e4affeace30cd47
changeset:  25399075c9efe898cb2b2f137e4affeace30cd47
user:       Masayuki Nakano <[e-mail]>
date:       Thu Sep 10 10:40:05 2015 +0900
description:
Bug 895274 part.153 Rename NS_QUERY_TEXT_CONTENT to eQueryTextContent r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/1a346d89cc2358675297e2014aa1e56146e71ae0
changeset:  1a346d89cc2358675297e2014aa1e56146e71ae0
user:       Masayuki Nakano <[e-mail]>
date:       Thu Sep 10 10:40:06 2015 +0900
description:
Bug 895274 part.154 Rename NS_QUERY_CARET_RECT to eQueryCaretRect r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/a5c0e8cbf6073fe223f50ce2d8056678f69c88d5
changeset:  a5c0e8cbf6073fe223f50ce2d8056678f69c88d5
user:       Masayuki Nakano <[e-mail]>
date:       Thu Sep 10 10:40:06 2015 +0900
description:
Bug 895274 part.155 Rename NS_QUERY_EDITOR_RECT to eQueryEditorRect r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/03965478482802c244ba8212177324cb7516d958
changeset:  03965478482802c244ba8212177324cb7516d958
user:       Masayuki Nakano <[e-mail]>
date:       Thu Sep 10 10:40:06 2015 +0900
description:
Bug 895274 part.156 Rename NS_QUERY_CONTENT_STATE to eQueryContentState r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/2f4d6b2be0e628997a242f62b3fa93711333fba2
changeset:  2f4d6b2be0e628997a242f62b3fa93711333fba2
user:       Masayuki Nakano <[e-mail]>
date:       Thu Sep 10 10:40:06 2015 +0900
description:
Bug 895274 part.157 Rename NS_QUERY_CHARACTER_AT_POINT to eQueryCharacterAtPoint r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/83512fe0f05403318cac6cdecf09e54bcd1077b8
changeset:  83512fe0f05403318cac6cdecf09e54bcd1077b8
user:       Masayuki Nakano <[e-mail]>
date:       Thu Sep 10 10:40:06 2015 +0900
description:
Bug 895274 part.158 Rename NS_QUERY_DOM_WIDGET_HITTEST to eQueryDOMWidgetHittest r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/260d7fa5913db2f8f305f70a1df2bab24808cbed
changeset:  260d7fa5913db2f8f305f70a1df2bab24808cbed
user:       Masayuki Nakano <[e-mail]>
date:       Thu Sep 10 10:40:06 2015 +0900
description:
Bug 895274 part.159 Rename NS_NOTIFYPAINT_START to ePaintEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/672a3f59ed55d59cf71dbfa2610f5d47adc8cf84
changeset:  672a3f59ed55d59cf71dbfa2610f5d47adc8cf84
user:       Masayuki Nakano <[e-mail]>
date:       Thu Sep 10 10:40:06 2015 +0900
description:
Bug 895274 part.160 Rename NS_AFTERPAINT to eAfterPaint r=smaug

Comment 252

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.161 Rename NS_CONTENT_COMMAND_EVENT_START to eContentCommandEventFirst

Comment 253

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.162 Rename NS_CONTENT_COMMAND_PASTE_TRANSFERABLE to eContentCommandPasteTransferable

Comment 254

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.163 Rename NS_CONTENT_COMMAND_CUT to eContentCommandCut

Comment 255

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.164 Rename NS_CONTENT_COMMAND_COPY to eContentCommandCopy

Comment 256

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.165 Rename NS_CONTENT_COMMAND_PASTE to eContentCommandPaste

Comment 257

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.166 Rename NS_CONTENT_COMMAND_DELETE to eContentCommandDelete

Comment 258

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.167 Rename NS_CONTENT_COMMAND_UNDO to eContentCommandUndo

Comment 259

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.168 Rename NS_CONTENT_COMMAND_REDO to eContentCommandRedo

Comment 260

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.169 Rename NS_CONTENT_COMMAND_SCROLL to eContentCommandScroll

Comment 261

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.170 Rename NS_ANIMATION_EVENT_START to eAnimationEventFirst

Comment 262

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.171 Rename NS_ANIMATION_START to eAnimationStart

Comment 263

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.172 Rename NS_ANIMATION_END to eAnimationEnd

Comment 264

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.173 Rename NS_ANIMATION_ITERATION to eAnimationIteration

Comment 265

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.174 Rename NS_NOTIFYSCRIPT_START to eScriptEventFirst

Comment 266

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.175 Rename NS_BEFORE_SCRIPT_EXECUTE to eBeforeScriptExecute

Comment 267

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.176 Rename NS_AFTER_SCRIPT_EXECUTE to eAfterScriptExecute

Comment 268

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.177 Rename NS_OPENCLOSE_EVENT_START to eOpenCloseEventFirst

The name may not be good since NS_CLOSE has never been used since it's defined... However, let's use this name for now. We should remove unnecessary first and last values when we stop specifying the value of each event message.

Comment 269

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.178 Rename NS_OPEN to eOpen

It seems that this name is too generic, but I don't have better idea.

Comment 270

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.179 Remove NS_CLOSE due to unused

Comment 271

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.180 Rename NS_FULL_SCREEN_EVENT_START to eFullscreenEventFirst

The spec uses "fullscreen", not "full screen". Therefore, I use "Fullscreen" in their names.

Comment 272

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.181 Rename NS_FULLSCREENCHANGE to eFullscreenChange

Comment 273

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.182 Rename NS_FULLSCREENERROR to eFullscreenError

Comment 274

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.183 Rename NS_WHEEL_EVENT_START to eWheelEventFirst

Comment 275

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.184 Rename NS_WHEEL_WHEEL to eWheel

Comment 276

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.185 Rename NS_WHEEL_START to eWheelOperationStart

This event is fired on Mac when user touches the trackpad with two fingers. This won't cause DOM events therefore, I added "Operation" into the name for making what's started clearer.

Comment 277

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.186 Rename NS_WHEEL_END to eWheelOperationEnd

Same. And "End" is better word for event staff (e.g., compositionend).

Comment 278

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=cfe43986c005

Comment 279

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/e59cc10fc94562a1859fc86f61b3c16523045450
changeset:  e59cc10fc94562a1859fc86f61b3c16523045450
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:51 2015 +0900
description:
Bug 895274 part.161 Rename NS_CONTENT_COMMAND_EVENT_START to eContentCommandEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/667d75050a9411dba70607df4437cba134753501
changeset:  667d75050a9411dba70607df4437cba134753501
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:52 2015 +0900
description:
Bug 895274 part.162 Rename NS_CONTENT_COMMAND_PASTE_TRANSFERABLE to eContentCommandPasteTransferable r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/54ac42eda76f6f66400846dd5a32e92b827ff389
changeset:  54ac42eda76f6f66400846dd5a32e92b827ff389
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:52 2015 +0900
description:
Bug 895274 part.163 Rename NS_CONTENT_COMMAND_CUT to eContentCommandCut r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/1c4f895797d85ea7853977809150c656ac9d807b
changeset:  1c4f895797d85ea7853977809150c656ac9d807b
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:52 2015 +0900
description:
Bug 895274 part.164 Rename NS_CONTENT_COMMAND_COPY to eContentCommandCopy r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/4bc7de51bb6ef20f52ac77b6d58d3df281e9e8db
changeset:  4bc7de51bb6ef20f52ac77b6d58d3df281e9e8db
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:52 2015 +0900
description:
Bug 895274 part.165 Rename NS_CONTENT_COMMAND_PASTE to eContentCommandPaste r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/fc17970a9de262e7408326cfc5ce8f26b936bbfc
changeset:  fc17970a9de262e7408326cfc5ce8f26b936bbfc
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:52 2015 +0900
description:
Bug 895274 part.166 Rename NS_CONTENT_COMMAND_DELETE to eContentCommandDelete r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/5863be1170c9bffe100db5bc150cba567a4f97e7
changeset:  5863be1170c9bffe100db5bc150cba567a4f97e7
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:53 2015 +0900
description:
Bug 895274 part.167 Rename NS_CONTENT_COMMAND_UNDO to eContentCommandUndo r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/29bac9c0a25ab19f1d46e0304d262604c815c4e8
changeset:  29bac9c0a25ab19f1d46e0304d262604c815c4e8
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:53 2015 +0900
description:
Bug 895274 part.168 Rename NS_CONTENT_COMMAND_REDO to eContentCommandRedo r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/6942dd64d65e89cecab991e36c82d15e2d9c83e7
changeset:  6942dd64d65e89cecab991e36c82d15e2d9c83e7
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:53 2015 +0900
description:
Bug 895274 part.169 Rename NS_CONTENT_COMMAND_SCROLL to eContentCommandScroll r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/22c8416176741836ab71461d76102eb1944c0083
changeset:  22c8416176741836ab71461d76102eb1944c0083
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:53 2015 +0900
description:
Bug 895274 part.170 Rename NS_ANIMATION_EVENT_START to eAnimationEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/67254ef03f091f2ca85a22e6d796f734834e8766
changeset:  67254ef03f091f2ca85a22e6d796f734834e8766
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:53 2015 +0900
description:
Bug 895274 part.171 Rename NS_ANIMATION_START to eAnimationStart r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/af23abc48df4250a24f4f4c8bbc82a0e9cb2321f
changeset:  af23abc48df4250a24f4f4c8bbc82a0e9cb2321f
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:53 2015 +0900
description:
Bug 895274 part.172 Rename NS_ANIMATION_END to eAnimationEnd r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/d040b1903b432cc75f153c5ec9e7aa04bf9aaa86
changeset:  d040b1903b432cc75f153c5ec9e7aa04bf9aaa86
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:53 2015 +0900
description:
Bug 895274 part.173 Rename NS_ANIMATION_ITERATION to eAnimationIteration r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/96ec3affa3d526bf405cfb33172142415e757da9
changeset:  96ec3affa3d526bf405cfb33172142415e757da9
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:53 2015 +0900
description:
Bug 895274 part.174 Rename NS_NOTIFYSCRIPT_START to eScriptEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/5c2c1630198490f1a30a87070cfca75e3d24de0f
changeset:  5c2c1630198490f1a30a87070cfca75e3d24de0f
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:53 2015 +0900
description:
Bug 895274 part.175 Rename NS_BEFORE_SCRIPT_EXECUTE to eBeforeScriptExecute r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/3d7a664c70d720cdda6723782f883478f9209f59
changeset:  3d7a664c70d720cdda6723782f883478f9209f59
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:54 2015 +0900
description:
Bug 895274 part.176 Rename NS_AFTER_SCRIPT_EXECUTE to eAfterScriptExecute r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/ec706e1895448231322775bc3fc79dc90ef3e8df
changeset:  ec706e1895448231322775bc3fc79dc90ef3e8df
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:54 2015 +0900
description:
Bug 895274 part.177 Rename NS_OPENCLOSE_EVENT_START to eOpenCloseEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/df160a23a95d4bdc8bcd22de1f4c8b456389cec6
changeset:  df160a23a95d4bdc8bcd22de1f4c8b456389cec6
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:54 2015 +0900
description:
Bug 895274 part.178 Rename NS_OPEN to eOpen r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/bceba97d9bf2f51f08b3502d1adb4e9ae501528e
changeset:  bceba97d9bf2f51f08b3502d1adb4e9ae501528e
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:54 2015 +0900
description:
Bug 895274 part.179 Remove NS_CLOSE due to unused r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/0ab51b7d2653b3d67e34eb1c24b7f46ca55f2a3a
changeset:  0ab51b7d2653b3d67e34eb1c24b7f46ca55f2a3a
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:54 2015 +0900
description:
Bug 895274 part.180 Rename NS_FULL_SCREEN_EVENT_START to eFullscreenEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/04f1150a54fd90d8ef7d07b8d25d6d976da41753
changeset:  04f1150a54fd90d8ef7d07b8d25d6d976da41753
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:54 2015 +0900
description:
Bug 895274 part.181 Rename NS_FULLSCREENCHANGE to eFullscreenChange r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/967c1272d20ab2c52e96b7e038711689497782f8
changeset:  967c1272d20ab2c52e96b7e038711689497782f8
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:54 2015 +0900
description:
Bug 895274 part.182 Rename NS_FULLSCREENERROR to eFullscreenError r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/7a008c1909daacb25f473b4a46f39b73dd556659
changeset:  7a008c1909daacb25f473b4a46f39b73dd556659
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:54 2015 +0900
description:
Bug 895274 part.183 Rename NS_WHEEL_EVENT_START to eWheelEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/e777173540407236c2b24357c854920757748f74
changeset:  e777173540407236c2b24357c854920757748f74
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:54 2015 +0900
description:
Bug 895274 part.184 Rename NS_WHEEL_WHEEL to eWheel r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/dd0a5b24d93ccd9dcec8cea76127a564ff9eaf02
changeset:  dd0a5b24d93ccd9dcec8cea76127a564ff9eaf02
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:55 2015 +0900
description:
Bug 895274 part.185 Rename NS_WHEEL_START to eWheelOperationStart r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/0f99a111de0a20e77d6de0a688860f0107f4e755
changeset:  0f99a111de0a20e77d6de0a688860f0107f4e755
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 01:59:55 2015 +0900
description:
Bug 895274 part.186 Rename NS_WHEEL_END to eWheelOperationEnd r=smaug

Comment 280

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.187 Rename NS_QUERY_TEXT_RECT to eQueryTextRect

Hmm, I forgot to change this :-(

Comment 281

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.188 Rename NS_COMPOSITION_COMMIT_AS_IS to eCompositionCommitAsIs

Comment 282

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.189 Rename NS_COMPOSITION_EVENT_START to eCompositionEventFirst

Comment 283

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.190 Rename NS_COMPOSITION_START to eCompositionStart

Comment 284

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.191 Rename NS_COMPOSITION_END to eCompositionEnd

Comment 285

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.192 Rename NS_COMPOSITION_UPDATE to eCompositionUpdate

Comment 286

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.193 Rename NS_COMPOSITION_CHANGE to eCompositionChange

Comment 287

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.194 Rename NS_COMPOSITION_COMMIT to eCompositionCommit

Comment 288

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.195 Rename NS_SMIL_TIME_EVENT_START to eSMILEventFist

Comment 289

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.196 Rename NS_SMIL_BEGIN to eSMILBeginEvent

SMIL spec defines the events as beginEvent, endEvent and repeatEvent. The names don't have consistency with other DOM events, though. I guess that using these names might be better for SMIL implementer...

Comment 290

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.197 Rename NS_SMIL_END to eSMILEndEvent

Comment 291

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.198 Rename NS_SMIL_REPEAT to eSMILRepeatEvent

Comment 292

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.199 Rename NS_GAMEPAD_DISCONNECTED to eGamepadDisconnected

Comment 293

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.200 Rename NS_GAMEPAD_CONNECTED to eGamepadConnected

Comment 294

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.201 Rename NS_GAMEPAD_BUTTONDOWN to eGamepadButtonDown

Comment 295

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.202 Rename NS_GAMEPAD_BUTTONUP to eGamepadButtonUp

Comment 296

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.203 Rename NS_GAMEPAD_AXISMOVE to eGamepadAxisMove

Comment 297

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.204 Rename NS_GAMEPAD_START to eGamepadEventFirst

Comment 298

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.205 Rename NS_GAMEPAD_END to eGamepadEventLast

Comment 299

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=731b16869693

Comment 300

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8659668 [details] [diff] [review]
part.196 Rename NS_SMIL_BEGIN to eSMILBeginEvent

Yeah, SMIL and SVG events are nuts.

Comment 301

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/c8d53164ac16956a6443bfefc71eae50001453d5
changeset:  c8d53164ac16956a6443bfefc71eae50001453d5
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 21:21:26 2015 +0900
description:
Bug 895274 part.187 Rename NS_QUERY_TEXT_RECT to eQueryTextRect r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/6b29914363f3a7d104ec0d99c32e2b0abac0a8c9
changeset:  6b29914363f3a7d104ec0d99c32e2b0abac0a8c9
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 21:21:26 2015 +0900
description:
Bug 895274 part.188 Rename NS_COMPOSITION_COMMIT_AS_IS to eCompositionCommitAsIs r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/9e8b629344d1b4a51369a5b1cea45649bead14ba
changeset:  9e8b629344d1b4a51369a5b1cea45649bead14ba
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 21:21:26 2015 +0900
description:
Bug 895274 part.189 Rename NS_COMPOSITION_EVENT_START to eCompositionEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/094135c410a51de44a0080a904e01928021e3a3f
changeset:  094135c410a51de44a0080a904e01928021e3a3f
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 21:21:27 2015 +0900
description:
Bug 895274 part.190 Rename NS_COMPOSITION_START to eCompositionStart r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/e6420651e2c9ae7f21b03ac38c1424776c8f2179
changeset:  e6420651e2c9ae7f21b03ac38c1424776c8f2179
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 21:21:27 2015 +0900
description:
Bug 895274 part.191 Rename NS_COMPOSITION_END to eCompositionEnd r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/9f26179268e3b25496700f153b93365049dd2588
changeset:  9f26179268e3b25496700f153b93365049dd2588
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 21:21:27 2015 +0900
description:
Bug 895274 part.192 Rename NS_COMPOSITION_UPDATE to eCompositionUpdate r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/4802505f05ad9a02184bb5ffdd541057f51ebe28
changeset:  4802505f05ad9a02184bb5ffdd541057f51ebe28
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 21:21:27 2015 +0900
description:
Bug 895274 part.193 Rename NS_COMPOSITION_CHANGE to eCompositionChange r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/7cf9012735c6d2a6c7d814a33f1baa54af552c15
changeset:  7cf9012735c6d2a6c7d814a33f1baa54af552c15
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 21:21:27 2015 +0900
description:
Bug 895274 part.194 Rename NS_COMPOSITION_COMMIT to eCompositionCommit r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/07176b6eeedf1c0b4304a75795c0f1747b051365
changeset:  07176b6eeedf1c0b4304a75795c0f1747b051365
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 21:21:27 2015 +0900
description:
Bug 895274 part.195 Rename NS_SMIL_TIME_EVENT_START to eSMILEventFist r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/1ee79c909e1f3c3b49a1ad2345e75ce90adee31c
changeset:  1ee79c909e1f3c3b49a1ad2345e75ce90adee31c
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 21:21:27 2015 +0900
description:
Bug 895274 part.196 Rename NS_SMIL_BEGIN to eSMILBeginEvent r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/108cbd52aa7ecccf89aaaa23ec55a011fa7f9832
changeset:  108cbd52aa7ecccf89aaaa23ec55a011fa7f9832
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 21:21:27 2015 +0900
description:
Bug 895274 part.197 Rename NS_SMIL_END to eSMILEndEvent r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/9339cf2e33b38c6c4b50e8beff376fbd9a851a21
changeset:  9339cf2e33b38c6c4b50e8beff376fbd9a851a21
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 21:21:28 2015 +0900
description:
Bug 895274 part.198 Rename NS_SMIL_REPEAT to eSMILRepeatEvent r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/2fd2531aac12f0e334d6e1f0ab9501994c3529c3
changeset:  2fd2531aac12f0e334d6e1f0ab9501994c3529c3
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 21:21:28 2015 +0900
description:
Bug 895274 part.199 Rename NS_GAMEPAD_DISCONNECTED to eGamepadDisconnected r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/0cea2a2958ae8717491632e742059a4345f68398
changeset:  0cea2a2958ae8717491632e742059a4345f68398
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 21:21:28 2015 +0900
description:
Bug 895274 part.200 Rename NS_GAMEPAD_CONNECTED to eGamepadConnected r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/622806dd51c5660777de964847fadf5514827eea
changeset:  622806dd51c5660777de964847fadf5514827eea
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 21:21:28 2015 +0900
description:
Bug 895274 part.201 Rename NS_GAMEPAD_BUTTONDOWN to eGamepadButtonDown r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/4f954399289d7fca37fe5d466dcdc4e774ccbfde
changeset:  4f954399289d7fca37fe5d466dcdc4e774ccbfde
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 21:21:28 2015 +0900
description:
Bug 895274 part.202 Rename NS_GAMEPAD_BUTTONUP to eGamepadButtonUp r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/79473dc0e450ac3cfcb7ee139472d4a1e26ac067
changeset:  79473dc0e450ac3cfcb7ee139472d4a1e26ac067
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 21:21:28 2015 +0900
description:
Bug 895274 part.203 Rename NS_GAMEPAD_AXISMOVE to eGamepadAxisMove r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/848f9fe24f1cb34e3b933efd48c7bd2b435fd42e
changeset:  848f9fe24f1cb34e3b933efd48c7bd2b435fd42e
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 21:21:28 2015 +0900
description:
Bug 895274 part.204 Rename NS_GAMEPAD_START to eGamepadEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/f49b4cddbc850916b1d2ec85613c4a649d5eadae
changeset:  f49b4cddbc850916b1d2ec85613c4a649d5eadae
user:       Masayuki Nakano <[e-mail]>
date:       Fri Sep 11 21:21:28 2015 +0900
description:
Bug 895274 part.205 Rename NS_GAMEPAD_END to eGamepadEventLast r=smaug

Comment 302

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6e4fc82f286b
https://hg.mozilla.org/mozilla-central/rev/c46079d8b6ed
https://hg.mozilla.org/mozilla-central/rev/7f6201ff997f
https://hg.mozilla.org/mozilla-central/rev/4cdae41b9305
https://hg.mozilla.org/mozilla-central/rev/4557cfecc20d
https://hg.mozilla.org/mozilla-central/rev/aaf1002beb94
https://hg.mozilla.org/mozilla-central/rev/ec614033e822
https://hg.mozilla.org/mozilla-central/rev/25399075c9ef
https://hg.mozilla.org/mozilla-central/rev/1a346d89cc23
https://hg.mozilla.org/mozilla-central/rev/a5c0e8cbf607
https://hg.mozilla.org/mozilla-central/rev/039654784828
https://hg.mozilla.org/mozilla-central/rev/2f4d6b2be0e6
https://hg.mozilla.org/mozilla-central/rev/83512fe0f054
https://hg.mozilla.org/mozilla-central/rev/260d7fa5913d
https://hg.mozilla.org/mozilla-central/rev/672a3f59ed55
https://hg.mozilla.org/mozilla-central/rev/e59cc10fc945
https://hg.mozilla.org/mozilla-central/rev/667d75050a94
https://hg.mozilla.org/mozilla-central/rev/54ac42eda76f
https://hg.mozilla.org/mozilla-central/rev/1c4f895797d8
https://hg.mozilla.org/mozilla-central/rev/4bc7de51bb6e
https://hg.mozilla.org/mozilla-central/rev/fc17970a9de2
https://hg.mozilla.org/mozilla-central/rev/5863be1170c9
https://hg.mozilla.org/mozilla-central/rev/29bac9c0a25a
https://hg.mozilla.org/mozilla-central/rev/6942dd64d65e
https://hg.mozilla.org/mozilla-central/rev/22c841617674
https://hg.mozilla.org/mozilla-central/rev/67254ef03f09
https://hg.mozilla.org/mozilla-central/rev/af23abc48df4
https://hg.mozilla.org/mozilla-central/rev/d040b1903b43
https://hg.mozilla.org/mozilla-central/rev/96ec3affa3d5
https://hg.mozilla.org/mozilla-central/rev/5c2c16301984
https://hg.mozilla.org/mozilla-central/rev/3d7a664c70d7
https://hg.mozilla.org/mozilla-central/rev/ec706e189544
https://hg.mozilla.org/mozilla-central/rev/df160a23a95d
https://hg.mozilla.org/mozilla-central/rev/bceba97d9bf2
https://hg.mozilla.org/mozilla-central/rev/0ab51b7d2653
https://hg.mozilla.org/mozilla-central/rev/04f1150a54fd
https://hg.mozilla.org/mozilla-central/rev/967c1272d20a
https://hg.mozilla.org/mozilla-central/rev/7a008c1909da
https://hg.mozilla.org/mozilla-central/rev/e77717354040
https://hg.mozilla.org/mozilla-central/rev/dd0a5b24d93c
https://hg.mozilla.org/mozilla-central/rev/0f99a111de0a

Comment 303

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.206 Rename NS_MOZ_TIME_CHANGE_EVENT to eTimeChange

Comment 304

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.207 Rename NS_NETWORK_DOWNLOAD_EVENT to eNetworkDownload

Comment 305

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.208 Rename NS_NETWORK_UPLOAD_EVENT to eNetworkUpload

Comment 306

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.209 Rename NS_NETWORK_EVENT_START to eNetworkEventFirst

Comment 307

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.210 Rename NS_POINTERLOCK_START to ePointerLockEventFirst

Comment 308

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.211 Rename NS_POINTERLOCKCHANGE to ePointerLockChange

Comment 309

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.212 Rename NS_POINTERLOCKERROR to ePointerLockError

Comment 310

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.213 Rename NS_SCROLLPORT_OVERFLOW to eScrollPortOverflow

Comment 311

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.214 Rename NS_SCROLLPORT_UNDERFLOW to eScrollPortUnderflow

Comment 312

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.215 Rename NS_SCROLLPORT_START to eScrollPortEventFirst

Comment 313

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.216 Rename NS_SCROLLAREA_EVENT_START to eScrolledAreaEventFirst

According to the next event message, "scrolled area" is the right term, not "scroll area".

Comment 314

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.217 Rename NS_SCROLLEDAREACHANGE to eScrolledAreaChanged

scrolledareachange should be the DOM event name. But it's defined as "MozScrolledAreaChanged". So, we should keep using "changed" for this message.

Comment 315

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.218 Remove NS_ORIENTATION_EVENT due to unused

Comment 316

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.219 Rename NS_GESTURENOTIFY_EVENT_START to eGestureNotify

Comment 317

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.220 Rename NS_PRINT_EVENT_START to ePrintEventFirst r=smaug

Comment 318

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.221 Rename NS_BEFOREPRINT to eBeforePrint

Comment 319

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.222 Rename NS_AFTERPRINT to eAfterPrint

Although, the name is similar to eAfterPaint...

Comment 320

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.223 Rename NS_DEVICE_ORIENTATION_START to eDeviceEventFirst

Comment 321

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.224 Rename NS_DEVICE_ORIENTATION to eDeviceOrientation

Comment 322

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.225 Rename NS_DEVICE_MOTION to eDeviceMotion

Comment 323

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.226 Rename NS_DEVICE_PROXIMITY to eDeviceProximity

Comment 324

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.227 Rename NS_USER_PROXIMITY to eUserProximity

Comment 325

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.228 Rename NS_DEVICE_LIGHT to eDeviceLight

Probably, next set of the patches will be the last patches of this bug!

Comment 326

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4ac1ba0956eb
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d9975a1d6f6
https://hg.mozilla.org/integration/mozilla-inbound/rev/fa148ad38740
https://hg.mozilla.org/integration/mozilla-inbound/rev/9f1540b140e5
https://hg.mozilla.org/integration/mozilla-inbound/rev/6953adc7ca1a
https://hg.mozilla.org/integration/mozilla-inbound/rev/909e0d60f7c3
https://hg.mozilla.org/integration/mozilla-inbound/rev/e14ea6453892
https://hg.mozilla.org/integration/mozilla-inbound/rev/c59957d6ca04
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a17ec827f59
https://hg.mozilla.org/integration/mozilla-inbound/rev/cbf828cd48ae
https://hg.mozilla.org/integration/mozilla-inbound/rev/07c0e58b5f16
https://hg.mozilla.org/integration/mozilla-inbound/rev/62295fa19e50
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f368a13d9ed
https://hg.mozilla.org/integration/mozilla-inbound/rev/5e8f4f902562
https://hg.mozilla.org/integration/mozilla-inbound/rev/062647162efb
https://hg.mozilla.org/integration/mozilla-inbound/rev/9a88876e7fa5
https://hg.mozilla.org/integration/mozilla-inbound/rev/9e042218bfc0
https://hg.mozilla.org/integration/mozilla-inbound/rev/39fcfeae16fa
https://hg.mozilla.org/integration/mozilla-inbound/rev/7a662a29591b
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3a94d42ee8e
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef4b9a26ef43
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b13a7d48bc3
https://hg.mozilla.org/integration/mozilla-inbound/rev/28fe9b60f5d5

Comment 327

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/c8d53164ac16
https://hg.mozilla.org/mozilla-central/rev/6b29914363f3
https://hg.mozilla.org/mozilla-central/rev/9e8b629344d1
https://hg.mozilla.org/mozilla-central/rev/094135c410a5
https://hg.mozilla.org/mozilla-central/rev/e6420651e2c9
https://hg.mozilla.org/mozilla-central/rev/9f26179268e3
https://hg.mozilla.org/mozilla-central/rev/4802505f05ad
https://hg.mozilla.org/mozilla-central/rev/7cf9012735c6
https://hg.mozilla.org/mozilla-central/rev/07176b6eeedf
https://hg.mozilla.org/mozilla-central/rev/1ee79c909e1f
https://hg.mozilla.org/mozilla-central/rev/108cbd52aa7e
https://hg.mozilla.org/mozilla-central/rev/9339cf2e33b3
https://hg.mozilla.org/mozilla-central/rev/2fd2531aac12
https://hg.mozilla.org/mozilla-central/rev/0cea2a2958ae
https://hg.mozilla.org/mozilla-central/rev/622806dd51c5
https://hg.mozilla.org/mozilla-central/rev/4f954399289d
https://hg.mozilla.org/mozilla-central/rev/79473dc0e450
https://hg.mozilla.org/mozilla-central/rev/848f9fe24f1c
https://hg.mozilla.org/mozilla-central/rev/f49b4cddbc85
https://hg.mozilla.org/mozilla-central/rev/4ac1ba0956eb
https://hg.mozilla.org/mozilla-central/rev/8d9975a1d6f6
https://hg.mozilla.org/mozilla-central/rev/fa148ad38740
https://hg.mozilla.org/mozilla-central/rev/9f1540b140e5
https://hg.mozilla.org/mozilla-central/rev/6953adc7ca1a
https://hg.mozilla.org/mozilla-central/rev/909e0d60f7c3
https://hg.mozilla.org/mozilla-central/rev/e14ea6453892
https://hg.mozilla.org/mozilla-central/rev/c59957d6ca04
https://hg.mozilla.org/mozilla-central/rev/9a17ec827f59
https://hg.mozilla.org/mozilla-central/rev/cbf828cd48ae
https://hg.mozilla.org/mozilla-central/rev/07c0e58b5f16
https://hg.mozilla.org/mozilla-central/rev/62295fa19e50
https://hg.mozilla.org/mozilla-central/rev/6f368a13d9ed
https://hg.mozilla.org/mozilla-central/rev/5e8f4f902562
https://hg.mozilla.org/mozilla-central/rev/062647162efb
https://hg.mozilla.org/mozilla-central/rev/9a88876e7fa5
https://hg.mozilla.org/mozilla-central/rev/9e042218bfc0
https://hg.mozilla.org/mozilla-central/rev/39fcfeae16fa
https://hg.mozilla.org/mozilla-central/rev/7a662a29591b
https://hg.mozilla.org/mozilla-central/rev/d3a94d42ee8e
https://hg.mozilla.org/mozilla-central/rev/ef4b9a26ef43
https://hg.mozilla.org/mozilla-central/rev/0b13a7d48bc3
https://hg.mozilla.org/mozilla-central/rev/28fe9b60f5d5

Comment 328

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b858c286913

Comment 329

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.229 Rename NS_SELECTION_CHANGE to eSelectionChange

Comment 330

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.230 Rename NS_SELECT_START to eSelectStart

Comment 331

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.231 Rename NS_SELECT_EVENT_START to eSelectEventFirst

Comment 332

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.232 Rename NS_EDITOR_INPUT to eEditorInput

Comment 333

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.233 Rename NS_EDITOR_EVENT_START to eEditorEventFirst

Comment 334

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.234 Rename NS_SPEAKERMANAGER_SPEAKERFORCEDCHANGE to eSpeakerForcedChange

Can be just "e" + the DOM event name.

Comment 335

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.235 Rename NS_SPEAKERMANAGER_EVENT_START to eSpeakerManagerEventFirst

Oh, I forgot to say, reducing the indent before the second argument is intentional. Old indentation is wrong.

Comment 336

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.236 Rename NS_MEDIARECORDER_EVENT_START to eMediaRecorderEventFirst

Comment 337

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.237 Rename NS_MEDIARECORDER_DATAAVAILABLE to eMediaRecorderDataAvailable

I think that "MediaRecorder" prefix is necessary since names of following events are too generic.

Comment 338

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.238 Rename NS_MEDIARECORDER_WARNING to eMediaRecorderWarning

Comment 339

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.239 Rename NS_MEDIARECORDER_STOP to eMediaRecorderStop

Comment 340

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.240 Rename NS_TOUCH_EVENT_START to eTouchEventFirst

Comment 341

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.241 Rename NS_TOUCH_START to eTouchStart

Comment 342

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.242 Rename NS_TOUCH_MOVE to eTouchMove

Comment 343

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.243 Rename NS_TOUCH_END to eTouchEnd

Comment 344

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.244 Rename NS_TOUCH_CANCEL to eTouchCancel

Comment 345

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.245 Rename NS_SHOW_EVENT to eShow

Comment 346

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.246 Rename NS_MESSAGE to eMessage

Comment 347

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.247 Rename NS_MESSAGE_EVENT_START to eMessageEventFirst

Comment 348

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.248 Rename NS_WEBAUDIO_EVENT_START to eAudioEventFirst

Comment 349

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.249 Rename NS_AUDIO_PROCESS to eAudioProcess

Comment 350

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.250 Rename NS_AUDIO_COMPLETE to eAudioComplete

Comment 351

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.251 Rename NS_TRANSITION_EVENT_START to eTransitionEventFirst

Comment 352

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.252 Rename NS_TRANSITION_END to eTransitionEnd

Comment 353

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.253 Rename NS_SIMPLE_GESTURE_EDGE_COMPLETED to eEdgeUICompleted

I use DOM event name without "Moz" prefix.

Comment 354

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.254 Rename NS_SIMPLE_GESTURE_EDGE_CANCELED to eEdgeUICanceled

Comment 355

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.255 Rename NS_SIMPLE_GESTURE_EDGE_STARTED to eEdgeUIStarted

Comment 356

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.256 Rename NS_SIMPLE_GESTURE_PRESSTAP to ePressTapGesture

Comment 357

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.257 Rename NS_SIMPLE_GESTURE_TAP to eTapGesture

Comment 358

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.258 Rename NS_SIMPLE_GESTURE_ROTATE to eRotateGesture

Comment 359

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.259 Rename NS_SIMPLE_GESTURE_ROTATE_UPDATE to eRotateGestureUpdate

Comment 360

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.260 Rename NS_SIMPLE_GESTURE_ROTATE_START to eRotateGestureStart

Comment 361

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.261 Rename NS_SIMPLE_GESTURE_MAGNIFY to eMagnifyGesture

Comment 362

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.262 Rename NS_SIMPLE_GESTURE_MAGNIFY_UPDATE to eMagnifyGestureUpdate

Comment 363

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.263 Rename NS_SIMPLE_GESTURE_MAGNIFY_START to eMagnifyGestureStart

Comment 364

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.264 Rename NS_SIMPLE_GESTURE_SWIPE to eSwipeGesture

Comment 365

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.265 Rename NS_SIMPLE_GESTURE_SWIPE_END to eSwipeGestureEnd

Comment 366

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.266 Rename NS_SIMPLE_GESTURE_SWIPE_UPDATE to eSwipeGestureUpdate

Comment 367

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.267 Rename NS_SIMPLE_GESTURE_SWIPE_START to eSwipeGestureStart

Comment 368

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.268 Rename NS_SIMPLE_GESTURE_SWIPE_MAY_START to eSwipeGestureMayStart

Comment 369

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.269 Rename NS_SIMPLE_GESTURE_EVENT_START to eSimpleGestureEventFirst

Comment 370

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: part.270 Add comment to explain the naming rules of EventMessage

This is the final patch!

Comment 371

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/15753ee8232fa1585dad78af9569a3d237cda675
changeset:  15753ee8232fa1585dad78af9569a3d237cda675
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:33 2015 +0900
description:
Bug 895274 part.229 Rename NS_SELECTION_CHANGE to eSelectionChange r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/9112165662f7d243128171a0ec9e54d300934ad1
changeset:  9112165662f7d243128171a0ec9e54d300934ad1
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:33 2015 +0900
description:
Bug 895274 part.230 Rename NS_SELECT_START to eSelectStart r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/c738a1dd461142aafb22c0775f6c52ebf6cb2671
changeset:  c738a1dd461142aafb22c0775f6c52ebf6cb2671
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:33 2015 +0900
description:
Bug 895274 part.231 Rename NS_SELECT_EVENT_START to eSelectEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/608fec053b04ed5cfea0368cf6defd6704083625
changeset:  608fec053b04ed5cfea0368cf6defd6704083625
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:33 2015 +0900
description:
Bug 895274 part.232 Rename NS_EDITOR_INPUT to eEditorInput r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/d7d2811a7c2d024b4d7e37307acc8f99898ee09c
changeset:  d7d2811a7c2d024b4d7e37307acc8f99898ee09c
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:33 2015 +0900
description:
Bug 895274 part.233 Rename NS_EDITOR_EVENT_START to eEditorEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/fa00a86758ce17894ee0367c53121d03cba174c4
changeset:  fa00a86758ce17894ee0367c53121d03cba174c4
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:34 2015 +0900
description:
Bug 895274 part.234 Rename NS_SPEAKERMANAGER_SPEAKERFORCEDCHANGE to eSpeakerForcedChange r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/fe3323ce2a4b7673166e00822ed8dcf0b6ab7d32
changeset:  fe3323ce2a4b7673166e00822ed8dcf0b6ab7d32
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:34 2015 +0900
description:
Bug 895274 part.235 Rename NS_SPEAKERMANAGER_EVENT_START to eSpeakerManagerEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/f1342c2e9f05519290110b65fec493db7f89eb33
changeset:  f1342c2e9f05519290110b65fec493db7f89eb33
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:34 2015 +0900
description:
Bug 895274 part.236 Rename NS_MEDIARECORDER_EVENT_START to eMediaRecorderEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/0ae5bfbea97eb87dce31008581395368fbbac6f9
changeset:  0ae5bfbea97eb87dce31008581395368fbbac6f9
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:34 2015 +0900
description:
Bug 895274 part.237 Rename NS_MEDIARECORDER_DATAAVAILABLE to eMediaRecorderDataAvailable r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/a74a014e8b29a10075fedc19d52c3126d7d11e08
changeset:  a74a014e8b29a10075fedc19d52c3126d7d11e08
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:34 2015 +0900
description:
Bug 895274 part.238 Rename NS_MEDIARECORDER_WARNING to eMediaRecorderWarning r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/e0c0342f606c0b5db6e1b93a668b027204b1d026
changeset:  e0c0342f606c0b5db6e1b93a668b027204b1d026
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:34 2015 +0900
description:
Bug 895274 part.239 Rename NS_MEDIARECORDER_STOP to eMediaRecorderStop r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/823a3bba6c8bfedc3fcfddca882a79fce66c6235
changeset:  823a3bba6c8bfedc3fcfddca882a79fce66c6235
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:34 2015 +0900
description:
Bug 895274 part.240 Rename NS_TOUCH_EVENT_START to eTouchEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/a92cec9902d70d52289ee2205b3f5f925c332e3c
changeset:  a92cec9902d70d52289ee2205b3f5f925c332e3c
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:34 2015 +0900
description:
Bug 895274 part.241 Rename NS_TOUCH_START to eTouchStart r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/79b8d374b4fd3c310e3504831c188db145e30a17
changeset:  79b8d374b4fd3c310e3504831c188db145e30a17
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:35 2015 +0900
description:
Bug 895274 part.242 Rename NS_TOUCH_MOVE to eTouchMove r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/aa8e1b6f6753c7f5d8413944b353bc2b18570a04
changeset:  aa8e1b6f6753c7f5d8413944b353bc2b18570a04
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:35 2015 +0900
description:
Bug 895274 part.243 Rename NS_TOUCH_END to eTouchEnd r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/641727472a5c88c547a87e64ea6a9bd1124a2af1
changeset:  641727472a5c88c547a87e64ea6a9bd1124a2af1
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:35 2015 +0900
description:
Bug 895274 part.244 Rename NS_TOUCH_CANCEL to eTouchCancel r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/2bbed060054e5118b27dfc6a3faf7b4c94dc101e
changeset:  2bbed060054e5118b27dfc6a3faf7b4c94dc101e
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:35 2015 +0900
description:
Bug 895274 part.245 Rename NS_SHOW_EVENT to eShow r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/e7592497917894a6597b8c003388f3944a4d4648
changeset:  e7592497917894a6597b8c003388f3944a4d4648
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:35 2015 +0900
description:
Bug 895274 part.246 Rename NS_MESSAGE to eMessage r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/5d2cba4706f66babe76ad2dd7883758a40552f26
changeset:  5d2cba4706f66babe76ad2dd7883758a40552f26
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:35 2015 +0900
description:
Bug 895274 part.247 Rename NS_MESSAGE_EVENT_START to eMessageEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/69d3b92fa23865536745acb23dcda72ebaad0a1a
changeset:  69d3b92fa23865536745acb23dcda72ebaad0a1a
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:35 2015 +0900
description:
Bug 895274 part.248 Rename NS_WEBAUDIO_EVENT_START to eAudioEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/827f184daa0fe3e174597b75d0787682c6596229
changeset:  827f184daa0fe3e174597b75d0787682c6596229
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:36 2015 +0900
description:
Bug 895274 part.249 Rename NS_AUDIO_PROCESS to eAudioProcess r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/bcc63510e6c5b228506b14f9e01342a4d86ae813
changeset:  bcc63510e6c5b228506b14f9e01342a4d86ae813
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:36 2015 +0900
description:
Bug 895274 part.250 Rename NS_AUDIO_COMPLETE to eAudioComplete r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/a42e812473515f470c71b5ffa0117a5941dddc39
changeset:  a42e812473515f470c71b5ffa0117a5941dddc39
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:36 2015 +0900
description:
Bug 895274 part.251 Rename NS_TRANSITION_EVENT_START to eTransitionEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/8f9e04ad1f2363ee504dc424656ef625faa57c5d
changeset:  8f9e04ad1f2363ee504dc424656ef625faa57c5d
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:36 2015 +0900
description:
Bug 895274 part.252 Rename NS_TRANSITION_END to eTransitionEnd r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/3aefc8bd19fd6ece1ea975fa0ba84a212ffbfc23
changeset:  3aefc8bd19fd6ece1ea975fa0ba84a212ffbfc23
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:36 2015 +0900
description:
Bug 895274 part.253 Rename NS_SIMPLE_GESTURE_EDGE_COMPLETED to eEdgeUICompleted r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/c391904401eea3bb82fd01aeab379da0c13e734d
changeset:  c391904401eea3bb82fd01aeab379da0c13e734d
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:36 2015 +0900
description:
Bug 895274 part.254 Rename NS_SIMPLE_GESTURE_EDGE_CANCELED to eEdgeUICanceled r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/8a9e0f1b03127eda04c7182b987168c69344b9ea
changeset:  8a9e0f1b03127eda04c7182b987168c69344b9ea
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:36 2015 +0900
description:
Bug 895274 part.255 Rename NS_SIMPLE_GESTURE_EDGE_STARTED to eEdgeUIStarted r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/85a692a19853eb3f3f6594ebedbe9170d8dbd103
changeset:  85a692a19853eb3f3f6594ebedbe9170d8dbd103
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:36 2015 +0900
description:
Bug 895274 part.256 Rename NS_SIMPLE_GESTURE_PRESSTAP to ePressTapGesture r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/820d0930ab430c74ccb7e60dd0968647bc2e6889
changeset:  820d0930ab430c74ccb7e60dd0968647bc2e6889
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:36 2015 +0900
description:
Bug 895274 part.257 Rename NS_SIMPLE_GESTURE_TAP to eTapGesture r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/9981f3b651a401d639ee0f881ce71185117ff956
changeset:  9981f3b651a401d639ee0f881ce71185117ff956
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:36 2015 +0900
description:
Bug 895274 part.258 Rename NS_SIMPLE_GESTURE_ROTATE to eRotateGesture r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/65489def5c252d57208ad763df49178df268113f
changeset:  65489def5c252d57208ad763df49178df268113f
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:36 2015 +0900
description:
Bug 895274 part.259 Rename NS_SIMPLE_GESTURE_ROTATE_UPDATE to eRotateGestureUpdate r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/4b22918a90f668f48b8f39d04b378315db0ac62d
changeset:  4b22918a90f668f48b8f39d04b378315db0ac62d
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:37 2015 +0900
description:
Bug 895274 part.260 Rename NS_SIMPLE_GESTURE_ROTATE_START to eRotateGestureStart r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/58cba751dfe5bbf823054f25ca8deeee5d3d39d8
changeset:  58cba751dfe5bbf823054f25ca8deeee5d3d39d8
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:37 2015 +0900
description:
Bug 895274 part.261 Rename NS_SIMPLE_GESTURE_MAGNIFY to eMagnifyGesture r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/2f0716ec8171759506434a0a1f82648dc8f56453
changeset:  2f0716ec8171759506434a0a1f82648dc8f56453
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:37 2015 +0900
description:
Bug 895274 part.262 Rename NS_SIMPLE_GESTURE_MAGNIFY_UPDATE to eMagnifyGestureUpdate r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/a61c8be5100bcaac9f792e6d8d11bd1098725ff7
changeset:  a61c8be5100bcaac9f792e6d8d11bd1098725ff7
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:37 2015 +0900
description:
Bug 895274 part.263 Rename NS_SIMPLE_GESTURE_MAGNIFY_START to eMagnifyGestureStart r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/9443d9e5318e8a792b817f745a58fce6bf11f95f
changeset:  9443d9e5318e8a792b817f745a58fce6bf11f95f
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:37 2015 +0900
description:
Bug 895274 part.264 Rename NS_SIMPLE_GESTURE_SWIPE to eSwipeGesture r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/7d3ff6e1cdfea1ce6fbdfdfb9eb9a72fc93557a2
changeset:  7d3ff6e1cdfea1ce6fbdfdfb9eb9a72fc93557a2
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:37 2015 +0900
description:
Bug 895274 part.265 Rename NS_SIMPLE_GESTURE_SWIPE_END to eSwipeGestureEnd r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/035f20d39060839225fc5e016789a9086a1cc5dc
changeset:  035f20d39060839225fc5e016789a9086a1cc5dc
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:37 2015 +0900
description:
Bug 895274 part.266 Rename NS_SIMPLE_GESTURE_SWIPE_UPDATE to eSwipeGestureUpdate r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/a158c3a14239946a596babf50b3886d34ca44792
changeset:  a158c3a14239946a596babf50b3886d34ca44792
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:37 2015 +0900
description:
Bug 895274 part.267 Rename NS_SIMPLE_GESTURE_SWIPE_START to eSwipeGestureStart r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/f2efb808b885285d98a7453a8b17b3878260ab9c
changeset:  f2efb808b885285d98a7453a8b17b3878260ab9c
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:38 2015 +0900
description:
Bug 895274 part.268 Rename NS_SIMPLE_GESTURE_SWIPE_MAY_START to eSwipeGestureMayStart r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/e69d4cf68a8729310ca15166fc3d8f0951753430
changeset:  e69d4cf68a8729310ca15166fc3d8f0951753430
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:38 2015 +0900
description:
Bug 895274 part.269 Rename NS_SIMPLE_GESTURE_EVENT_START to eSimpleGestureEventFirst r=smaug

url:        https://hg.mozilla.org/integration/mozilla-inbound/rev/b3f5c61b22ee65a236d04bdbbc4a3aa71c34435c
changeset:  b3f5c61b22ee65a236d04bdbbc4a3aa71c34435c
user:       Masayuki Nakano <[e-mail]>
date:       Tue Sep 15 00:14:38 2015 +0900
description:
Bug 895274 part.270 Add comment to explain the naming rules of EventMessage r=smaug

Comment 372

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/15753ee8232f
https://hg.mozilla.org/mozilla-central/rev/9112165662f7
https://hg.mozilla.org/mozilla-central/rev/c738a1dd4611
https://hg.mozilla.org/mozilla-central/rev/608fec053b04
https://hg.mozilla.org/mozilla-central/rev/d7d2811a7c2d
https://hg.mozilla.org/mozilla-central/rev/fa00a86758ce
https://hg.mozilla.org/mozilla-central/rev/fe3323ce2a4b
https://hg.mozilla.org/mozilla-central/rev/f1342c2e9f05
https://hg.mozilla.org/mozilla-central/rev/0ae5bfbea97e
https://hg.mozilla.org/mozilla-central/rev/a74a014e8b29
https://hg.mozilla.org/mozilla-central/rev/e0c0342f606c
https://hg.mozilla.org/mozilla-central/rev/823a3bba6c8b
https://hg.mozilla.org/mozilla-central/rev/a92cec9902d7
https://hg.mozilla.org/mozilla-central/rev/79b8d374b4fd
https://hg.mozilla.org/mozilla-central/rev/aa8e1b6f6753
https://hg.mozilla.org/mozilla-central/rev/641727472a5c
https://hg.mozilla.org/mozilla-central/rev/2bbed060054e
https://hg.mozilla.org/mozilla-central/rev/e75924979178
https://hg.mozilla.org/mozilla-central/rev/5d2cba4706f6
https://hg.mozilla.org/mozilla-central/rev/69d3b92fa238
https://hg.mozilla.org/mozilla-central/rev/827f184daa0f
https://hg.mozilla.org/mozilla-central/rev/bcc63510e6c5
https://hg.mozilla.org/mozilla-central/rev/a42e81247351
https://hg.mozilla.org/mozilla-central/rev/8f9e04ad1f23
https://hg.mozilla.org/mozilla-central/rev/3aefc8bd19fd
https://hg.mozilla.org/mozilla-central/rev/c391904401ee
https://hg.mozilla.org/mozilla-central/rev/8a9e0f1b0312
https://hg.mozilla.org/mozilla-central/rev/85a692a19853
https://hg.mozilla.org/mozilla-central/rev/820d0930ab43
https://hg.mozilla.org/mozilla-central/rev/9981f3b651a4
https://hg.mozilla.org/mozilla-central/rev/65489def5c25
https://hg.mozilla.org/mozilla-central/rev/4b22918a90f6
https://hg.mozilla.org/mozilla-central/rev/58cba751dfe5
https://hg.mozilla.org/mozilla-central/rev/2f0716ec8171
https://hg.mozilla.org/mozilla-central/rev/a61c8be5100b
https://hg.mozilla.org/mozilla-central/rev/9443d9e5318e
https://hg.mozilla.org/mozilla-central/rev/7d3ff6e1cdfe
https://hg.mozilla.org/mozilla-central/rev/035f20d39060
https://hg.mozilla.org/mozilla-central/rev/a158c3a14239
https://hg.mozilla.org/mozilla-central/rev/f2efb808b885
https://hg.mozilla.org/mozilla-central/rev/e69d4cf68a87
https://hg.mozilla.org/mozilla-central/rev/b3f5c61b22ee