Closed Bug 895391 Opened 12 years ago Closed 12 years ago

[Marketplace][User Story] Marketplace to automatically check for appcache manifest and warn devs if it's not present in the webapp manifest

Categories

(Marketplace Graveyard :: Validation, defect)

Product:
Marketplace Graveyard
Component:
Validation
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2013-08-13

People

(Reporter: sonmarce, Assigned: basta)

References

(Blocks 1 open bug)

Details

(Keywords: feature)

Attachments

(1 file)

apache manifest.zip
95.03 KB, application/text
Details
As an app developer I want Marketplace to automatically check for appcache manifest and warn devs if it's not present in the webapp manifest
Blocks: 870362
Keywords: feature
Blocks: 870367
Blocks: 870365
Blocks: 897779
https://github.com/mozilla/app-validator/commit/83fa8b764034253ae597bfe391bd381f18f5f63c
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Assignee: nobody → mattbasta
Target Milestone: --- → 2013-08-13
Please add STR here or mark it with [qa-] if no QA is needed.
Flags: needinfo?
1. Create a hosted web app where the index.html file has an appcache manifest. 2. Create a manifest for the app which lists index.html as the launch_path but does not include the appcache_path field. 3. Submit the manifest to the validator There should be a warning indicating that the appcache manifest is not listed in the app manifest.
Flags: needinfo?
Attached file apache manifest.zip —
I have submitted an app with the <html manifest="example.appcache"> in the index.html file and "launch_path": "/index.html" in the manifest.webapp file but after I have submitted the manifest to the validator, no errors were displayed. I have attached the packaged app.
This doesn't apply to packaged apps, only hosted apps.
(In reply to Matt Basta [:basta] from comment #6) > This doesn't apply to packaged apps, only hosted apps. We should be looking for appcache_path in the hosted apps' manifests - are we doing that? If we're not, we totally should be. I do agree that checking for the existence of `html[manifest]` in a hosted app's `launch_path` document is overkill.
(In reply to Christopher Van Wiemeersch [:cvan] from comment #7) > (In reply to Matt Basta [:basta] from comment #6) go home you're on PTO > > This doesn't apply to packaged apps, only hosted apps. > > We should be looking for appcache_path in the hosted apps' manifests - are > we doing that? If we're not, we totally should be. That's what this is. > I do agree that checking for the existence of `html[manifest]` in a hosted > app's `launch_path` document is overkill. That's literally (litrully) what this bug is.
(In reply to Matt Basta [:basta] from comment #8) > (In reply to Christopher Van Wiemeersch [:cvan] from comment #7) > > (In reply to Matt Basta [:basta] from comment #6) > > go home you're on PTO No, not today.
Matt, could you please provide us information or a link where we can create a hosted app using your STR? Thank you!
Flags: needinfo?(mattbasta)
You'll need to find some kind of hosting. Stackato could be used, but you'd need to use something like the fireplace damper since the manifest mime type isn't included in any default mime type libraries. I'd recommend talking to the qa folks for b2g to see what they test hosted apps with. They might even have a test case which is suitable to test this bug.
Flags: needinfo?(mattbasta)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: