895403 - Disable methods of nsIDownloadManager that are replaced by the JavaScript API

Status: RESOLVED FIXED

(Toolkit :: Downloads API, defect)

Description

[:Paolo Amadini]

Methods of nsIDownloadManager that have a replacement in the JavaScript API
for downloads should output an error to the Console, but only for products in
which the JavaScript API is actually enabled.

Comment 1

[:Paolo Amadini]

Actually, we should disable the old methods to ensure that the database is never
opened, something like NS_ENSURE_STATE(!mUseJSDownloads).

Comment 2

[Neil Deakin]

It looks like the database is initialized simply by getting the old download manager, not by calling any of its methods. So disabling the methods wouldn't prevent the database from being opened.

Comment 3

[:Paolo Amadini]

(In reply to Neil Deakin from comment #2)
> It looks like the database is initialized simply by getting the old download
> manager, not by calling any of its methods. So disabling the methods
> wouldn't prevent the database from being opened.

Yes, we should return early in the Init method if the preference is enabled,
and fail any methods that need to access the database.

Comment 4

[:Paolo Amadini]

Attachment: The patch

Comment 5

[:Paolo Amadini]

https://hg.mozilla.org/integration/fx-team/rev/18ea4b3fb24f

Comment 6

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/18ea4b3fb24f