895443 - Add spoken labels to special characters and keys

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Marco Zehe (:MarcoZ)]

The Shift, Delete, Enter, Space as well as any other special keys like most punctuation symbol keys don't speak properly when the screen reader is active. They are sent to the speech synthesizer as-is or have labels missing. For example, sending an " " string to the speech synthesizer won't yield any speech. Instead, a word like "Space" should be sent instead, so the label needs to be adjusted.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18957

I only explicitly labeled symbols that are not uttered by our pico speech engine.

Comment 2

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Comment on attachment 8417638 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18957

Looks good to me, r+.
Please help take care of the unit test result and then we can merge this.

Thank you.

Comment 3

[Eitan Isaacson [:eeejay]]

https://github.com/mozilla-b2g/gaia/commit/1e0574b8f6b8a2a8d9d468878ce2b4c283fc9a84