Add spoken labels to special characters and keys

RESOLVED FIXED

Status

Firefox OS
Gaia::Keyboard
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: MarcoZ, Assigned: eeejay)

Tracking

(Blocks: 1 bug, {access})

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [b2ga11y p=1])

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
The Shift, Delete, Enter, Space as well as any other special keys like most punctuation symbol keys don't speak properly when the screen reader is active. They are sent to the speech synthesizer as-is or have labels missing. For example, sending an " " string to the speech synthesizer won't yield any speech. Instead, a word like "Space" should be sent instead, so the label needs to be adjusted.
(Assignee)

Updated

4 years ago
Whiteboard: [b2ga11y 2.0]

Updated

4 years ago
Blocks: 1002705
(Assignee)

Updated

4 years ago
Whiteboard: [b2ga11y 2.0] → [b2ga11y p=1]
(Assignee)

Updated

4 years ago
Assignee: nobody → eitan
(Assignee)

Comment 1

4 years ago
Created attachment 8417638 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18957

I only explicitly labeled symbols that are not uttered by our pico speech engine.
Attachment #8417638 - Flags: review?(rlu)
Comment on attachment 8417638 [details] [review]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/18957

Looks good to me, r+.
Please help take care of the unit test result and then we can merge this.

Thank you.
Attachment #8417638 - Flags: review?(rlu) → review+
(Assignee)

Comment 3

4 years ago
https://github.com/mozilla-b2g/gaia/commit/1e0574b8f6b8a2a8d9d468878ce2b4c283fc9a84
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.