895524 - [B2G][l10n][First Time Experience] Korean: translation of "Change" is not completly shown in Date & Time

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::First Time Experience, defect)

Description

[Jinkyu Yi[:jincreator]]

Attachment: Korean ftu screen in

"Change" is translated into "바꾸기" - 3 letters.
But ftu is only showing "바꾸" - 2 letters.
However, ftu can show entire English word "Change" - 6 letters.

I attached screenshot and I think you can find out only 2 Korean letters are shown even you can't read Korean.

Comment 1

[Francesco Lodolo [:flod]]

I see the current string is 2 characters long, I guess the Korean team changed it to make the text fit
https://hg.mozilla.org/gaia-l10n/ko/file/017d2f417759/apps/communications/ftu/ftu.properties#l164
change = 변경

I'm trying with devtools and app manager to fit "바꾸기", but only "바꾸" is displayed. This on the current master.

Width of this element is set to 8rem (I don't think we can change that, because of very long city names)
https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/ftu/css/style.css#L630

And a padding-right of 3em inherited from buttons
https://github.com/mozilla-b2g/gaia/blob/master/shared/style/buttons.css#L160

What's strange is that I can put "verylongchange" in there, but "long change" gets wrapped, so it's related to white spaces.

So, adding white-spaces: nowrap; to .change should be enough.

Flagging Borja for an opinion, since he helped fixing another CSS issue in FTU before.

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Screenshot Keon

Screenshot with whitespaces: nowrap; added to .change

Comment 3

[Francesco Lodolo [:flod]]

Attachment: Pull request on Github

I realized I can change this in FTE without touching /shared, so it seems pretty safe. No change for existing locales, just fixes some edge cases like Korean.

Comment 4

[Francesco Lodolo [:flod]]

Attachment: Screenshot on Keon

Screenshot on Keon with the patch applied: FTE set to Korean, text changed to "바꾸기".

Comment 5

[Channy Yun [:channy]]

(In reply to Francesco Lodolo [:flod] from comment #3)
> I realized I can change this in FTE without touching /shared, so it seems
> pretty safe. No change for existing locales, just fixes some edge cases like
> Korean.

Okay. That's good job!

Comment 6

[Fernando Campo (:fcampo)]

Comment on attachment 8390360 [details] [review]
Pull request on Github

I'd say to add tests, but honestly, no idea how to test that a button content shows all the text inside of the space it has :S

Thanks for the super short fix!

Comment 7

[Francesco Lodolo [:flod]]

Thanks for the review.

(In reply to Fernando Campo (:fcampo) from comment #6)
> I'd say to add tests, but honestly, no idea how to test that a button
> content shows all the text inside of the space it has :S

Even if that's possible, not sure how we could do that with all localizations we ship (it would be great, basically automated QA, but I don't see that happening).

Setting keyword for checkin.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Master: fba11cf6ae2a5d5e1cc7f71dfe01eed734281c42