895569 - remove django-bootstrap-form

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect, P4)

Description

[Andrei Hajdukewycz [:sancus]]

https://github.com/mozilla/mozillians/commit/0aaea4c9c9cff67e0f65376000c2d29e78e66edd

We reused this to substitute in html for form fields that would produce the correct errors, but really we should remove this library and just change the bootstrap helper in common/helpers.py to substitute our custom template, we don't need the bootstrap specific stuff anymore.

Comment 1

[jbonatakis]

I would like to take this but i found difficult to understand what really want to do. I assume that you want to insert error handling in bootstrap method. Am i right?

Comment 2

[Dan Poirier [:dpoirier]]

Pull request: https://github.com/mozilla/mozillians/pull/738

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/6edc0b00239aa1e14bb60de0fd80c393f077d060
Bug 895569 - Remove django-bootstrap-forms and cleanup

* Remove django-bootstrap-form package
* Implement what we needed from it in mozillians
* Move some label text to form definitions
* Mark labels on required fields automatically with 'required' class
* Use CSS to visually differentiate required fields where desired
* Get rid of Jinja macros in edit_profile.html
* Try to move decisions about markup from Python to the template

https://github.com/mozilla/mozillians/commit/6f7c208db419869affa89051b2c5bbd619ba2c6f
Merge pull request #738 from dpoirier/bug-895569-remove-bootstrap-form

Bug 895569 - Remove django-bootstrap-forms

Comment 4

[Giorgos Logiotatidis [:giorgos]]

Verified on stage:
* User edit pages looks and works as expected
* Invite page looks and works as expected (+ generic error message)

Thanks for working on this Dan!