895711 - Sending NS_TOUCH_START events through HandleEventWithTarget silently fails to reach content

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Eitan Isaacson [:eeejay]]

This has to do with the fact that the Touch objects never get their mChanged set to true. This is handled in HandleEvent where new touches are compared with the current touch queue. But HandleEventWithTarget calls HandleEventInternal directly.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Mark new touches in touchstart as changed in HandleEventInner

I actually am not sure if this is 100% correct. Basically, everything that does not have to do with retargetting should not be in HandleEvent, but in HandleEventInner instead.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

So why do we need this? For a11y dispatching touch events?

Comment 3

[Marco Zehe (:MarcoZ)]

Yes, historically, a11y only dispatched click events, which hardly works on any modern mobile web app, including GAIA. So this is needed for Firefox OS, or virtually every file in GAIA would need to have click listeners registered in addition to the already present touch listeners, and that just for a11y purposes.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 778709 [details] [diff] [review]
Mark new touches in touchstart as changed in HandleEventInner

Remove touch->mMessage = aEvent->message; from the old place?

Comment 5

[Eitan Isaacson [:eeejay]]

Looks greenish enough..
https://tbpl.mozilla.org/?tree=Try&rev=ae8d66587ca8

Comment 6

[Eitan Isaacson [:eeejay]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/619da1470dea

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/619da1470dea