895714 - Need a way to mute apps when screen is off

Status: RESOLVED DUPLICATE of bug 1100822

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Leo]

Depending on some operator's spec, apps should be muted when screen is off. 

Currently (based on v1-train), apps playing sound are not muted when screen is off. And this is on purpose. (by 828283 patch)

Leo is looking for a way to mute apps when screen is off, to reduce CPU drain.

The apps playing sound in background, such as Music and Radio app, are exceptions. They should continue playing sounds even when screen is off, just like how they continue playing sounds when home button is pressed and their visibility is moved away.

Comment 1

[Leo]

I have run some tests and by reverting the following commit does what we want. 
https://github.com/mozilla-b2g/gaia/commit/ef33fd3d3741adb6cc4a28d8b5a26099b7fc6c88
which is

   function overlayEventHandler(evt) {
     ...
     case 'mozChromeEvent':
        if (isRunningFirstRunApp)
          return;
     ...
   }

However, I'm not sure what isRunningFirstRunApp means..

Comment 2

[hanj.kim25]

Hi Alive, 

By looking at the window_manager.js history, it appears that you are the one who added the isRunningFirstRunApp check.
https://github.com/mozilla-b2g/gaia/commit/ee55b12d8bf8fcfc49f271e7f4a1086f47eeea96

However, in your comment before you mentioned that you don't know what this code means. 
https://bugzilla.mozilla.org/show_bug.cgi?id=828283#c110

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Uh, I mean I don't know why you paste the code...

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

We need clear spec in order not to cause regression.
The requester of 828283 is also coming from a parter, it's not our original design.

Now we have totally two different opinions...

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Leo from comment #1)
> I have run some tests and by reverting the following commit does what we
> want. 
> https://github.com/mozilla-b2g/gaia/commit/
> ef33fd3d3741adb6cc4a28d8b5a26099b7fc6c88
> which is
> 
>    function overlayEventHandler(evt) {
>      ...
>      case 'mozChromeEvent':
>         if (isRunningFirstRunApp)
>           return;
>      ...
>    }
> 
> However, I'm not sure what isRunningFirstRunApp means..

Anyway I'm going to remove this, this is irrelevant to this issue.

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Leo from comment #1)
> I have run some tests and by reverting the following commit does what we
> want. 
> https://github.com/mozilla-b2g/gaia/commit/
> ef33fd3d3741adb6cc4a28d8b5a26099b7fc6c88
> which is
> 
>    function overlayEventHandler(evt) {
>      ...
>      case 'mozChromeEvent':
>         if (isRunningFirstRunApp)
>           return;
>      ...
>    }
> 
> However, I'm not sure what isRunningFirstRunApp means..

I believe what you want is to remove gaia part in bug 828283
Remove the mozChromeEvent from overlay events.
Remove the mozChromeEvent part from ovelayEventHandler.

...if this is tolerable.

Comment 7

[hanj.kim25]

(In reply to Alive Kuo [:alive] from comment #4)
> We need clear spec in order not to cause regression.
> The requester of 828283 is also coming from a parter, it's not our original
> design.
> 
> Now we have totally two different opinions...

Right, they are two different opinions. That's why we are looking for a way to apply only in our git repo.

Comment 8

[hanj.kim25]

(In reply to Alive Kuo [:alive] from comment #3)
> Uh, I mean I don't know why you paste the code...

I don't know what isRunningFirstRunApp is. But somehow, putting isRunningFirstRunApp check back in muted the sound when screen is off. I wanted to check with you if this was okay. Anyways this is bad, I don't even know what isRunningFirstRunApp is. 

Let me try your suggestion, which is to remove the mozChromeEvent from overlay events, ovelayEventHandler.

Thank you.

Comment 9

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to hanj.kim25 from comment #8)
> (In reply to Alive Kuo [:alive] from comment #3)
> > Uh, I mean I don't know why you paste the code...
> 
> I don't know what isRunningFirstRunApp is. But somehow, putting
> isRunningFirstRunApp check back in muted the sound when screen is off. I
> wanted to check with you if this was okay. Anyways this is bad, I don't even
> know what isRunningFirstRunApp is. 
> 
> Let me try your suggestion, which is to remove the mozChromeEvent from
> overlay events, ovelayEventHandler.
> 
> Thank you.

It's unchanged old variable for FTU. The same as 'FtuLauncher.isRunning()'. I just correct it on v1-train.

Comment 10

[hanj.kim25]

(In reply to Alive Kuo [:alive] from comment #9)

Oh.. I get it now. I was wondering where isRunningFirstRunApp is from.

I guess, the reason why adding isRunningFirstRunApp check worked was because of its 'undefined variable' error or warning. and then the ovelayEventHandler didn't proceed anymore. :)

Thanks and you can close this bug, since we have what we need now.

Comment 11

[(inactive after 6/18) Alive Kuo [:alive]]

I'm clear the leo+ flag but leave this opened.

Comment 12

[Andrea Marchesini [:baku]]

I think this bug is fixed. Is it? can we close it?

Comment 13

[Alastor Wu [:alwu]]

I think the system app can decide whether mutes the app when its visibility changes.
Close this bug because we already done it in bug1100822.