895783 - Intermittent jetpack tests/test-places-host.testTagsUntag | no extra tags - 2 == 4

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[:Gijs (he/him)]

https://tbpl.mozilla.org/php/getParsedLog.php?id=25454054&tree=UX

Looks like:

TEST-PASS | tests/test-places-host.testTagsUntag | first tag persisted
TEST-PASS | tests/test-places-host.testTagsUntag | second tag persisted
TEST-PASS | tests/test-places-host.testTagsUntag | first tag removed
TEST-PASS | tests/test-places-host.testTagsUntag | second tag removed
TEST-UNEXPECTED-FAIL | tests/test-places-host.testTagsUntag | no extra tags - 2 == 4
TEST-INFO | Traceback (most recent call last):
  File "resource://gre/modules/commonjs/sdk/timers.js", line 31, in notify
    callback.apply(null, args);
  File "resource://gre/modules/commonjs/sdk/lang/functional.js", line 66, in invoke
    function invoke(callee, params, self) callee.apply(self, params);
  File "resource://gre/modules/commonjs/sdk/addon/events.js", line 27, in null
    else request.resolve(clone(data));
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 189, in resolve
    result.then(observer.resolve, observer.reject);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 47, in then
    return { then: function then(fulfill) { fulfill(value); } };
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 122, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://gre/modules/commonjs/sdk/core/promise.js", line 122, in resolve
    deferred.resolve(onFulfill ? onFulfill(value) : value);
  File "resource://extensions.modules.9e845e9f-ba7a-4618-82ca-c29cad17c091-at-jetpack.commonjs.path.tests/test-places-host.js", line 173, in exports.testTagsUntag/<
    assert.equal(tags.length, 2, 'no extra tags');
  File "resource://gre/modules/commonjs/sdk/test/assert.js", line 125, in equal
    operator: "=="
  File "resource://gre/modules/commonjs/sdk/test/assert.js", line 89, in fail
    this._log.fail(message);
  File "resource://gre/modules/commonjs/sdk/deprecated/unit-test.js", line 84, in fail
    this.console.testMessage(false, false, this.test.name, message);
  File "resource://gre/modules/commonjs/sdk/test/harness.js", line 523, in testMessage
    this.trace();
TEST-END | tests/test-places-host.testTagsUntag

Comment 1

[Legacy TBPL/Treeherder Robot]

KWierso
https://tbpl.mozilla.org/php/getParsedLog.php?id=25628360&tree=Mozilla-Inbound
Rev5 MacOSX Mountain Lion 10.8 mozilla-inbound opt test jetpack on 2013-07-23 14:43:13
revision: e17e35300225
slave: talos-mtnlion-r5-064

TEST-UNEXPECTED-FAIL | tests/test-places-host.testTagsUntag | no extra tags - 2 == 4

Comment 2

[Legacy TBPL/Treeherder Robot]

KWierso
https://tbpl.mozilla.org/php/getParsedLog.php?id=25642380&tree=Mozilla-Inbound
Rev4 MacOSX Snow Leopard 10.6 mozilla-inbound opt test jetpack on 2013-07-23 20:00:02
revision: c68b8da6ec5a
slave: talos-r4-snow-033

TEST-UNEXPECTED-FAIL | tests/test-places-host.testTagsUntag | no extra tags - 2 == 4

Comment 3

[Legacy TBPL/Treeherder Robot]

RyanVM
https://tbpl.mozilla.org/php/getParsedLog.php?id=25724074&tree=Mozilla-Inbound
Ubuntu VM 12.04 x64 mozilla-inbound debug test jetpack on 2013-07-25 10:42:13
revision: daeeae8ab22a
slave: tst-linux64-ec2-365

###!!! ABORT: OnDeleteURI was notified for a page that still exists?: 'history && NS_SUCCEEDED(history->GetIdForPage(aURI, &placeId, placeGuid)) && !placeId', file ../../../../toolkit/components/places/nsNavBookmarks.cpp, line 2791
###!!! ABORT: OnDeleteURI was notified for a page that still exists?: 'history && NS_SUCCEEDED(history->GetIdForPage(aURI, &placeId, placeGuid)) && !placeId', file ../../../../toolkit/components/places/nsNavBookmarks.cpp, line 2791
TEST-UNEXPECTED-FAIL | tests/test-places-host.testTagsUntag | Test output exceeded timeout (60s).

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

Attempted fix by removing duplicate URLs in tests: https://github.com/mozilla/addon-sdk/commit/5270f3890280b3e87aeb68bc874d913313e20452

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Moved into addon-test, seems to fix