Closed Bug 895843 Opened 12 years ago Closed 12 years ago

[id] testReorderSearchEngines.js fails with 'Modal dialog has been found and processed'

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect, P1)

Product:
Mozilla QA Graveyard
Component:
Mozmill Tests
Type:
defect

Tracking

(firefox23 fixed, firefox24 fixed, firefox25 fixed, firefox26 fixed, firefox-esr17 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox23 --- fixed
firefox24 --- fixed
firefox25 --- fixed
firefox26 --- fixed
firefox-esr17 --- fixed

People

(Reporter: mihai.morar, Assigned: mario.garbi)

References

Details

(Whiteboard: [mozmill-test-failure])

Attachments

(2 files)

enginesReorder_Default.patch
2.75 KB, patch
AndreeaMatei
: review+
Details | Diff | Splinter Review
enginesReorder.patch
2.77 KB, patch
AndreeaMatei
: review+
Details | Diff | Splinter Review
testReorderSearchEngines.js fails on FF 22.0 and Latest Nightly 2013-07-17 on Indonesian builds. It works as expected on en-US builds FF 22.0 and Latest Nightly 2013-07-17. For more information: http://mozmill-crowd.blargon7.com/#/functional/report/180cf2548ef2865af3ae441d6105c6e9
Component: id / Indonesian → Mozmill Tests
Product: Mozilla Localizations → Mozilla QA
QA Contact: hskupin
status-firefox22: --- → affected
status-firefox23: --- → affected
status-firefox24: --- → affected
status-firefox25: --- → affected
status-firefox-esr17: --- → affected
Whiteboard: [mozmill-test-failure]
Fails on Ubuntu 13.04 x86 using Indonesian Latest Nightly and FF 22.0 too
OS: Windows 8 → All
Summary: testReorderSearchEngines.js fails on Indonesian builds. → [id] testReorderSearchEngines.js fails with 'Modal dialog has been found and processed'
Assignee: nobody → mario.garbi
Status: NEW → ASSIGNED
This happens due to the fact that we only have 3 search engines for ID locale Google, Yahoo and Wikipedia(id). In the test we reorder them in such a way that if we only have 3 the last one will be on top before trying to move it up. Because it's the first already it will fail when we verify: "return this.selectedIndex === (index - 1)" A simple solution here would be to change the reorder function so that it can handle cases where we have only 3 engines, more specifically instead of 3-Down and 1-Up we could do 2-Down 2-Up or simply move up the last element faster.
Comment on attachment 792797 [details] [diff] [review] enginesReorder_Default.patch Review of attachment 792797 [details] [diff] [review]: ----------------------------------------------------------------- Looks good, even the old comment said "reorder a bit". http://hg.mozilla.org/qa/mozmill-tests/rev/c3ca44e0f01a (default) Please check backporting, thanks!
Attachment #792797 - Flags: review?(andreea.matei) → review+
As what I got this fails always in the Indonesian build. So bumping to P1.
status-firefox26: --- → fixed
Priority: -- → P1
Hardware: x86_64 → All
Comment on attachment 794648 [details] [diff] [review] enginesReorder.patch Review of attachment 794648 [details] [diff] [review]: ----------------------------------------------------------------- Transplanted http://hg.mozilla.org/qa/mozmill-tests/rev/c7b2a19cfb21 (aurora) http://hg.mozilla.org/qa/mozmill-tests/rev/a6dbcb86bb26 (beta) http://hg.mozilla.org/qa/mozmill-tests/rev/24d823860e95 (release) http://hg.mozilla.org/qa/mozmill-tests/rev/fb7bc4991691 (esr17)
Attachment #794648 - Flags: review?(andrei.eftimie)
Attachment #794648 - Flags: review?(andreea.matei)
Attachment #794648 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
status-firefox22: affected → ---
status-firefox23: affected → fixed
status-firefox24: affected → fixed
status-firefox25: affected → fixed
status-firefox-esr17: affected → fixed
Resolution: --- → FIXED
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: