When selecting "Help (online)", the "Tabs App Bar" isn't appearing making it seam like a new tab hasn't been created. Steps to reproduce the issue: 1) Open Firefox Metro 2) Swipe in the Windows Charm flyout and select "Settings" 3) Select "Help (online)" and you'll notice that the "Tabs App Bar" will not slide in indicating a new tab has been opened Current Behavior: - Selecting "Help (online)" will not slide in the "Tabs" app bar indicating that a new tab has been created Expected Behavior: - When a user selects "Help (online)" from the "Settings" flyout, the "Tabs" app bar should slide in showing the user that a new tab has been created
Summary: Defect - Tab bar not appearing when selecting "Help (online)" → Defect - Tab bar not appearing when selecting links from flyouts
Whiteboard: feature=defect status=for_sprint c=Settings_pane_options_and_about u=metro_firefox_user p=0 → feature=defect c=Settings_pane_options_and_about u=metro_firefox_user p=0 status=for_sprint
Whiteboard: feature=defect c=Settings_pane_options_and_about u=metro_firefox_user p=3 → feature=defect c=Settings_pane_options_and_about u=metro_firefox_user p=3 [preview]
Attachment #786620 - Flags: feedback?(mbrubeck)
Comment on attachment 786620 [details] [diff] [review] bringing in the tabstrip I agree; onAboutPolicyClick should move out of browser.js, maybe into AboutFlyoutPanel or BrowserUI. We should use the same constant as the argument to peekTabs in both of these calls -- maybe even move the peekTabs call inside of BrowserUI.newTab.
Attachment #786620 - Flags: feedback?(mbrubeck) → feedback+
I feel better much better. :) turns out that peekTabs() isn't called near newTab as often as I thought. I left most of the incantations of newTab() alone since the 3rd parameter defaults to false.
Attachment #786690 - Flags: review?(mbrubeck) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Went through the following "Defect" for iteration #12 testing without any issues. Used the following build: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-14-03-02-04-mozilla-central/ - Went through the original test case in comment #0 without any issues (went through it 15 different times) - Ensured all the flyouts where still working without any issues (sliding into view) - Ensured that you can go back and forth between the different flyouts without any issues - Ensured that all the flyouts where formatted and appear correctly - Ensured that both links from "Help" & "About" had the same behavior (when opening into a new tab) - Ensured that all of the above cases also worked using Filled View
Summary: Defect - Tab bar not appearing when selecting links from flyouts → [MP] Defect - Tab bar not appearing when selecting links from flyouts
Whiteboard: feature=defect c=Settings_pane_options_and_about u=metro_firefox_user p=3 [preview] → [preview] feature=defect c=Settings_pane_options_and_about u=metro_firefox_user p=3
Went through the following "Defect" for iteration #13 without any issues. Used the following build: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-08-31-03-02-24-mozilla-central/ - Went through the original test case in comment #0 without any issues - Went through the test cases added in comment #11 without any issues
Mozilla/5.0 (Windows NT 6.2; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0 Tested this on latest nightly (build ID: 20131030030201) during iteration #17 testing. No issues encountered, marking as verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.