895933 - Record in the CC log if it is AllTraces or not

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Andrew McCreight [:mccr8]]

It would be nice to have a little comment at the start of the log that indicates if AllTraces is used.  This helps when you get a log from somebody to tell if it is AllTraces or not.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: record if AllTraces is true or not

This also required a minor modification to the CC log parser to ignore lines that start with #.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 778526 [details] [diff] [review]
record if AllTraces is true or not

Review of attachment 778526 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/base/nsCycleCollector.cpp
@@ +1465,5 @@
>          mOutFile->OpenANSIFileDesc("w", &mStream);
>          NS_ENSURE_STATE(mStream);
>          MozillaRegisterDebugFILE(mStream);
>  
> +        fprintf(mStream, "# WantAllTraces=%d\n", mWantAllTraces);

%s, mWantAllTraces ? "true" : "false" ?

Comment 3

[Andrew McCreight [:mccr8]]

Attachment: record if AllTraces is true or not, using a string

Addressed review comment, carrying forward khuey's r+.

Comment 4

[Andrew McCreight [:mccr8]]

AllTraces was the only flag where it seemed to make sense to record.

Comment 5

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/90b25dd78e3e

Comment 6

[Justin Lebar (not reading bugmail)]

Zero risk, debugging only, necessary for Leo blocker bug 893012.

Comment 7

[Andrew McCreight [:mccr8]]

https://hg.mozilla.org/releases/mozilla-b2g18/rev/144ba586437d

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g18_v1_1_0_hd/rev/144ba586437d

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/90b25dd78e3e