Closed Bug 896067 Opened 12 years ago Closed 12 years ago

[guest] Update guest mode menu icon

Categories

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Product:
Firefox for Android Graveyard
Component:
Theme and Visual Design
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox25 verified, firefox26 verified, firefox27 verified, fennec25+)

Status:
VERIFIED FIXED
Milestone:
Firefox 26
Tracking Flags:
Tracking Status
firefox25 --- verified
firefox26 --- verified
firefox27 --- verified
fennec 25+ ---

People

(Reporter: liuche, Assigned: ibarlow)

References

Details

Attachments

(3 files)

guest-mode-icon.png
78.02 KB, image/png
Details
guest browsing menu icons.zip
4.90 KB, application/x-zip-compressed
Details
Patch
11.13 KB, patch
sriram
: review+
akeybl
: approval-mozilla-beta+
Details | Diff | Splinter Review
Attached image guest-mode-icon.png —
The lack of a menu icon for guest mode looks out of place.
Flags: needinfo?(ibarlow)
OS: Mac OS X → Android
Hardware: x86 → ARM
The label needs to change too
Summary: Icon for guest mode → Update guest mode menu (icon and label)
Summary: Update guest mode menu (icon and label) → [guest] Update guest mode menu (icon and label)
Blocks: guest-mode
No longer depends on: guest-mode
Updating the link from comment #1. https://wiki.mozilla.org/Mobile/Projects/Guest_browsing
Flags: needinfo?(ibarlow)
It looks extra out of place when there are also add-on menuitems below it with icons.
tracking-fennec: --- → ?
Assignee: nobody → ibarlow
tracking-fennec: ? → 25+
(In reply to Mark Finkle (:mfinkle) from comment #1) > The label needs to change too Menu label was fixed in a separate bug. This is icon only now.
Summary: [guest] Update guest mode menu (icon and label) → [guest] Update guest mode menu icon
Icons attached!
Attached patch Patch — — Splinter Review
Attachment #792397 - Flags: review?(sriram)
Attachment #792397 - Flags: review?(sriram) → review+
https://hg.mozilla.org/mozilla-central/rev/94e951d972d3
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Noticed that this is missing in 25 (beta #1) but tracking 25+.
Status: RESOLVED → VERIFIED
status-firefox27: --- → verified
Ping?
Comment on attachment 792397 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): Guest mode User impact if declined: No icon Testing completed (on m-c, etc.): Has been on central for awhile Risk to taking this patch (and alternatives if risky): very low risk String or IDL/UUID changes made by this patch: none
Attachment #792397 - Flags: approval-mozilla-beta?
Attachment #792397 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified fixed on: Build: Firefox for Android 25 Beta 6 and Firefox for Android 26 Aurora (2013-10-08) Device: Samsung Galaxy Tab OS: Android 4.0.4
status-firefox25: fixed → verified
status-firefox26: fixed → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: