Closed Bug 896101 Opened 12 years ago Closed 7 months ago

Tracking bug to fix ESR redirects on mozilla.org

Categories

(www.mozilla.org :: General, defect)

Product:
www.mozilla.org
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: retornam, Assigned: pmac)

References

(Blocks 1 open bug)

Details

(Whiteboard: [kb=1149603])

Attachments

(1 obsolete file)

STR: Firefox ESR build with MAI locale redirects to https://www.mozilla.org/mn/firefox/channel/ from https://www.mozilla.org/firefox/ instead of https://www.mozilla.org/firefox/fx/ or https://www.mozilla.org/firefox/new/ curl -H "Accept-Language: mn" -ILA "Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:17.0) Gecko/17.0 Firefox/17.0" https://www.mozilla.org/firefox/
ak on dev goes to https://www-dev.allizom.org/ak/firefox/channel/ and on stage and prod goes to https://www.{allizom, mozilla}.org/ak/firefox/new/. We have to get dev, stage and prod in sync.
Interesting. It is going to https://www.mozilla.org/mn/firefox/fx/, but then redirects to https://www.mozilla.org/mn/firefox/channel/. Not sure why yet. Investigating.
Assignee: nobody → pmac
So this appears to be because /*/firefox/fx/ is not on bedrock for non en-US locales. Then "mn" in particular has a redirect in /mn/firefox/index.html to /mn/firefox/channel/. I'm not sure how exactly this is being triggered from /fx/, but there is no fx file in the /mn/ folder. I think if we change the redirect there however that this will work as we want.
OS: Mac OS X → All
Hardware: x86 → All
(Kohei might be able to help out, here.)
And rewrite rules are defined at http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/.htaccess?limit_changes=0&view=markup#l414 > RewriteCond $1 !en-(US|GB|ZA)/ > RewriteCond $1 !^$ > RewriteRule ^(\w{2,3}(?:-\w{2}(?:-mac)?)?/)firefox/fx[/]?$ $1firefox/index.html?fx [PT] > RewriteCond $1 !en-(US|GB|ZA)/ > RewriteCond $1 !^$ > RewriteRule ^(\w{2,3}(?:-\w{2}(?:-mac)?)?/)firefox/new[/]?$ $1firefox/index.html?new [PT]
(In reply to Kohei Yoshino [:kohei] from comment #7) > And rewrite rules are defined at > http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/trunk/. > htaccess?limit_changes=0&view=markup#l414 > > > RewriteCond $1 !en-(US|GB|ZA)/ > > RewriteCond $1 !^$ > > RewriteRule ^(\w{2,3}(?:-\w{2}(?:-mac)?)?/)firefox/fx[/]?$ $1firefox/index.html?fx [PT] > > RewriteCond $1 !en-(US|GB|ZA)/ > > RewriteCond $1 !^$ > > RewriteRule ^(\w{2,3}(?:-\w{2}(?:-mac)?)?/)firefox/new[/]?$ $1firefox/index.html?new [PT] (How) Can this help us fix this testability issue on dev/master/trunk?
* ak and mai: those locales don't have the channel pages on prod; we can just remove the channel redirects. * csb and lij: the channel redirects can be removed as those are only for older versions. * mn is the only locale that the channel redirect is in effect on prod, but the locale seems inactive. I think we can remove the redirect and use en-US as a fallback to for now. The bottom line is, we can remove all the /{locale}/firefox/channel/ redirects from those locales.
Pmac what do you think about comment #9
Flags: needinfo?(pmac)
Sounds good to me, but perhaps :pascalc would know best?
Flags: needinfo?(pmac) → needinfo?(pascalc)
ak and mai do have the channel page on prod: http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/tags/production/ak/firefox/channel/ http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/tags/production/mai/firefox/channel/ but ak and mai locales are not activated on production per lack of contributors to maintain them. The csb and lij redirects for older versions in code can be removed but note that it doesn't affect esr builds at all. We don't have a mn localizer anymore and we stopped producing release builds, I think we can fallback to en-US for now.
Flags: needinfo?(pascalc)
(In reply to Pascal Chevrel:pascalc from comment #12) > ak and mai do have the channel page on prod: > http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/tags/production/ak/ > firefox/channel/ > http://viewvc.svn.mozilla.org/vc/projects/mozilla.com/tags/production/mai/ > firefox/channel/ > but ak and mai locales are not activated on production per lack of > contributors to maintain them. > > The csb and lij redirects for older versions in code can be removed but note > that it doesn't affect esr builds at all. > > We don't have a mn localizer anymore and we stopped producing release > builds, I think we can fallback to en-US for now. What's the actionable item(s) here, for both/either: a) dev b) web qa? I would love to get this fixed; thanks!
Flags: needinfo?(pascalc)
Whiteboard: [kb=1149603]
So can we remove all those redirects?
Is this bug still valid after RNA launch?
Good questions. This one seems to have languished. Still a problem?
Flags: needinfo?(pascalc)

Mass-removing myself from cc; search for 12b9dfe4-ece3-40dc-8d23-60e179f64ac1 or any reasonable part thereof, to mass-delete these notifications (and sorry!)

Attachment #9387783 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → WORKSFORME

Content negotiation gets the best match from Accept-Language for existing, enabled and activated content, or provides a default (en-US) fallback.

There might be cases where hard-coded product locale in URLs e.g. https://www.mozilla.org/%LOCALE%/firefox/organizations/notes (NB: https://searchfox.org/firefox-main/search?q=www.mozilla.org%2F%25LOCALE%25 …) would cause 404s in case that actual explicit locale is not even enabled in production. (Works with /lij/ but fails with /scn/ for example.)

That is rather a distinct topic in itself, haven't looked for a bug that would track it already, so can't tell if any of that is a concern. Anyone coming across that in any active code paths actually taken is encouraged to open a more specific and current issue for that.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: