896111 - ssi_saveState(aUpdateAll) take 62% of loading smugmug

Status: RESOLVED FIXED

(Firefox :: Session Restore, defect)

Description

[Doug Turner (:dougt)]

I use smugmug for pictures.  In one directory, I have 6000 galleries or so.  It takes a very long time to load.  Profile, it shows that 62% of the time is in ssi_saveState(aUpdateAll).

Comment 1

[:Gavin Sharp [email: [e-mail]]]

We're fixing that in bug 838577 (and some related bugs).

Comment 2

[Doug Turner (:dougt)]

gavin, that is a huge change.  do you think it's going to make 25?

How about we do something simple.  can we bail form ssi_saveStatestop() when the document is still loading?

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Actually, it's probably going to be fixed in bug 867143, expected any day now.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

(In reply to Doug Turner (:dougt) from comment #2)
> How about we do something simple.  can we bail form ssi_saveStatestop() when
> the document is still loading?

Sounds like something worth investigating, but could be tricky to get right (balancing responsiveness with avoiding dataloss, e.g. if pages are "loading" a long time while you type in a form you don't want to lose all that data).

Comment 5

[Doug Turner (:dougt)]

why would you be writing into a form while the page is still loading?  is that something?

Comment 6

[:Gavin Sharp [email: [e-mail]]]

It depends on which definition of "loading" you're using, so we'd need to pick one carefully. By some definitions some pages continue "loading" well after they're usable by users.

Comment 7

[Doug Turner (:dougt)]

Given Yoric thinks 867143 is going to land soon, I don't think I care about something simple any more.

Comment 8

[David Teller [:Yoric] - still alive but not very active]

Bug 867143 has now landed. Doug, could you check whether this helps out?

Comment 9

[Doug Turner (:dougt)]

yup.  fixed.  Yoric, nice work man.