Closed Bug 896123 Opened 9 years ago Closed 9 years ago

Implement a JS_Init JSAPI function that must be called before any JSAPI entrypoint is called

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 896124

People

(Reporter: Waldo, Assigned: Waldo)

References

Details

Attachments

(1 file)

13.72 KB, patch
Details | Diff | Splinter Review
ICU provides initialization and cleanup functions that must be called for memory allocations and the like to be tracked correctly.  The latter in particular is relevant for tinderbox tracking of allocations and leaks -- if we don't cleanup ICU, we effectively leak whatever it's allocated under the hook, that wasn't allocated because it was needed for some particular ICU object we allocated and properly deallocated.

We already have JS_ShutDown for the cleanup hook, and somewhat surprisingly it seems to be called in the places that matter already.  All that's needed is an identical init function.

I'll add the ICU init/cleanup function calls in a separate bug; this is just to carve out the JSAPI space for it, and to clear out JS_NewRuntime of a whole bunch of init codee that really belongs in JS_Init.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 896124
You need to log in before you can comment on or make changes to this bug.