Closed
Bug 896145
Opened 12 years ago
Closed 11 years ago
[Build] Split |install-gaia| target into |profile| and |push| step, if possible
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
1.4 S6 (25apr)
People
(Reporter: timdream, Assigned: timdream)
References
Details
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #893724 +++
See the original bug. There should be a make commend that simply pushes the profile to device but not re-generate it. We should fix |install-gaia| for that (|make| is supposedly to skip the step already done right?), or we should create a new |push| PHONY target.
If we are replace GNU Make with something more maintainable, make sure this enhancement gets implemented :)
Assignee | ||
Updated•12 years ago
|
Component: Builds → Gaia
Summary: [Gaia Build] GAIA_MAKE_FLAG is different between "./flash.sh gaia" and "./build.sh gaia". → [Build] Split |install-gaia| target into |profile| and |push| step, if possible
Comment 1•12 years ago
|
||
Given the various scripts being already plugged in with gaia Makefile,
I tend to think it will be easier to introduce a new target with a sane behavior.
Otherwise, I don't think we will ever completely get rid of Makefile,
it may end up being just command forwarding to something else, but we will most likely have to keep it to ease integration with Makefile based projects.
Assignee | ||
Updated•12 years ago
|
Severity: blocker → normal
blocking-b2g: hd? → ---
Priority: P1 → --
Assignee | ||
Comment 2•11 years ago
|
||
Yuren, this bug is yours :)
Assignee: nobody → yurenju.mozilla
Flags: needinfo?(yurenju.mozilla)
Assignee | ||
Comment 5•11 years ago
|
||
Comment on attachment 8407343 [details] [review]
mozilla-b2g:master PR#18352
This is now much simpler because of your work.
Attachment #8407343 -
Flags: review?(yurenju.mozilla)
Assignee | ||
Updated•11 years ago
|
Assignee: yurenju.mozilla → timdream
Assignee | ||
Updated•11 years ago
|
Status: NEW → ASSIGNED
Comment 6•11 years ago
|
||
Comment on attachment 8407343 [details] [review]
mozilla-b2g:master PR#18352
r=yurenju if nits are addressed.
Attachment #8407343 -
Flags: review?(yurenju.mozilla) → review+
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 8407343 [details] [review]
mozilla-b2g:master PR#18352
Please confirm the amendments, thanks.
Attachment #8407343 -
Flags: feedback?(yurenju.mozilla)
Comment 8•11 years ago
|
||
Comment on attachment 8407343 [details] [review]
mozilla-b2g:master PR#18352
looks good!
Attachment #8407343 -
Flags: feedback?(yurenju.mozilla) → feedback+
Assignee | ||
Comment 9•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•11 years ago
|
Target Milestone: --- → 1.4 S6 (25apr)
You need to log in
before you can comment on or make changes to this bug.
Description
•