Assertion failure: rt->workerThreadState->shouldPause, at vm/Runtime-inl.h

RESOLVED FIXED in mozilla25

Status

()

defect
--
critical
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: gkw, Assigned: bhackett)

Tracking

(Blocks 1 bug, {assertion, regression, testcase})

Trunk
mozilla25
x86_64
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [jsbugmon:])

Attachments

(2 attachments)

Posted file stack
eval("\
    (function f(x) {\
        if (x > 0) {\
            f(x - 1)\
        }\
    })\
")(5000);
verifyprebarriers()

asserts js threadsafe debug shell on m-c changeset 6030c759a502 with --ion-parallel-compile=on at Assertion failure: rt->workerThreadState->shouldPause, at vm/Runtime-inl.h

s-s since this likely involves write barriers and GC is on the stack.
autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   http://hg.mozilla.org/mozilla-central/rev/d4d9f284b3d0
user:        Brian Hackett
date:        Fri Jul 19 11:01:46 2013 -0600
summary:     Bug 875125 - Fix typo.

Brian, is bug 875125 a likely regressor?
Blocks: 875125
Flags: needinfo?(bhackett1024)
Whiteboard: [jsbugmon:update] → [jsbugmon:]
JSBugMon: Cannot process bug: Unable to automatically reproduce, please track manually.
This needs a threadsafe shell to reproduce.
Marking sec-high because this involves GC and write barriers.  Feel free to adjust as appropriate.
Keywords: sec-high
Posted patch patchSplinter Review
This is a bug in barrier verification, StartVerifyPreBarriers does stuff that requires inspecting the runtime's PerThreadDatas without first pausing the worker threads.
Attachment #781887 - Flags: review?(wmccloskey)
Flags: needinfo?(bhackett1024)
Bug in StartVerifyPreBarriers, not s-s.
Assignee: general → bhackett1024
Group: core-security
Keywords: sec-high
Attachment #781887 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/2287b2667565
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla25
You need to log in before you can comment on or make changes to this bug.