896154 - Assertion failure: rt->workerThreadState->shouldPause, at vm/Runtime-inl.h

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: stack

eval("\
    (function f(x) {\
        if (x > 0) {\
            f(x - 1)\
        }\
    })\
")(5000);
verifyprebarriers()

asserts js threadsafe debug shell on m-c changeset 6030c759a502 with --ion-parallel-compile=on at Assertion failure: rt->workerThreadState->shouldPause, at vm/Runtime-inl.h

s-s since this likely involves write barriers and GC is on the stack.

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   http://hg.mozilla.org/mozilla-central/rev/d4d9f284b3d0
user:        Brian Hackett
date:        Fri Jul 19 11:01:46 2013 -0600
summary:     Bug 875125 - Fix typo.

Brian, is bug 875125 a likely regressor?

Comment 2

[Christian Holler (:decoder)]

JSBugMon: Cannot process bug: Unable to automatically reproduce, please track manually.

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

This needs a threadsafe shell to reproduce.

Comment 4

[Andrew McCreight [:mccr8]]

Marking sec-high because this involves GC and write barriers.  Feel free to adjust as appropriate.

Comment 5

[Brian Hackett [Laid off!]]

Attachment: patch

This is a bug in barrier verification, StartVerifyPreBarriers does stuff that requires inspecting the runtime's PerThreadDatas without first pausing the worker threads.

Comment 6

[Brian Hackett [Laid off!]]

Bug in StartVerifyPreBarriers, not s-s.

Comment 7

[Brian Hackett [Laid off!]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2287b2667565

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2287b2667565