896161 - Australis: restore backForwardItem.title in browser.dtd

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Francesco Lodolo [:flod]]

See bug 889500 for some background. We need to restore backForwardItem.title to make the whole merge/backout thing work.

Comment 1

[Francesco Lodolo [:flod]]

String originally removed here
https://hg.mozilla.org/projects/ux/diff/09fd1ae57a2e/browser/locales/en-US/chrome/browser/browser.dtd

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Patch for UX branch (already landed)

Patch restoring backForwardItem.title at the end of browser.dtd

Comment 3

[:Gijs (out for now; he/him)]

Pushed: https://hg.mozilla.org/projects/ux/rev/4a71a1c953d6

Comment 4

[:Gijs (out for now; he/him)]

Thinking about this, if we're moving this here, I guess in analogue to bug 889500, we also need to move it on m-c?

Comment 5

[Justin Dolske [:Dolske]]

Yes, I think that would be good.

Comment 6

[Francesco Lodolo [:flod]]

I'm checking the last merge
http://hg.mozilla.org/projects/ux/diff/e680128a639e/browser/locales/en-US/chrome/browser/browser.dtd

Should we try to move backForwardItem.title, bookmarksItem.title and viewBookmarksSidebar.label in the final group of gone-for-australis strings before Nov 28?

Comment 7

[:Gijs (out for now; he/him)]

(In reply to Francesco Lodolo [:flod] from comment #6)
> I'm checking the last merge
> http://hg.mozilla.org/projects/ux/diff/e680128a639e/browser/locales/en-US/
> chrome/browser/browser.dtd
> 
> Should we try to move backForwardItem.title, bookmarksItem.title and
> viewBookmarksSidebar.label in the final group of gone-for-australis strings
> before Nov 28?

Possibly. I mean, if the tree was open, I'd do it today. But it's not. If you write a patch, I'd be happy to review, but I don't know if we'll still manage to get it in (and/or how useful that'd still be if we're merging on Monday (Nov. 18!))

Comment 8

[Francesco Lodolo [:flod]]

Right, not sure were 28 came from... I knew it's next Monday :-)

It's not really important to land this before Nov 18, since the balance of strings is the same, it's definitely important to have it before merge day. Not sure if this concerns the parallel branch without Australis though.

I'll have a patch ready in a few minutes.

Comment 9

[Francesco Lodolo [:flod]]

Attachment: Move unused string in browser.dtd to bottom of the file (patch for mozilla-central)

I used the same order of the current browser.dtd in projects/ux. 

A diff between the patched file on central and the one currently in projects/ux only gives you new strings, so we should be good.

Comment 10

[:Gijs (out for now; he/him)]

Comment on attachment 832812 [details] [diff] [review]
Move unused string in browser.dtd to bottom of the file (patch for mozilla-central)

Review of attachment 832812 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent, thanks for the quick patch!

Comment 11

[Francesco Lodolo [:flod]]

Not sure who's (leave aside when) going to commit this. Better to hide the other patch and specify this one is for mozilla-central?

Comment 12

[:Gijs (out for now; he/him)]

(In reply to Francesco Lodolo [:flod] from comment #11)
> Not sure who's (leave aside when) going to commit this. Better to hide the
> other patch and specify this one is for mozilla-central?

Good point. I'm CC'd on the bugs about reopening the tree, so I can just land this whenever. Or, tbh, as this is just a "make merges easier" thing rather than an actual "change anything" thing, maybe we can land on m-c with CLOSED TREE added. Or maybe that'd confuse people and/or be annoying. Ed?

Comment 13

[Ed Morley [:emorley]]

Whilst this would be fine landing, I think it would just result in the flood-gates opening, so might be best to wait for now.

Comment 14

[:Gijs (out for now; he/him)]

https://hg.mozilla.org/mozilla-central/rev/4a71a1c953d6