Closed Bug 896161 Opened 6 years ago Closed 6 years ago

Australis: restore backForwardItem.title in browser.dtd

Categories

(Firefox :: General, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: flod, Assigned: flod)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:M8][Australis:P1][qa-])

Attachments

(2 files)

See bug 889500 for some background. We need to restore backForwardItem.title to make the whole merge/backout thing work.
String originally removed here
https://hg.mozilla.org/projects/ux/diff/09fd1ae57a2e/browser/locales/en-US/chrome/browser/browser.dtd
OS: Mac OS X → All
Hardware: x86 → All
Patch restoring backForwardItem.title at the end of browser.dtd
Attachment #778815 - Flags: review?(mdeboer)
Attachment #778815 - Flags: review?(mdeboer) → review+
Pushed: https://hg.mozilla.org/projects/ux/rev/4a71a1c953d6
Assignee: nobody → francesco.lodolo
Status: NEW → ASSIGNED
Whiteboard: [Australis:M8][Australis:P1][fixed-in-ux]
Thinking about this, if we're moving this here, I guess in analogue to bug 889500, we also need to move it on m-c?
Flags: needinfo?(dolske)
Yes, I think that would be good.
Flags: needinfo?(dolske)
I'm checking the last merge
http://hg.mozilla.org/projects/ux/diff/e680128a639e/browser/locales/en-US/chrome/browser/browser.dtd

Should we try to move backForwardItem.title, bookmarksItem.title and viewBookmarksSidebar.label in the final group of gone-for-australis strings before Nov 28?
Flags: needinfo?(gijskruitbosch+bugs)
(In reply to Francesco Lodolo [:flod] from comment #6)
> I'm checking the last merge
> http://hg.mozilla.org/projects/ux/diff/e680128a639e/browser/locales/en-US/
> chrome/browser/browser.dtd
> 
> Should we try to move backForwardItem.title, bookmarksItem.title and
> viewBookmarksSidebar.label in the final group of gone-for-australis strings
> before Nov 28?

Possibly. I mean, if the tree was open, I'd do it today. But it's not. If you write a patch, I'd be happy to review, but I don't know if we'll still manage to get it in (and/or how useful that'd still be if we're merging on Monday (Nov. 18!))
Flags: needinfo?(gijskruitbosch+bugs)
Right, not sure were 28 came from... I knew it's next Monday :-)

It's not really important to land this before Nov 18, since the balance of strings is the same, it's definitely important to have it before merge day. Not sure if this concerns the parallel branch without Australis though.

I'll have a patch ready in a few minutes.
I used the same order of the current browser.dtd in projects/ux. 

A diff between the patched file on central and the one currently in projects/ux only gives you new strings, so we should be good.
Attachment #832812 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 832812 [details] [diff] [review]
Move unused string in browser.dtd to bottom of the file (patch for mozilla-central)

Review of attachment 832812 [details] [diff] [review]:
-----------------------------------------------------------------

Excellent, thanks for the quick patch!
Attachment #832812 - Flags: review?(gijskruitbosch+bugs) → review+
Not sure who's (leave aside when) going to commit this. Better to hide the other patch and specify this one is for mozilla-central?
(In reply to Francesco Lodolo [:flod] from comment #11)
> Not sure who's (leave aside when) going to commit this. Better to hide the
> other patch and specify this one is for mozilla-central?

Good point. I'm CC'd on the bugs about reopening the tree, so I can just land this whenever. Or, tbh, as this is just a "make merges easier" thing rather than an actual "change anything" thing, maybe we can land on m-c with CLOSED TREE added. Or maybe that'd confuse people and/or be annoying. Ed?
Flags: needinfo?(emorley)
Whilst this would be fine landing, I think it would just result in the flood-gates opening, so might be best to wait for now.
Flags: needinfo?(emorley)
Attachment #778815 - Attachment description: bug896161.patch → Patch for UX branch (already landed)
Attachment #832812 - Attachment description: Move unused string in browser.dtd to bottom of the file → Move unused string in browser.dtd to bottom of the file (patch for mozilla-central)
https://hg.mozilla.org/mozilla-central/rev/4a71a1c953d6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M8][Australis:P1][fixed-in-ux] → [Australis:M8][Australis:P1]
Target Milestone: --- → Firefox 28
Whiteboard: [Australis:M8][Australis:P1] → [Australis:M8][Australis:P1][qa-]
You need to log in before you can comment on or make changes to this bug.