Closed
Bug 896267
Opened 11 years ago
Closed 11 years ago
Only create one walker actor per tab
Categories
(DevTools :: Inspector, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 25
People
(Reporter: dcamp, Assigned: dcamp)
References
Details
Attachments
(1 file)
|
13.59 KB,
patch
|
harth
:
review+
|
Details | Diff | Splinter Review |
Multiple walkers can be created with getWalker(), and they don't last across reloads. This fixes walkers to last across reloads, and then makes them one-per-tab.
|
Assignee | |
Updated•11 years ago
|
Attachment #778960 -
Flags: review?(jwalker)
|
|
Assignee | |
Updated•11 years ago
|
Blocks: remote-inspector
|
|
Assignee | |
Updated•11 years ago
|
Attachment #778960 -
Flags: review?(fayearthur)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 778960 [details] [diff] [review] v1 Review of attachment 778960 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me. Works great w/ my node client too.
Attachment #778960 -
Flags: review?(fayearthur) → review+
|
|
Assignee | |
Updated•11 years ago
|
Attachment #778960 -
Flags: review?(jwalker)
|
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/6f7b49cd2512
Assignee: nobody → dcamp
Whiteboard: [fixed-in-fx-team]
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6f7b49cd2512
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 25
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•