896322 - screen goes off after reset and before FTU starts while power-on video is playing

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[Leo]

After resetting a device, the screen goes off before FTU starts while power-on video is playing.

Steps to repro:
1. Reset device.
2. The device starts up showing Firefox logo and power-on video.
3. Observe the device suddenly turn off the screen.

Repro frequency: 50% (for the power-on video I have, 3 seconds video)


With v1-train, this is not reproduced because it doesn't have a power-on video.

From my analysis, the issue is in _reconfigScreenTimeout function of screen_manager.js
"this._setIdleTimeout(10, true);" is called when the power-on video plays because LockScreen.locked is true by default. And if the startup process (including playing the power-on video) takes longer than 10, the screen will go off.

Please refer to attachment video.


My solution is to call the "this._setIdleTimeout(0);" when WindowManager.getDisplayedApp() is null, meaning no app has been displayed yet. It works fine with this fix.

    if (this._screenWakeLocked || !WindowManager.getDisplayedApp()) {
      console.log('sssss _reconfigScreenTimeout checkpoint 1');
      this._setIdleTimeout(0);
    } else if (LockScreen.locked) {

Is this fix acceptable?

Comment 1

[hanj.kim25]

Attachment: Repro video

I have hidden the center of power-on video, please ignore the content of video. It just looks like white screen.

00:07 The power-on video starts.
00:20 All of a sudden, the screen goes off.

Comment 2

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 779051 [details]
Repro video

I cannot think of anything harmful now.
BTW please send a patch.

Comment 3

[hanj.kim25]

Attachment: Pull request url

Please also uplift to v1-train.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 779595 [details]
Pull request url

Line 388, E:0110: Line too long (93 characters).
Please correct this.

Comment 5

[hanj.kim25]

(In reply to Alive Kuo [:alive][Paris work week 7/22-26] from comment #4)

Corrected. Thanks!

Comment 6

[(inactive after 6/18) Alive Kuo [:alive]]

master

https://github.com/mozilla-b2g/gaia/commit/7eea78d212799ebbde7f4b78a05973b397c0b6d4

Comment 7

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 7eea78d212799ebbde7f4b78a05973b397c0b6d4 to:
v1-train: 8618b29382f2d8bc2809eab970ff059a2869be17

Comment 8

[mdaniloff]

Verified fixed on 

Build ID: 20130806071254
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/a2a9b89ef5ee
Gaia: 4c1a20570e20f64782ba170c14604395c48f7381
Platform Version: 18.1

The screen does not power off after reset or before the FTU starts

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 8618b29382f2d8bc2809eab970ff059a2869be17