Closed Bug 896330 Opened 6 years ago Closed 6 years ago

patchreader should not set the "expires" header

Categories

(Bugzilla :: Attachments & Requests, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
Bugzilla 4.4

People

(Reporter: glob, Assigned: glob)

Details

Attachments

(1 file)

currently all patchreader pages set an expires header of +3M.
this means clients don't see updates to the bugs.

steps:
1. create a bug, attach a patch
2. view the patch via patchreader's diff view
3. note the bug number is not struck out (due the bug not being resolved)
4. navigate back to the bug and resolve the bug
5. click on the 'diff' link in the attachment header
6. note the bug is still not struck out
7. do a shift+refresh to tell the browser to reload, ignoring its local cache
8. the bug is now correctly struck out

other dynamic content on the pages (header/footer) is also impacted by this expires header.
Attached patch 896330_1.patchSplinter Review
Attachment #779064 - Flags: review?(sgreen)
Attachment #779064 - Flags: review?(sgreen) → review+
Flags: approval?
Flags: approval4.4?
Flags: approval?
Flags: approval4.4?
Flags: approval4.4+
Flags: approval+
Severity: normal → minor
Target Milestone: --- → Bugzilla 4.4
Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/trunk/
modified Bugzilla/Attachment/PatchReader.pm
Committed revision 8679.

Committing to: bzr+ssh://bjones%40mozilla.com@bzr.mozilla.org/bugzilla/4.4/
modified Bugzilla/Attachment/PatchReader.pm
Committed revision 8585.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.