Read config.status in dictionary_helper_gen.py

RESOLVED INVALID

Status

()

RESOLVED INVALID
5 years ago
5 years ago

People

(Reporter: gyeh, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

5 years ago
https://bugzilla.mozilla.org/show_bug.cgi?id=842948#c45

Currently, dictionary_helper_gen.py doesn't generate code based on any config and it generates "DictionaryHelper.h" and "DictionaryHelper.cpp" on all platforms.

However, for the case in bug 842948, we'd like to use the generator and hope that some dictionaries are generated only when MOZ_B2G_BT is defined in config.status.
(Reporter)

Updated

5 years ago
Blocks: 842948
(Reporter)

Comment 1

5 years ago
Created attachment 779126 [details] [diff] [review]
Patch 1(v1): Read config.status and support CONFIG var

Hi smaug,

Thinker writes a patch for this bug. Could you help to take a look and give us some feedback? Thanks.
Attachment #779126 - Flags: feedback?(bugs)
(Reporter)

Comment 2

5 years ago
Created attachment 779129 [details]
Use case #1: dictionary_helper_gen.conf

Here's one use case for CONFIG var.
Just use a WebIDL dictionary.

Comment 4

5 years ago
Yeah, if possible, use WebIDL dictionary.

Comment 5

5 years ago
(We should try to get rid of dictionary_helper_gen.py, and switch everything to use WebIDL)

Updated

5 years ago
Attachment #779126 - Flags: feedback?(bugs) → feedback-
(Reporter)

Comment 6

5 years ago
Ok. Thanks :)
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.