896388 - Read config.status in dictionary_helper_gen.py

Status: RESOLVED INVALID

(Core :: DOM: Events, defect)

Description

[Gina Yeh [:gyeh] [:ginayeh]]

https://bugzilla.mozilla.org/show_bug.cgi?id=842948#c45

Currently, dictionary_helper_gen.py doesn't generate code based on any config and it generates "DictionaryHelper.h" and "DictionaryHelper.cpp" on all platforms.

However, for the case in bug 842948, we'd like to use the generator and hope that some dictionaries are generated only when MOZ_B2G_BT is defined in config.status.

Comment 1

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Patch 1(v1): Read config.status and support CONFIG var

Hi smaug,

Thinker writes a patch for this bug. Could you help to take a look and give us some feedback? Thanks.

Comment 2

[Gina Yeh [:gyeh] [:ginayeh]]

Attachment: Use case #1: dictionary_helper_gen.conf

Here's one use case for CONFIG var.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Just use a WebIDL dictionary.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Yeah, if possible, use WebIDL dictionary.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

(We should try to get rid of dictionary_helper_gen.py, and switch everything to use WebIDL)

Comment 6

[Gina Yeh [:gyeh] [:ginayeh]]

Ok. Thanks :)