896405 - Use continuous styling with the toolbox when the find bar is at the top

Status: NEW

(Firefox :: Theme, defect)

Description

[Luís Miguel [:quicksaver] (not reading bugmail)]

Attachment: findbarContinuousWithToolboxWindows.png

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:22.0) Gecko/20100101 Firefox/22.0 (Beta/Release)
Build ID: 20130618035212

Steps to reproduce:

Just had an thought while tweaking my find bar. What do you think about making it look like it is continuous with the top toolbox (location bar)?

I've added a screenshot of this concept, where I added a simple negative top margin to the findbar so it covers the toolbox bottom border:

findbar[position="top"] { margin-top: -1px; }

I haven't checked if the colors also match in other OS's like they do in Windows, or if a -1px margin would be enough in other OS's as well, but I can quickly check that if everyone else thinks this would be a good idea. Personally I like it, it makes the browser look cleaner in my opinion.

The only possible downside would be when using personas (and when bug 891786 is fixed, seriously, that bug needs to be reopened!), which a transparent find bar would still show the toolbox border behind it regardless of its position. Perhaps finding another approach to achieve the same effect, other than a negative top margin, could avoid that issue. I'm not sure exactly what that alternative would be because, for the life of me, I can't figure out where is that toolbox bottom border coming from.

Comment 1

[Luís Miguel [:quicksaver] (not reading bugmail)]

I went ahead and checked the other OS's. I think this look probably wouldn't work in Mac OS X, not without changing the background of the findbar to follow the gradients of the rest of the toolbox at least. But in Windows and Linux it looks great to me.

Comment 2

[Luís Miguel [:quicksaver] (not reading bugmail)]

Having had no feedback on this, I added this functionality/look as a feature to my add-on FindBar Tweak.

Comment 3

[:Gijs (out for now; he/him)]

Philipp, thoughts?

Comment 4

[Luís Miguel [:quicksaver] (not reading bugmail)]

FWIW I no longer have this option in my add-on since bug 869543 was backed out completely by bug 914180.

Comment 5

[:Gijs (out for now; he/him)]

Sorry, so what's the difference between this bug and bug 869543? It's not clear to me.

Comment 6

[Luís Miguel [:quicksaver] (not reading bugmail)]

(In reply to :Gijs Kruitbosch from comment #5)
> Sorry, so what's the difference between this bug and bug 869543? It's not
> clear to me.

Bug 869543 experimented with placing the findbar at the top at the same time as other big findbar changes were occurring, namely the per-tab findbar change which physically placed the findbar node in the browser container node in the DOM.

Because of that physical placement, the toolbox's border still separated the top toolbars and the findbar; see screenshots at bug 776708 or bug 893011. This bug was a proposal to integrate some CSS trickery that I applied in my add-on to disguise that border and try to make the findbar look continuous with the rest of the chrome (compare those screenshots with the one in here).

I never closed this because... Well at the time I thought bug 869543 might happen again sometime and then this could still be useful. And then it all fell off the earth. :P

Comment 7

[:Gijs (out for now; he/him)]

OK, well, let's leave this hanging in there for a few more years, then... :s