896418 - Improve naming for CtP popupNotification centerActions

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, enhancement, P3)

Description

[Georg Fritzsche [:gfritzsche]]

The centerActions naming for the new CtP doorhanger code could probably be named more clearly. This affects:
* gPluginHandler._makeCenterActions()
* ctpNotification.options.centerActions

The centerActions are used by browser-plugins.js to set the click-to-play plugin data on the notification from which the code in urlbarBindings.xml builds it state.

Comment 1

[Georg Fritzsche [:gfritzsche]]

Given the usage, how about pluginActions or pluginData instead?

Comment 2

[Benjamin Smedberg]

This was mainly historical from the old doorhanger. `pluginData` is good, but please let's delay this until bug 888510 lands.

Comment 3

[Dão Gottwald [:dao]]

There are also various mentions of a mysterious "center item"... http://mxr.mozilla.org/mozilla-central/search?string=center-item

Comment 4

[Benjamin Smedberg]

I'm not sure what's so mysterious about the UI elements, which are in fact the center items of the multi-plugin dialog.

Comment 5

[Dão Gottwald [:dao]]

Whether they're visually centered or not seems pretty much irrelevant for the code using that name. A name describing the purpose of these items would be more useful.

Comment 6

[Georg Fritzsche [:gfritzsche]]

Attachment: Rename centerActions to pluginData

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8377110 [details] [diff] [review]
Rename centerActions to pluginData

Review of attachment 8377110 [details] [diff] [review]:
-----------------------------------------------------------------

I double-checked and couldn't find any other references to centerActions.

::: browser/base/content/browser-plugins.js
@@ +888,5 @@
>          url = Services.urlFormatter.formatURLPref("app.support.baseURL") + "clicktoplay";
>        }
>        pluginInfo.detailsLink = url;
>        
> +      pluginData.set(pluginInfo.permissionString, pluginInfo);

Can you fix this trailing whitespace while you're in here?

Comment 8

[Georg Fritzsche [:gfritzsche]]

(In reply to Jared Wein [:jaws] (please needinfo? me) [PTO 2/20-2/23] from comment #7)
> Can you fix this trailing whitespace while you're in here?

Oh, sure, i missed that.

https://hg.mozilla.org/integration/mozilla-inbound/rev/bb77326af133

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bb77326af133