896423 - Update use of Send Dialog to comply with Facebook October 2013 Breaking Changes

Status: VERIFIED FIXED

(Firefox Affiliates Graveyard :: Social Integration, defect)

Description

[Osmose [:osmose, :mkelly]]

Facebook is changing how the Send Dialog (which we use to share Firefox download links directly with friends) works in October 2013 in a way that breaks previous usage. https://developers.facebook.com/roadmap/#q4_2013 has more details.

I got a notification warning me that Firefox Affiliates may be affected by this change, and that we should enable the migration setting on our app and fix our usage as soon as possible. The changes become non-optional on October 4th, 2013.

Comment 1

[[github robot]]

Commit pushed to develop at https://github.com/mozilla/affiliates

https://github.com/mozilla/affiliates/commit/caeeec72d44556aa09f9bd5c8eedd2f5d78c3a93
Fix bug 896423: Update our usage of the Facebook Send Dialog.

We actually are compliant with the October 2013 Breaking Changes, but
this removes the excess parameters anyway. This also fixes the 
post-invite view to correctly detect if the user sent a message or if
they cancelled out of the invitation process.

Also adds SITE_ID = 1 to the test settings to make the tests work even
if you've set SITE_ID to something else in your local settings. 
Otherwise the tests might attempt to fetch a SITE_ID besides 1, which
doesn't exist in the test database.

Comment 2

[Osmose [:osmose, :mkelly]]

For testing this, we mainly want to make sure the send dialog link works as expected.

Sending an invitation:
1. Enter the Facebook app and authenticate if necessary.
2. Click the "Invite your friends to Download Firefox!" link.
3. Add a friend to the "To" field and add a custom message to the invitation.
4. Submit the invitation.
5. Confirm that you are redirected back to the Affiliates app and a message confirms that you sent the invitation.

Quitting in the middle of sending an invitation:
1. Enter the Facebook app and authenticate if necessary.
2. Click the "Invite your friends to Download Firefox!" link.
3. Click the cancel button.
4. Confirm you are redirected back to the Affiliates app and there is no message displayed.

Comment 3

[Matt Brandt [:mbrandt]]

QA verified on stage - the facebook app appears to work seemlessly.

* Invitation of friends (or in my case, my spouse) works as well as posting to ones feed
* The ability to add a custom message works
* Cancellation works
* Redirection works after submitting or canceling the actions