Merge headers in Popcorn maker

RESOLVED FIXED

Status

Webmaker
Popcorn Maker
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: inactivate account for kate, Assigned: mjschranz)

Tracking

Details

(Whiteboard: wm-userbar, frontend)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

5 years ago
- Move ssoux stuff to main header
- Remove top header

Mock: 
- http://dl.dropbox.com/u/29163874/Screenshots/jw.png

Complete designs:
- https://bugzilla.mozilla.org/show_bug.cgi?id=890675
(Reporter)

Comment 1

5 years ago
Also, let's use an svg version of the PopcornMaker logo while we are here
(Assignee)

Comment 2

5 years ago
My only thing is, I wouldn't know how to make/get our logo in SVG format. Can you help me with that Kate?
Assignee: nobody → schranz.m
Status: NEW → ASSIGNED
Flags: needinfo?(kate)
(Assignee)

Comment 3

5 years ago
Created attachment 779390 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/126

PM work.

Kate said she would do the SVG.
Attachment #779390 - Flags: review?(kate)
Flags: needinfo?(kate)
(Assignee)

Updated

5 years ago
Blocks: 896471
(Assignee)

Updated

5 years ago
Depends on: 890675
(Assignee)

Updated

5 years ago
No longer depends on: 890675
(Assignee)

Comment 5

5 years ago
Comment on attachment 779391 [details] [review]
https://github.com/mozilla/login.webmaker.org/pull/133

Not needed.
Attachment #779391 - Attachment is obsolete: true
Attachment #779391 - Flags: review?(kate)

Comment 8

5 years ago
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/8e886dc7008089445fc354877afb3af2eb7458e5
Revert "Bug 896500 - Merge old userbar into header bar in prep for new UI"

This reverts commit 843470a665a8c618546f93c35199aabb02be89af.
(Assignee)

Comment 9

5 years ago
We missed something somewhat important in the interim, so I need to revert that out.

https://github.com/mozilla/popcorn.webmaker.org/commit/8e886dc7008089445fc354877afb3af2eb7458e5
(Assignee)

Comment 11

5 years ago
We are good now!
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain text/plain → text/x-github-pull-request text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.