Closed Bug 896571 Opened 8 years ago Closed 8 years ago

[fig] Re-write testInputAwesomeBar for new about:home

Categories

(Firefox for Android Graveyard :: General, defect)

ARM
Android
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: Margaret, Assigned: lucasr)

References

Details

(Whiteboard: [fixed-fig], abouthome-hackathon)

Attachments

(1 file)

We should rename this test, and we should update it to test the new editing mode for about:home
Assignee: nobody → lucasr.at.mozilla
Attachment #786246 - Flags: review?(margaret.leibovic)
Comment on attachment 786246 [details] [diff] [review]
Update testInputAwesomeBar for new about:home

Review of attachment 786246 [details] [diff] [review]:
-----------------------------------------------------------------

Except for one comment about a sleep call, this looks really awesome. Excited to have this test coverage!

::: mobile/android/base/tests/testInputUrlBar.java.in
@@ +86,2 @@
>  
> +        mSolo.sleep(1000);

I don't love seeing this. Is there some sort of waitForTest we could use instead to check that editing mode was dismissed? If we must have this sleep, we should add a comment about why.
Attachment #786246 - Flags: review?(margaret.leibovic) → review+
(In reply to :Margaret Leibovic from comment #2)
> Comment on attachment 786246 [details] [diff] [review]
> Update testInputAwesomeBar for new about:home
> 
> Review of attachment 786246 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Except for one comment about a sleep call, this looks really awesome.
> Excited to have this test coverage!
> 
> ::: mobile/android/base/tests/testInputUrlBar.java.in
> @@ +86,2 @@
> >  
> > +        mSolo.sleep(1000);
> 
> I don't love seeing this. Is there some sort of waitForTest we could use
> instead to check that editing mode was dismissed? If we must have this
> sleep, we should add a comment about why.

Done. Replaced it with a proper waitForText() call.
Pushed: http://hg.mozilla.org/projects/fig/rev/9dfb38fba3a8
Whiteboard: abouthome-hackathon → [fixed-fig], abouthome-hackathon
https://hg.mozilla.org/mozilla-central/rev/9dfb38fba3a8
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.