896571 - [fig] Re-write testInputAwesomeBar for new about:home

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[:Margaret Leibovic]

We should rename this test, and we should update it to test the new editing mode for about:home

Comment 1

[Lucas Rocha (:lucasr)]

Attachment: Update testInputAwesomeBar for new about:home

Comment 2

[:Margaret Leibovic]

Comment on attachment 786246 [details] [diff] [review]
Update testInputAwesomeBar for new about:home

Review of attachment 786246 [details] [diff] [review]:
-----------------------------------------------------------------

Except for one comment about a sleep call, this looks really awesome. Excited to have this test coverage!

::: mobile/android/base/tests/testInputUrlBar.java.in
@@ +86,2 @@
>  
> +        mSolo.sleep(1000);

I don't love seeing this. Is there some sort of waitForTest we could use instead to check that editing mode was dismissed? If we must have this sleep, we should add a comment about why.

Comment 3

[Lucas Rocha (:lucasr)]

(In reply to :Margaret Leibovic from comment #2)
> Comment on attachment 786246 [details] [diff] [review]
> Update testInputAwesomeBar for new about:home
> 
> Review of attachment 786246 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Except for one comment about a sleep call, this looks really awesome.
> Excited to have this test coverage!
> 
> ::: mobile/android/base/tests/testInputUrlBar.java.in
> @@ +86,2 @@
> >  
> > +        mSolo.sleep(1000);
> 
> I don't love seeing this. Is there some sort of waitForTest we could use
> instead to check that editing mode was dismissed? If we must have this
> sleep, we should add a comment about why.

Done. Replaced it with a proper waitForText() call.

Comment 4

[Lucas Rocha (:lucasr)]

Pushed: http://hg.mozilla.org/projects/fig/rev/9dfb38fba3a8

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/9dfb38fba3a8