896670 - createPattern with 'repeat' busted on SkiaGL/PowerVR

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

On a Galaxy Nexus (as well as our panda boards), context.createPattern(canvas, 'repeat') (or 'repeat-x', etc) results in garbage on the canvas.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Skia tries to use GL_REPEAT, which apparently does not work on PowerVR. It
s supposed to work if you have the GL_OES_texture_npot extension, which does not appear on the Galaxy Nexus at least. It looks like Skia needs to add another path for lame OpenGL ES here.

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

I guess we can do something like gl_FragColor = texture2D(tex, vec2(mod(vTexCoords.s, x), mod(vTexCoords.t, y))); where x is texture_width/rect_width and y is texture_height/rect_height? I have no idea how to make Skia do this, though. There is a ton of shader building stuff that I do not understand at all yet.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Flush after creating resized texture in SkiaGL

Comment 4

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 782745 [details] [diff] [review]
Flush after creating resized texture in SkiaGL

Review of attachment 782745 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/skia/include/core/SkPixelRef.h
@@ +28,5 @@
>       */
>  //    #define SK_IGNORE_PIXELREF_SETPRELOCKED
>  #endif
>  
> +     #define SK_IGNORE_PIXELREF_SETPRELOCKED

Should this perhaps go in SkUserConfig.h?

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to George Wright (:gw280) from comment #4)
> Comment on attachment 782745 [details] [diff] [review]
> Flush after creating resized texture in SkiaGL
> 
> Review of attachment 782745 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: gfx/skia/include/core/SkPixelRef.h
> @@ +28,5 @@
> >       */
> >  //    #define SK_IGNORE_PIXELREF_SETPRELOCKED
> >  #endif
> >  
> > +     #define SK_IGNORE_PIXELREF_SETPRELOCKED
> 
> Should this perhaps go in SkUserConfig.h?

Oh we don't even need that. Oops.

Comment 6

[George Wright (:gw280) (needinfo me!)]

Comment on attachment 782745 [details] [diff] [review]
Flush after creating resized texture in SkiaGL

Review of attachment 782745 [details] [diff] [review]:
-----------------------------------------------------------------

OK then. Looks fine

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Don't release SkiaGL render target after creating POT texture

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5e519aedb9d1