896698 - contacts sdcard import overlay does not display properly on v1-train

Status: RESOLVED DUPLICATE of bug 894836

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

While investigating bug 894751 I have encountered numerous instances where the sdcard import progress overlay does not display properly.

Sometimes the underlying contacts settings page is shown instead, even though you cannot click on it.  Other times the screen flashs back and forth between the progress overlay and the underlying app.

(Prior to the removal of the background color from the CSS it would show black instead of the underlying app.)

If you hit the home button and then re-open contacts then it will usually show the progress overlay correctly.

I have not seen this behavior on master.  I also have not been able to identify a bug that might have fixed it on master either.

Blocking 894751 because I'm not sure if this is part of the unexpected behavior that was described in that bug or not.  I am running into this a lot, though.

Also, can anyone else reproduce this?  I am using a Buri.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Link to video at https://www.dropbox.com/s/90h5fadx8hbuh9n/20130723_contacts_sdcard_import.MOV

This video shows the flashing behavior.

Note, the main thread is cpu locked towards the middle of the video while it parses the large vcard file.  So it looks like the progress bar is being displayed correctly, while its actually just frozen there.  Towards the end it begins flashing again when it starts adding the contacts to the database.

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

I just tried flashing my phone with the most recent stable firmware from the partner.  The problem persists.

Nom'ing leo because the UX is so bad.

Comment 3

[Cristian Rodriguez (:crdlc)]

Are you able to reproduce this problem in other device different than Buri? Thanks

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

(In reply to Cristian Rodriguez de la Cruz (:crdlc) from comment #3)
> Are you able to reproduce this problem in other device different than Buri?
> Thanks

Thats a good question.  The buri is the only development device I have unfortunately.  I take it no one else is seeing this?  I'll try to sanitize the vcard file I am using so that I can post for other people to try.

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

Git bisect landed on this commit for bug 865999 as the introduction of the problem:

  https://github.com/mozilla-b2g/gaia/commit/6f7897135f4cc70fb21eb3c737df4249a29c673b

Comment 6

[Ben Kelly [:bkelly, not reviewing]]

So this appears related to using height:auto for the elements on the settings screen.  Its not clear why this is an issue.  On master it does look like these have been further modified, so that might explain why we don't see it there.

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Attachment: contacts_import_flash.patch

This patch seems to fix the issue.  I have no good explanation for why, however.

Even just adding height:auto to #storageSettings by itself produces strange behavior where the settings page is shown while the import is in progress.  Adding the importService class on top of this with its height:5rem causes the flashing.

Any ideas?

Comment 8

[Ben Kelly [:bkelly, not reviewing]]

I checked logcat today without my usual gecko/gonk filters and discovered this during the flashing:

E/msm7627a.hwcomposer(  144): drawLayerUsingCopybit: copybit stretch failed
E/copybit (  144): copyBits failed (Invalid argument)
E/copybit (  144): 0: src={w=320, h=480, f=1, rect={0,0,320,50}}
E/copybit (  144):     dst={w=320, h=480, f=12, rect={0,20,320,50}}
E/copybit (  144):     flags=00020000
E/copybit (  144): 1: src={w=320, h=480, f=1, rect={0,87,320,373}}
E/copybit (  144):     dst={w=320, h=480, f=12, rect={0,107,320,373}}
E/copybit (  144):     flags=00020000

After searching in bugzilla for copybit I think this is probably a dupe of bug 894836.

Comment 9

[Preeti Raghunath(:Preeti)]

Minus: as dup bug 894836 is a leo-