896716 - ContextMenu should allow opening links in both normal and private tabs

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sriram Ramasubramanian [:sriram]]

As per bug 885882 comment #8, the context menu on HomeListView should allow opening links in both normal and private tabs.

Comment 1

[Sriram Ramasubramanian [:sriram]]

Attachment: Patch

Purged.

Comment 2

[:Margaret Leibovic]

Comment on attachment 779993 [details] [diff] [review]
Patch

Review of attachment 779993 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/home/HomeFragment.java
@@ -80,5 @@
>              menu.findItem(R.id.home_remove_history).setVisible(false);
>          }
>          menu.setHeaderTitle(info.title);
>  
>          menu.findItem(R.id.home_remove_history).setVisible(false);

Not part of this patch, but this is weird... there's an if statement up above to sometimes hide this item, but then we're always hiding it down below here.

I just looked into this a bit, and it's a bug. We're never showing the "Remove history" item, only the "Remove bookmark" item, which causes weirdness if you try to remove an item from the history list. I'll file a bug about that.

Comment 3

[Sriram Ramasubramanian [:sriram]]

https://hg.mozilla.org/projects/fig/rev/bd7116ff808e

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/bd7116ff808e