ContextMenu should allow opening links in both normal and private tabs

RESOLVED FIXED in Firefox 26

Status

()

Firefox for Android
Theme and Visual Design
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: sriram, Assigned: sriram)

Tracking

unspecified
Firefox 26
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: abouthome-hackathon, fixed-fig)

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
As per bug 885882 comment #8, the context menu on HomeListView should allow opening links in both normal and private tabs.
(Assignee)

Updated

5 years ago
Blocks: 885882
Whiteboard: abouthome-hackathon
(Assignee)

Comment 1

5 years ago
Created attachment 779993 [details] [diff] [review]
Patch

Purged.
Attachment #779993 - Flags: review?(margaret.leibovic)
(Assignee)

Updated

5 years ago
Assignee: nobody → sriram

Comment 2

5 years ago
Comment on attachment 779993 [details] [diff] [review]
Patch

Review of attachment 779993 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/home/HomeFragment.java
@@ -80,5 @@
>              menu.findItem(R.id.home_remove_history).setVisible(false);
>          }
>          menu.setHeaderTitle(info.title);
>  
>          menu.findItem(R.id.home_remove_history).setVisible(false);

Not part of this patch, but this is weird... there's an if statement up above to sometimes hide this item, but then we're always hiding it down below here.

I just looked into this a bit, and it's a bug. We're never showing the "Remove history" item, only the "Remove bookmark" item, which causes weirdness if you try to remove an item from the history list. I'll file a bug about that.
Attachment #779993 - Flags: review?(margaret.leibovic) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/projects/fig/rev/bd7116ff808e
Whiteboard: abouthome-hackathon → abouthome-hackathon, fixed-fig

Comment 4

4 years ago
https://hg.mozilla.org/mozilla-central/rev/bd7116ff808e
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.